Skip to content

Commit aa7c34c

Browse files
lunnylafriks
lunny
authored and
lafriks
committed
Fix error log when loading issues caused by a xorm bug (#7271)
* fix error log when loading issues caused by a xorm bug * upgrade packages * fix fmt * fix Consistency * fix tests
1 parent baefea3 commit aa7c34c

File tree

156 files changed

+1850
-1829
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

156 files changed

+1850
-1829
lines changed

‎go.mod

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ require (
2727
github.com/cznic/b v0.0.0-20181122101859-a26611c4d92d // indirect
2828
github.com/cznic/mathutil v0.0.0-20181122101859-297441e03548 // indirect
2929
github.com/cznic/strutil v0.0.0-20181122101858-275e90344537 // indirect
30-
github.com/denisenkom/go-mssqldb v0.0.0-20181014144952-4e0d7dc8888f
30+
github.com/denisenkom/go-mssqldb v0.0.0-20190121005146-b04fd42d9952
3131
github.com/dgrijalva/jwt-go v0.0.0-20161101193935-9ed569b5d1ac
3232
github.com/edsrzf/mmap-go v0.0.0-20170320065105-0bce6a688712 // indirect
3333
github.com/emirpasic/gods v1.12.0
@@ -54,10 +54,9 @@ require (
5454
github.com/go-macaron/session v0.0.0-20190131233854-0a0a789bf193
5555
github.com/go-macaron/toolbox v0.0.0-20180818072302-a77f45a7ce90
5656
github.com/go-redis/redis v6.15.2+incompatible
57-
github.com/go-sql-driver/mysql v1.4.0
58-
github.com/go-xorm/builder v0.3.3
59-
github.com/go-xorm/core v0.6.0
60-
github.com/go-xorm/xorm v0.0.0-20190116032649-a6300f2a45e0
57+
github.com/go-sql-driver/mysql v1.4.1
58+
github.com/go-xorm/core v0.6.0 // indirect
59+
github.com/go-xorm/xorm v0.7.3-0.20190620151208-f1b4f8368459
6160
github.com/gogits/chardet v0.0.0-20150115103509-2404f7772561
6261
github.com/gogits/cron v0.0.0-20160810035002-7f3990acf183
6362
github.com/gogo/protobuf v1.2.1 // indirect
@@ -133,12 +132,12 @@ require (
133132
gopkg.in/redis.v2 v2.3.2 // indirect
134133
gopkg.in/src-d/go-billy.v4 v4.3.0
135134
gopkg.in/src-d/go-git.v4 v4.12.0
135+
gopkg.in/stretchr/testify.v1 v1.2.2 // indirect
136136
gopkg.in/testfixtures.v2 v2.5.0
137137
mvdan.cc/xurls/v2 v2.0.0
138138
strk.kbt.io/projects/go/libravatar v0.0.0-20160628055650-5eed7bff870a
139+
xorm.io/builder v0.3.5
140+
xorm.io/core v0.6.3
139141
)
140142

141-
replace (
142-
github.com/denisenkom/go-mssqldb => github.com/denisenkom/go-mssqldb v0.0.0-20161128230840-e32ca5036449
143-
github.com/go-sql-driver/mysql => github.com/go-sql-driver/mysql v0.0.0-20181218123637-c45f530f8e7f
144-
)
143+
replace github.com/denisenkom/go-mssqldb => github.com/denisenkom/go-mssqldb v0.0.0-20161128230840-e32ca5036449

‎go.sum

Lines changed: 15 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
cloud.google.com/go v0.30.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
2+
cloud.google.com/go v0.34.0 h1:eOI3/cP2VTU6uZLDYAoic+eyzzB9YyGmJ7eIjl8rOPg=
3+
cloud.google.com/go v0.34.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=
24
github.com/BurntSushi/toml v0.3.1 h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ=
35
github.com/BurntSushi/toml v0.3.1/go.mod h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU=
46
github.com/PuerkitoBio/goquery v0.0.0-20170324135448-ed7d758e9a34 h1:UsHpWO0Elp6NaWVARdZHjiYwkhrspHVEGsyIKPb9OI8=
@@ -117,17 +119,14 @@ github.com/go-macaron/toolbox v0.0.0-20180818072302-a77f45a7ce90 h1:3wYKrRg9IjUM
117119
github.com/go-macaron/toolbox v0.0.0-20180818072302-a77f45a7ce90/go.mod h1:Ut/NmkIMGVYlEdJBzEZgWVWG5ZpYS9BLmUgXfAgi+qM=
118120
github.com/go-redis/redis v6.15.2+incompatible h1:9SpNVG76gr6InJGxoZ6IuuxaCOQwDAhzyXg+Bs+0Sb4=
119121
github.com/go-redis/redis v6.15.2+incompatible/go.mod h1:NAIEuMOZ/fxfXJIrKDQDz8wamY7mA7PouImQ2Jvg6kA=
120-
github.com/go-sql-driver/mysql v0.0.0-20181218123637-c45f530f8e7f h1:fbIzwEaXt5b2bl9mm+PIufKTSGKk6ZuwSSTQ7iZj7Lo=
121-
github.com/go-sql-driver/mysql v0.0.0-20181218123637-c45f530f8e7f/go.mod h1:zAC/RDZ24gD3HViQzih4MyKcchzm+sOG5ZlKdlhCg5w=
122-
github.com/go-xorm/builder v0.3.2/go.mod h1:v8mE3MFBgtL+RGFNfUnAMUqqfk/Y4W5KuwCFQIEpQLk=
123-
github.com/go-xorm/builder v0.3.3 h1:v8grgrwOGv/iHXIEhIvOwHZIPLrpxRKSX8yWSMLFn/4=
124-
github.com/go-xorm/builder v0.3.3/go.mod h1:v8mE3MFBgtL+RGFNfUnAMUqqfk/Y4W5KuwCFQIEpQLk=
122+
github.com/go-sql-driver/mysql v1.4.1 h1:g24URVg0OFbNUTx9qqY1IRZ9D9z3iPyi5zKhQZpNwpA=
123+
github.com/go-sql-driver/mysql v1.4.1/go.mod h1:zAC/RDZ24gD3HViQzih4MyKcchzm+sOG5ZlKdlhCg5w=
125124
github.com/go-xorm/core v0.6.0 h1:tp6hX+ku4OD9khFZS8VGBDRY3kfVCtelPfmkgCyHxL0=
126125
github.com/go-xorm/core v0.6.0/go.mod h1:d8FJ9Br8OGyQl12MCclmYBuBqqxsyeedpXciV5Myih8=
127126
github.com/go-xorm/sqlfiddle v0.0.0-20180821085327-62ce714f951a h1:9wScpmSP5A3Bk8V3XHWUcJmYTh+ZnlHVyc+A4oZYS3Y=
128127
github.com/go-xorm/sqlfiddle v0.0.0-20180821085327-62ce714f951a/go.mod h1:56xuuqnHyryaerycW3BfssRdxQstACi0Epw/yC5E2xM=
129-
github.com/go-xorm/xorm v0.0.0-20190116032649-a6300f2a45e0 h1:GBnJjWjp2SGXBZsyZfYksyp7QocvQwf9vZQ0NRN2FXM=
130-
github.com/go-xorm/xorm v0.0.0-20190116032649-a6300f2a45e0/go.mod h1:EHS1htMQFptzMaIHKyzqpHGw6C9Rtug75nsq6DA9unI=
128+
github.com/go-xorm/xorm v0.7.3-0.20190620151208-f1b4f8368459 h1:JGEuhH169J7Wtm1hN/HFOGENsAq+6FDHfuhGEZj/1e4=
129+
github.com/go-xorm/xorm v0.7.3-0.20190620151208-f1b4f8368459/go.mod h1:UK1YDlWscDspd23xW9HC24749jhvwO6riZ/HUt3gbHQ=
131130
github.com/gogits/chardet v0.0.0-20150115103509-2404f7772561 h1:deE7ritpK04PgtpyVOS2TYcQEld9qLCD5b5EbVNOuLA=
132131
github.com/gogits/chardet v0.0.0-20150115103509-2404f7772561/go.mod h1:YgYOrVn3Nj9Tq0EvjmFbphRytDj7JNRoWSStJZWDJTQ=
133132
github.com/gogits/cron v0.0.0-20160810035002-7f3990acf183 h1:EBTlva3AOSb80G3JSwY6ZMdILEZJ1JKuewrbqrNjWuE=
@@ -170,8 +169,8 @@ github.com/issue9/identicon v0.0.0-20160320065130-d36b54562f4c h1:A/PDn117UYld5m
170169
github.com/issue9/identicon v0.0.0-20160320065130-d36b54562f4c/go.mod h1:5mTb/PQNkqmq2x3IxlQZE0aSnTksJg7fg/oWmJ5SKXQ=
171170
github.com/jackc/fake v0.0.0-20150926172116-812a484cc733 h1:vr3AYkKovP8uR8AvSGGUK1IDqRa5lAAvEkZG1LKaCRc=
172171
github.com/jackc/fake v0.0.0-20150926172116-812a484cc733/go.mod h1:WrMFNQdiFJ80sQsxDoMokWK1W5TQtxBFNpzWTD84ibQ=
173-
github.com/jackc/pgx v3.2.0+incompatible h1:0Vihzu20St42/UDsvZGdNE6jak7oi/UOeMzwMPHkgFY=
174-
github.com/jackc/pgx v3.2.0+incompatible/go.mod h1:0ZGrqGqkRlliWnWB4zKnWtjbSWbGkVEFm4TeybAXq+I=
172+
github.com/jackc/pgx v3.3.0+incompatible h1:Wa90/+qsITBAPkAZjiByeIGHFcj3Ztu+VzrrIpHjL90=
173+
github.com/jackc/pgx v3.3.0+incompatible/go.mod h1:0ZGrqGqkRlliWnWB4zKnWtjbSWbGkVEFm4TeybAXq+I=
175174
github.com/jarcoal/httpmock v0.0.0-20180424175123-9c70cfe4a1da/go.mod h1:ks+b9deReOc7jgqp+e7LuFiCBH6Rm5hL32cLcEAArb4=
176175
github.com/jaytaylor/html2text v0.0.0-20160923191438-8fb95d837f7d h1:ig/iUfDDg06RVW8OMby+GrmW6K2nPO3AFHlEIdvJSd4=
177176
github.com/jaytaylor/html2text v0.0.0-20160923191438-8fb95d837f7d/go.mod h1:CVKlgaMiht+LXvHG173ujK6JUhZXKb2u/BQtjPDIvyk=
@@ -225,7 +224,6 @@ github.com/mattn/go-isatty v0.0.7 h1:UvyT9uN+3r7yLEYSlJsbQGdsaB/a0DlgWP3pql6iwOc
225224
github.com/mattn/go-isatty v0.0.7/go.mod h1:Iq45c/XA43vh69/j3iqttzPXn0bhXyGjM0Hdxcsrc5s=
226225
github.com/mattn/go-oci8 v0.0.0-20190320171441-14ba190cf52d h1:m+dSK37rFf2fqppZhg15yI2IwC9BtucBiRwSDm9VL8g=
227226
github.com/mattn/go-oci8 v0.0.0-20190320171441-14ba190cf52d/go.mod h1:/M9VLO+lUPmxvoOK2PfWRZ8mTtB4q1Hy9lEGijv9Nr8=
228-
github.com/mattn/go-sqlite3 v1.9.0/go.mod h1:FPy6KqzDD04eiIsT53CuJW3U88zkxoIYsOqkbpncsNc=
229227
github.com/mattn/go-sqlite3 v1.10.0 h1:jbhqpg7tQe4SupckyijYiy0mJJ/pRyHvXf7JdWK860o=
230228
github.com/mattn/go-sqlite3 v1.10.0/go.mod h1:FPy6KqzDD04eiIsT53CuJW3U88zkxoIYsOqkbpncsNc=
231229
github.com/matttproud/golang_protobuf_extensions v1.0.1 h1:4hp9jkHxhMHkqkrB3Ix0jegS5sx/RkqARlsWZ6pIwiU=
@@ -255,7 +253,6 @@ github.com/pelletier/go-buffruneio v0.2.0 h1:U4t4R6YkofJ5xHm3dJzuRpPZ0mr5MMCoAWo
255253
github.com/pelletier/go-buffruneio v0.2.0/go.mod h1:JkE26KsDizTr40EUHkXVtNPvgGtbSNq5BcowyYOWdKo=
256254
github.com/philhofer/fwd v1.0.0 h1:UbZqGr5Y38ApvM/V/jEljVxwocdweyH+vmYvRPBnbqQ=
257255
github.com/philhofer/fwd v1.0.0/go.mod h1:gk3iGcWd9+svBvR0sR+KPcfE+RNWozjowpeBVG3ZVNU=
258-
github.com/pkg/errors v0.8.0/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
259256
github.com/pkg/errors v0.8.1 h1:iURUrRGxPUNPdy5/HRSm+Yj6okJ6UtLINN0Q9M4+h3I=
260257
github.com/pkg/errors v0.8.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
261258
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
@@ -328,6 +325,7 @@ github.com/ziutek/mymysql v1.5.4/go.mod h1:LMSpPZ6DbqWFxNCHW77HeMg9I646SAhApZ/wK
328325
go.etcd.io/bbolt v1.3.2 h1:Z/90sZLPOeCy2PwprqkFa25PdkusRzaj9P8zm/KNyvk=
329326
go.etcd.io/bbolt v1.3.2/go.mod h1:IbVyRI1SCnLcuJnV2u8VeU0CEYM7e686BmAb1XKL+uU=
330327
golang.org/x/crypto v0.0.0-20180820150726-614d502a4dac/go.mod h1:6SG95UA2DQfeDnfUPMdvaQW0Q7yPrPDi9nlGo2tz2b4=
328+
golang.org/x/crypto v0.0.0-20190122013713-64072686203f/go.mod h1:6SG95UA2DQfeDnfUPMdvaQW0Q7yPrPDi9nlGo2tz2b4=
331329
golang.org/x/crypto v0.0.0-20190219172222-a4c6cb3142f2/go.mod h1:6SG95UA2DQfeDnfUPMdvaQW0Q7yPrPDi9nlGo2tz2b4=
332330
golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
333331
golang.org/x/crypto v0.0.0-20190418165655-df01cb2cc480 h1:O5YqonU5IWby+w98jVUG9h7zlCWCcH4RHyPVReBmhzk=
@@ -376,6 +374,8 @@ golang.org/x/tools v0.0.0-20190618163018-fdf1049a943a/go.mod h1:/rFqwRUd4F7ZHNgw
376374
google.golang.org/appengine v1.1.0/go.mod h1:EbEs0AVv82hx2wNQdGPgUI5lhzA/G0D9YwlJXL52JkM=
377375
google.golang.org/appengine v1.2.0 h1:S0iUepdCWODXRvtE+gcRDd15L+k+k1AiHlMiMjefH24=
378376
google.golang.org/appengine v1.2.0/go.mod h1:xpcJRLb0r/rnEns0DIKYYv+WjYCduHsrkT7/EB5XEv4=
377+
google.golang.org/appengine v1.4.0 h1:/wp5JvzpHIxhs/dumFmF7BXTf3Z+dd4uXta4kVyO508=
378+
google.golang.org/appengine v1.4.0/go.mod h1:xpcJRLb0r/rnEns0DIKYYv+WjYCduHsrkT7/EB5XEv4=
379379
gopkg.in/alexcesaro/quotedprintable.v3 v3.0.0-20150716171945-2caba252f4dc h1:2gGKlE2+asNV9m7xrywl36YYNnBG5ZQ0r/BOOxqPpmk=
380380
gopkg.in/alexcesaro/quotedprintable.v3 v3.0.0-20150716171945-2caba252f4dc/go.mod h1:m7x9LTH6d71AHyAX77c9yqWCCa3UKHcVEj9y7hAtKDk=
381381
gopkg.in/asn1-ber.v1 v1.0.0-20150924051756-4e86f4367175 h1:nn6Zav2sOQHCFJHEspya8KqxhFwKci30UxHy3HXPTyQ=
@@ -419,3 +419,7 @@ mvdan.cc/xurls/v2 v2.0.0 h1:r1zSOSNS/kqtpmATyMMMvaZ4/djsesbYz5kr0+qMRWc=
419419
mvdan.cc/xurls/v2 v2.0.0/go.mod h1:2/webFPYOXN9jp/lzuj0zuAVlF+9g4KPFJANH1oJhRU=
420420
strk.kbt.io/projects/go/libravatar v0.0.0-20160628055650-5eed7bff870a h1:8q33ShxKXRwQ7JVd1ZnhIU3hZhwwn0Le+4fTeAackuM=
421421
strk.kbt.io/projects/go/libravatar v0.0.0-20160628055650-5eed7bff870a/go.mod h1:FJGmPh3vz9jSos1L/F91iAgnC/aejc0wIIrF2ZwJxdY=
422+
xorm.io/builder v0.3.5 h1:EilU39fvWDxjb1cDaELpYhsF+zziRBhew8xk4pngO+A=
423+
xorm.io/builder v0.3.5/go.mod h1:ZFbByS/KxZI1FKRjL05PyJ4YrK2bcxlUaAxdum5aTR8=
424+
xorm.io/core v0.6.3 h1:n1NhVZt1s2oLw1BZfX2ocIJsHyso259uPgg63BGr37M=
425+
xorm.io/core v0.6.3/go.mod h1:8kz/C6arVW/O9vk3PgCiMJO2hIAm1UcuOL3dSPyZ2qo=

‎models/action.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ import (
2424
"code.gitea.io/gitea/modules/util"
2525

2626
"github.com/Unknwon/com"
27-
"github.com/go-xorm/builder"
27+
"xorm.io/builder"
2828
)
2929

3030
// ActionType represents the type of an action.

‎models/consistency.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ func CheckConsistencyFor(t *testing.T, beansToCheck ...interface{}) {
3939
ptrToSliceValue := reflect.New(sliceType)
4040
ptrToSliceValue.Elem().Set(sliceValue)
4141

42-
assert.NoError(t, x.Where(bean).Find(ptrToSliceValue.Interface()))
42+
assert.NoError(t, x.Table(bean).Find(ptrToSliceValue.Interface()))
4343
sliceValue = ptrToSliceValue.Elem()
4444

4545
for i := 0; i < sliceValue.Len(); i++ {

‎models/issue.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ import (
1919
"code.gitea.io/gitea/modules/util"
2020

2121
"github.com/Unknwon/com"
22-
"github.com/go-xorm/builder"
2322
"github.com/go-xorm/xorm"
23+
"xorm.io/builder"
2424
)
2525

2626
// Issue represents an issue or pull request of repository.
@@ -1428,6 +1428,7 @@ func Issues(opts *IssuesOptions) ([]*Issue, error) {
14281428
if err := sess.Find(&issues); err != nil {
14291429
return nil, fmt.Errorf("Find: %v", err)
14301430
}
1431+
sess.Close()
14311432

14321433
if err := IssueList(issues).LoadAttributes(); err != nil {
14331434
return nil, fmt.Errorf("LoadAttributes: %v", err)

‎models/issue_comment.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ import (
1515
"code.gitea.io/gitea/modules/markup/markdown"
1616
"code.gitea.io/gitea/modules/setting"
1717
"github.com/Unknwon/com"
18-
"github.com/go-xorm/builder"
1918
"github.com/go-xorm/xorm"
19+
"xorm.io/builder"
2020

2121
api "code.gitea.io/gitea/modules/structs"
2222

‎models/issue_list.go

Lines changed: 26 additions & 50 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,7 @@ package models
77
import (
88
"fmt"
99

10-
"code.gitea.io/gitea/modules/log"
11-
12-
"github.com/go-xorm/builder"
10+
"xorm.io/builder"
1311
)
1412

1513
// IssueList defines a list of issues
@@ -148,19 +146,17 @@ func (issues IssueList) loadLabels(e Engine) error {
148146
var labelIssue LabelIssue
149147
err = rows.Scan(&labelIssue)
150148
if err != nil {
151-
// When there are no rows left and we try to close it, xorm will complain with an error.
152-
// Since that is not relevant for us, we can safely ignore it.
153-
if err := rows.Close(); err != nil {
154-
log.Error("IssueList.loadLabels: Close: %v", err)
149+
if err1 := rows.Close(); err1 != nil {
150+
return fmt.Errorf("IssueList.loadLabels: Close: %v", err1)
155151
}
156152
return err
157153
}
158154
issueLabels[labelIssue.IssueLabel.IssueID] = append(issueLabels[labelIssue.IssueLabel.IssueID], labelIssue.Label)
159155
}
160-
// When there are no rows left and we try to close it, xorm will complain with an error.
156+
// When there are no rows left and we try to close it.
161157
// Since that is not relevant for us, we can safely ignore it.
162-
if err := rows.Close(); err != nil {
163-
log.Error("IssueList.loadLabels: Close: %v", err)
158+
if err1 := rows.Close(); err1 != nil {
159+
return fmt.Errorf("IssueList.loadLabels: Close: %v", err1)
164160
}
165161
left -= limit
166162
issueIDs = issueIDs[limit:]
@@ -241,20 +237,16 @@ func (issues IssueList) loadAssignees(e Engine) error {
241237
var assigneeIssue AssigneeIssue
242238
err = rows.Scan(&assigneeIssue)
243239
if err != nil {
244-
// When there are no rows left and we try to close it, xorm will complain with an error.
245-
// Since that is not relevant for us, we can safely ignore it.
246-
if err := rows.Close(); err != nil {
247-
log.Error("IssueList.loadAssignees: Close: %v", err)
240+
if err1 := rows.Close(); err1 != nil {
241+
return fmt.Errorf("IssueList.loadAssignees: Close: %v", err1)
248242
}
249243
return err
250244
}
251245

252246
assignees[assigneeIssue.IssueAssignee.IssueID] = append(assignees[assigneeIssue.IssueAssignee.IssueID], assigneeIssue.Assignee)
253247
}
254-
// When there are no rows left and we try to close it, xorm will complain with an error.
255-
// Since that is not relevant for us, we can safely ignore it.
256-
if err := rows.Close(); err != nil {
257-
log.Error("IssueList.loadAssignees: Close: %v", err)
248+
if err1 := rows.Close(); err1 != nil {
249+
return fmt.Errorf("IssueList.loadAssignees: Close: %v", err1)
258250
}
259251
left -= limit
260252
issueIDs = issueIDs[limit:]
@@ -300,19 +292,15 @@ func (issues IssueList) loadPullRequests(e Engine) error {
300292
var pr PullRequest
301293
err = rows.Scan(&pr)
302294
if err != nil {
303-
// When there are no rows left and we try to close it, xorm will complain with an error.
304-
// Since that is not relevant for us, we can safely ignore it.
305-
if err := rows.Close(); err != nil {
306-
log.Error("IssueList.loadPullRequests: Close: %v", err)
295+
if err1 := rows.Close(); err1 != nil {
296+
return fmt.Errorf("IssueList.loadPullRequests: Close: %v", err1)
307297
}
308298
return err
309299
}
310300
pullRequestMaps[pr.IssueID] = &pr
311301
}
312-
// When there are no rows left and we try to close it, xorm will complain with an error.
313-
// Since that is not relevant for us, we can safely ignore it.
314-
if err := rows.Close(); err != nil {
315-
log.Error("IssueList.loadPullRequests: Close: %v", err)
302+
if err1 := rows.Close(); err1 != nil {
303+
return fmt.Errorf("IssueList.loadPullRequests: Close: %v", err1)
316304
}
317305
left -= limit
318306
issuesIDs = issuesIDs[limit:]
@@ -349,19 +337,15 @@ func (issues IssueList) loadAttachments(e Engine) (err error) {
349337
var attachment Attachment
350338
err = rows.Scan(&attachment)
351339
if err != nil {
352-
// When there are no rows left and we try to close it, xorm will complain with an error.
353-
// Since that is not relevant for us, we can safely ignore it.
354-
if err := rows.Close(); err != nil {
355-
log.Error("IssueList.loadAttachments: Close: %v", err)
340+
if err1 := rows.Close(); err1 != nil {
341+
return fmt.Errorf("IssueList.loadAttachments: Close: %v", err1)
356342
}
357343
return err
358344
}
359345
attachments[attachment.IssueID] = append(attachments[attachment.IssueID], &attachment)
360346
}
361-
// When there are no rows left and we try to close it, xorm will complain with an error.
362-
// Since that is not relevant for us, we can safely ignore it.
363-
if err := rows.Close(); err != nil {
364-
log.Error("IssueList.loadAttachments: Close: %v", err)
347+
if err1 := rows.Close(); err1 != nil {
348+
return fmt.Errorf("IssueList.loadAttachments: Close: %v", err1)
365349
}
366350
left -= limit
367351
issuesIDs = issuesIDs[limit:]
@@ -399,19 +383,15 @@ func (issues IssueList) loadComments(e Engine, cond builder.Cond) (err error) {
399383
var comment Comment
400384
err = rows.Scan(&comment)
401385
if err != nil {
402-
// When there are no rows left and we try to close it, xorm will complain with an error.
403-
// Since that is not relevant for us, we can safely ignore it.
404-
if err := rows.Close(); err != nil {
405-
log.Error("IssueList.loadComments: Close: %v", err)
386+
if err1 := rows.Close(); err1 != nil {
387+
return fmt.Errorf("IssueList.loadComments: Close: %v", err1)
406388
}
407389
return err
408390
}
409391
comments[comment.IssueID] = append(comments[comment.IssueID], &comment)
410392
}
411-
// When there are no rows left and we try to close it, xorm will complain with an error.
412-
// Since that is not relevant for us, we can safely ignore it.
413-
if err := rows.Close(); err != nil {
414-
log.Error("IssueList.loadComments: Close: %v", err)
393+
if err1 := rows.Close(); err1 != nil {
394+
return fmt.Errorf("IssueList.loadComments: Close: %v", err1)
415395
}
416396
left -= limit
417397
issuesIDs = issuesIDs[limit:]
@@ -461,19 +441,15 @@ func (issues IssueList) loadTotalTrackedTimes(e Engine) (err error) {
461441
var totalTime totalTimesByIssue
462442
err = rows.Scan(&totalTime)
463443
if err != nil {
464-
// When there are no rows left and we try to close it, xorm will complain with an error.
465-
// Since that is not relevant for us, we can safely ignore it.
466-
if err := rows.Close(); err != nil {
467-
log.Error("IssueList.loadTotalTrackedTimes: Close: %v", err)
444+
if err1 := rows.Close(); err1 != nil {
445+
return fmt.Errorf("IssueList.loadTotalTrackedTimes: Close: %v", err1)
468446
}
469447
return err
470448
}
471449
trackedTimes[totalTime.IssueID] = totalTime.Time
472450
}
473-
// When there are no rows left and we try to close it, xorm will complain with an error.
474-
// Since that is not relevant for us, we can safely ignore it.
475-
if err := rows.Close(); err != nil {
476-
log.Error("IssueList.loadTotalTrackedTimes: Close: %v", err)
451+
if err1 := rows.Close(); err1 != nil {
452+
return fmt.Errorf("IssueList.loadTotalTrackedTimes: Close: %v", err1)
477453
}
478454
left -= limit
479455
ids = ids[limit:]

‎models/issue_reaction.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,8 @@ import (
1111
"code.gitea.io/gitea/modules/setting"
1212
"code.gitea.io/gitea/modules/util"
1313

14-
"github.com/go-xorm/builder"
1514
"github.com/go-xorm/xorm"
15+
"xorm.io/builder"
1616
)
1717

1818
// Reaction represents a reactions on issues and comments.

‎models/issue_tracked_time.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ import (
1010
"code.gitea.io/gitea/modules/setting"
1111
api "code.gitea.io/gitea/modules/structs"
1212

13-
"github.com/go-xorm/builder"
1413
"github.com/go-xorm/xorm"
14+
"xorm.io/builder"
1515
)
1616

1717
// TrackedTime represents a time that was spent for a specific issue.

‎models/log.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import (
99

1010
"code.gitea.io/gitea/modules/log"
1111

12-
"github.com/go-xorm/core"
12+
"xorm.io/core"
1313
)
1414

1515
// XORMLogBridge a logger bridge from Logger to xorm

‎models/login_source.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ import (
1515
"strings"
1616

1717
"github.com/Unknwon/com"
18-
"github.com/go-xorm/core"
1918
"github.com/go-xorm/xorm"
19+
"xorm.io/core"
2020

2121
"code.gitea.io/gitea/modules/auth/ldap"
2222
"code.gitea.io/gitea/modules/auth/oauth2"

‎models/migrations/v31.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ import (
88
"fmt"
99
"time"
1010

11-
"github.com/go-xorm/core"
1211
"github.com/go-xorm/xorm"
12+
"xorm.io/core"
1313
)
1414

1515
func addLoginSourceSyncEnabledColumn(x *xorm.Engine) error {

‎models/migrations/v38.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ import (
99

1010
"code.gitea.io/gitea/models"
1111

12-
"github.com/go-xorm/core"
1312
"github.com/go-xorm/xorm"
13+
"xorm.io/core"
1414
)
1515

1616
func removeCommitsUnitType(x *xorm.Engine) (err error) {

‎models/migrations/v75.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
package migrations
66

77
import (
8-
"github.com/go-xorm/builder"
98
"github.com/go-xorm/xorm"
9+
"xorm.io/builder"
1010
)
1111

1212
func clearNonusedData(x *xorm.Engine) error {

0 commit comments

Comments
 (0)