Refactor link logic to live in workflows module

Author: william-allspice

models/actions/run.go

@@ -74,6 +74,7 @@ func (run *ActionRun) Link() string {
 	return fmt.Sprintf("%s/actions/runs/%d", run.Repo.Link(), run.Index)
 }
 
+// WorkflowLink return the url to the actions list filtered for this runs workflow
 func (run *ActionRun) WorkflowLink() string {
 	if run.Repo == nil {
 		return ""

modules/actions/workflows.go

@@ -5,9 +5,11 @@ package actions
 
 import (
 	"bytes"
+	"fmt"
 	"io"
 	"strings"
 
+	actions_model "code.gitea.io/gitea/models/actions"
 	"code.gitea.io/gitea/modules/git"
 	"code.gitea.io/gitea/modules/log"
 	api "code.gitea.io/gitea/modules/structs"
@@ -69,6 +71,42 @@ func ListWorkflows(commit *git.Commit) (git.Entries, error) {
 	return ret, nil
 }
 
+// GetRunsWorkflowFileLink return url for the source of the workflow file for an ActionRun
+func GetRunsWorkflowFileLink(run *actions_model.ActionRun, gitRepo *git.Repository) string {
+	if run.Repo == nil || run.CommitSHA == "" {
+		return ""
+	}
+
+	commit, err := gitRepo.GetCommit(run.CommitSHA)
+	if err != nil {
+		return ""
+	}
+
+	entries, err := ListWorkflows(commit)
+	if err != nil {
+		return ""
+	}
+
+	var workflowEntry *git.TreeEntry
+	for _, entry := range entries {
+		if entry.Name() == run.WorkflowID {
+			workflowEntry = entry
+			break
+		}
+	}
+
+	if workflowEntry == nil {
+		return ""
+	}
+
+	workflowFilePath := workflowEntry.GetPathInRepo()
+	if workflowFilePath == "" {
+		return ""
+	}
+
+	return fmt.Sprintf("%s/src/commit/%s/%s", run.Repo.Link(), run.CommitSHA, workflowFilePath)
+}
+
 func GetContentFromEntry(entry *git.TreeEntry) ([]byte, error) {
 	f, err := entry.Blob().DataAsync()
 	if err != nil {

routers/web/repo/actions/view.go

@@ -171,7 +171,7 @@ func ViewPost(ctx *context_module.Context) {
 	resp.State.Run.CanRerun = run.Status.IsDone() && ctx.Repo.CanWrite(unit.TypeActions)
 	resp.State.Run.CanDeleteArtifact = run.Status.IsDone() && ctx.Repo.CanWrite(unit.TypeActions)
 	resp.State.Run.Done = run.Status.IsDone()
-	resp.State.Run.WorkflowFileLink = getWorkflowFileLink(ctx, run)
+	resp.State.Run.WorkflowFileLink = actions.GetRunsWorkflowFileLink(run, ctx.Repo.GitRepo)
 	resp.State.Run.WorkflowID = run.WorkflowID
 	resp.State.Run.WorkflowLink = run.WorkflowLink()
 	resp.State.Run.IsSchedule = run.IsSchedule()
@@ -306,42 +306,6 @@ func ViewPost(ctx *context_module.Context) {
 	ctx.JSON(http.StatusOK, resp)
 }
 
-// getWorkflowFileLink return url for the source of the workflow file that was run
-func getWorkflowFileLink(ctx *context_module.Context, run *actions_model.ActionRun) string {
-	if run.Repo == nil || run.CommitSHA == "" {
-		return ""
-	}
-
-	commit, err := ctx.Repo.GitRepo.GetCommit(run.CommitSHA)
-	if err != nil {
-		return ""
-	}
-
-	entries, err := actions.ListWorkflows(commit)
-	if err != nil {
-		return ""
-	}
-
-	var workflowEntry *git.TreeEntry
-	for _, entry := range entries {
-		if entry.Name() == run.WorkflowID {
-			workflowEntry = entry
-			break
-		}
-	}
-
-	if workflowEntry == nil {
-		return ""
-	}
-
-	workflowFilePath := workflowEntry.GetPathInRepo()
-	if workflowFilePath == "" {
-		return ""
-	}
-
-	return fmt.Sprintf("%s/src/commit/%s/%s", run.Repo.Link(), run.CommitSHA, workflowFilePath)
-}
-
 // Rerun will rerun jobs in the given run
 // If jobIndexStr is a blank string, it means rerun all jobs
 func Rerun(ctx *context_module.Context) {