Skip to content

Commit d959688

Browse files
authored
Merge branch 'main' into frontend-index-init
2 parents 6fec338 + 09938cc commit d959688

File tree

5 files changed

+20
-13
lines changed

5 files changed

+20
-13
lines changed

options/locale/locale_en-US.ini

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ error = Error
9696
error404 = The page you are trying to reach either <strong>does not exist</strong> or <strong>you are not authorized</strong> to view it.
9797

9898
never = Never
99-
color = Color
10099

101100
[error]
102101
occurred = An error has occurred
@@ -984,6 +983,7 @@ commit_graph = Commit Graph
984983
commit_graph.select = Select branches
985984
commit_graph.hide_pr_refs = Hide Pull Requests
986985
commit_graph.monochrome = Mono
986+
commit_graph.color = Color
987987
blame = Blame
988988
normal_view = Normal View
989989
line = line
@@ -1100,6 +1100,7 @@ projects.board.set_default = "Set Default"
11001100
projects.board.set_default_desc = "Set this board as default for uncategorized issues and pulls"
11011101
projects.board.delete = "Delete Board"
11021102
projects.board.deletion_desc = "Deleting a project board moves all related issues to 'Uncategorized'. Continue?"
1103+
projects.board.color = "Color"
11031104
projects.open = Open
11041105
projects.close = Close
11051106

@@ -1803,6 +1804,7 @@ settings.content_type = POST Content Type
18031804
settings.secret = Secret
18041805
settings.slack_username = Username
18051806
settings.slack_icon_url = Icon URL
1807+
settings.slack_color = Color
18061808
settings.discord_username = Username
18071809
settings.discord_icon_url = Icon URL
18081810
settings.event_desc = Trigger On:

templates/repo/graph.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
</div>
4848
</div>
4949
<button id="flow-color-monochrome" class="ui labelled icon button{{if eq .Mode "monochrome"}} active{{end}}" title="{{.i18n.Tr "repo.commit_graph.monochrome"}}">{{svg "material-invert-colors" 16 "mr-2"}}{{.i18n.Tr "repo.commit_graph.monochrome"}}</button>
50-
<button id="flow-color-colored" class="ui labelled icon button{{if ne .Mode "monochrome"}} active{{end}}" title="{{.i18n.Tr "color"}}">{{svg "material-palette" 16 "mr-2"}}{{.i18n.Tr "color"}}</button>
50+
<button id="flow-color-colored" class="ui labelled icon button{{if ne .Mode "monochrome"}} active{{end}}" title="{{.i18n.Tr "repo.commit_graph.color"}}">{{svg "material-palette" 16 "mr-2"}}{{.i18n.Tr "repo.commit_graph.color"}}</button>
5151
</div>
5252
</h2>
5353
<div class="ui dividing"></div>

templates/repo/projects/view.tmpl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
</div>
2424

2525
<div class="field color-field">
26-
<label for="new_board_color">{{$.i18n.Tr "color"}}</label>
26+
<label for="new_board_color">{{$.i18n.Tr "repo.projects.board.color"}}</label>
2727
<div class="color picker column">
2828
<input class="color-picker" maxlength="7" placeholder="#c320f6" id="new_board_color_picker" name="color">
2929
<div class="column precolors">
@@ -116,7 +116,7 @@
116116
</div>
117117

118118
<div class="field color-field">
119-
<label for="new_board_color">{{$.i18n.Tr "color"}}</label>
119+
<label for="new_board_color">{{$.i18n.Tr "repo.projects.board.color"}}</label>
120120
<div class="color picker column">
121121
<input class="color-picker" maxlength="7" placeholder="#c320f6" id="new_board_color" name="color" value="{{.Color}}">
122122
<div class="column precolors">

templates/repo/settings/webhook/slack.tmpl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<input id="icon_url" name="icon_url" value="{{.SlackHook.IconURL}}" placeholder="e.g. https://example.com/img/favicon.png">
2121
</div>
2222
<div class="field">
23-
<label for="color">{{.i18n.Tr "color"}}</label>
23+
<label for="color">{{.i18n.Tr "repo.settings.slack_color"}}</label>
2424
<input id="color" name="color" value="{{.SlackHook.Color}}" placeholder="e.g. #dd4b39, good, warning, danger">
2525
</div>
2626
{{template "repo/settings/webhook/settings" .}}

web_src/js/features/common-global.js

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -119,14 +119,19 @@ export function initGlobalCommon() {
119119
$($(this).data('target')).slideToggle(100);
120120
});
121121

122-
// make table <tr> element clickable like a link
123-
$('tr[data-href]').on('click', function () {
124-
window.location = $(this).data('href');
125-
});
126-
127-
// make table <td> element clickable like a link
128-
$('td[data-href]').click(function () {
129-
window.location = $(this).data('href');
122+
// make table <tr> and <td> elements clickable like a link
123+
$('tr[data-href], td[data-href]').on('click', function (e) {
124+
const href = $(this).data('href');
125+
if (e.target.nodeName === 'A') {
126+
// if a user clicks on <a>, then the <tr> or <td> should not act as a link.
127+
return;
128+
}
129+
if (e.ctrlKey || e.metaKey) {
130+
// ctrl+click or meta+click opens a new window in modern browsers
131+
window.open(href);
132+
} else {
133+
window.location = href;
134+
}
130135
});
131136
}
132137

0 commit comments

Comments
 (0)