Skip to content

Commit dd81c29

Browse files
authored
Reaction improvements (#15836)
- Add some spacing to inline reactions - Adjust colors and add variables
1 parent 2a56547 commit dd81c29

File tree

3 files changed

+17
-7
lines changed

3 files changed

+17
-7
lines changed

web_src/less/_base.less

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@
9696
--color-input-border: #dedede;
9797
--color-input-border-hover: #cecece;
9898
--color-navbar: #f8f8f8;
99-
--color-light: #00000004;
99+
--color-light: #00000006;
100100
--color-light-border: #0000001d;
101101
--color-hover: #0000000f;
102102
--color-active: #00000014;
@@ -113,6 +113,8 @@
113113
--color-editor-line-highlight: var(--color-primary-light-6);
114114
--color-project-board-bg: var(--color-secondary-light-4);
115115
--color-caret: var(--color-text-dark);
116+
--color-reaction-bg: #0000000a;
117+
--color-reaction-active-bg: var(--color-primary-alpha-20);
116118
/* backgrounds */
117119
--checkbox-mask-checked: url('data:image/svg+xml;utf8,<svg xmlns="http://www.w3.org/2000/svg" viewBox="-1 -1 18 18" width="16" height="16"><path fill-rule="evenodd" d="M13.78 4.22a.75.75 0 010 1.06l-7.25 7.25a.75.75 0 01-1.06 0L2.22 9.28a.75.75 0 011.06-1.06L6 10.94l6.72-6.72a.75.75 0 011.06 0z"></path></svg>');
118120
--checkbox-mask-indeterminate: url('data:image/svg+xml;utf8,<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" width="16" height="16"><path fill-rule="evenodd" d="M2 7.75A.75.75 0 012.75 7h10a.75.75 0 010 1.5h-10A.75.75 0 012 7.75z"></path></svg>');

web_src/less/_repository.less

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1088,12 +1088,21 @@
10881088

10891089
.comment-code-cloud {
10901090
.segment.reactions {
1091+
margin-top: 16px !important;
1092+
margin-bottom: -8px !important;
10911093
border-top: none !important;
10921094

10931095
.ui.label {
10941096
border: 1px solid;
1095-
padding: 6px !important;
1097+
padding: 6px 10px !important;
1098+
margin: 0 2px;
10961099
border-radius: var(--border-radius);
1100+
border-color: var(--color-secondary-dark-1) !important;
1101+
}
1102+
1103+
.ui.label.basic.blue {
1104+
background-color: var(--color-reaction-active-bg) !important;
1105+
border-color: var(--color-primary-alpha-80) !important;
10971106
}
10981107
}
10991108

@@ -2316,6 +2325,7 @@
23162325
font-size: 14px;
23172326
font-weight: normal;
23182327
border-color: var(--color-secondary) !important;
2328+
background: var(--color-reaction-bg);
23192329

23202330
&.disabled {
23212331
cursor: default;
@@ -2328,7 +2338,7 @@
23282338
}
23292339

23302340
.ui.label.basic.blue {
2331-
background-color: var(--color-primary-alpha-20) !important;
2341+
background-color: var(--color-reaction-active-bg) !important;
23322342
border-color: var(--color-secondary) !important;
23332343
}
23342344

web_src/less/themes/theme-arc-green.less

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,8 @@
109109
--color-editor-line-highlight: var(--color-primary-light-5);
110110
--color-project-board-bg: var(--color-secondary-light-2);
111111
--color-caret: var(--color-text); /* should ideally be --color-text-dark, see #15651 */
112+
--color-reaction-bg: #ffffff12;
113+
--color-reaction-active-bg: var(--color-primary-alpha-40);
112114
}
113115

114116
::-webkit-calendar-picker-indicator {
@@ -119,10 +121,6 @@
119121
background-color: #383c4a;
120122
}
121123

122-
.repository .segment.reactions .ui.label.basic.blue {
123-
background: var(--color-primary-alpha-20) !important;
124-
}
125-
126124
[data-tooltip]::before,
127125
[data-tooltip]::after {
128126
background: #1b1c1d !important; /* .ui.inverted.popup */

0 commit comments

Comments
 (0)