Skip to content

Commit dfd19fa

Browse files
authored
Fine tune project board label colors and modal content background (#25419)
- The label text color on project board is not contrasting enough, changed to colors that are same as places that also used `useLightTextOnBackground` function ([util_render.go](https://github.com/go-gitea/gitea/blob/2cdf260f42d178d23a8db70db35664511aeab31e/modules/templates/util_render.go#L136-L141), [Context Popup](https://github.com/go-gitea/gitea/blob/2cdf260f42d178d23a8db70db35664511aeab31e/web_src/js/components/ContextPopup.vue#L81-L84)) - background of modal `content` is `#ffffff` (from fomantic) right now, which does not look good on dark mode, so changed to `var(--color-body)` Before: <img width="1378" alt="Screen Shot 2023-06-21 at 14 24 13" src="https://github.com/go-gitea/gitea/assets/17645053/1527ca28-c884-4ca9-a4be-7a72ad1a093a"> <img width="900" alt="Screen Shot 2023-06-21 at 14 25 52" src="https://github.com/go-gitea/gitea/assets/17645053/fab82116-7376-4027-a0a4-9eedf9fb0a30"> After: <img width="1383" alt="Screen Shot 2023-06-21 at 14 19 33" src="https://github.com/go-gitea/gitea/assets/17645053/fe0997e7-fee6-4522-bc4e-545088ec1cc8"> <img width="797" alt="Screen Shot 2023-06-21 at 14 32 42" src="https://github.com/go-gitea/gitea/assets/17645053/b0591af0-950c-4448-9430-34d6c7215971">
1 parent 59d2189 commit dfd19fa

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

web_src/css/base.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -214,8 +214,8 @@
214214
--color-placeholder-text: #aaa;
215215
--color-editor-line-highlight: var(--color-primary-light-6);
216216
--color-project-board-bg: var(--color-secondary-light-4);
217-
--color-project-board-dark-label: #555555;
218-
--color-project-board-light-label: #a6aab5;
217+
--color-project-board-dark-label: #111111;
218+
--color-project-board-light-label: #eeeeee;
219219
--color-caret: var(--color-text-dark);
220220
--color-reaction-bg: #0000000a;
221221
--color-reaction-hover-bg: var(--color-primary-light-5);

web_src/css/modules/modal.css

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
.ui.modal > .content,
3636
.ui.modal > form > .content {
3737
padding: 1.5em;
38+
background: var(--color-body);
3839
}
3940

4041
.ui.modal > .actions,

0 commit comments

Comments
 (0)