Skip to content

Commit f982a71

Browse files
silverwinddelvhlunny
authored
CSS color enhancements (#21534)
- Add [`accent-color`](https://developer.mozilla.org/en-US/docs/Web/CSS/accent-color) which will change the color of various native HTML elements from OS-color to specified one. Affects unstyled checkbox, radio, range and progress - Change `--color-accent` to `--color-primary-light-1` - Change progress bar color to `--color-accent` - Add new `--color-primary-contrast` meant to contrast over primary - Avoid layout shift on clicking `.viewed-file-form` - Add styles for `input[type=file]` upload button <img width="301" alt="Screen Shot 2022-10-21 at 18 05 35" src="https://user-images.githubusercontent.com/115237/197246896-7b3b5591-2934-4436-bf37-6aebcdfecb13.png"> <img width="98" alt="Screen Shot 2022-10-21 at 19 41 27" src="https://user-images.githubusercontent.com/115237/197256892-c8fc6a0a-5d2f-4757-a98b-a79f9b7fcbc5.png"> <img width="93" alt="image" src="https://user-images.githubusercontent.com/115237/197257029-293c02e9-ebf9-448a-a58f-ca418cf36953.png"> <img width="204" alt="Screen Shot 2022-10-21 at 18 21 24" src="https://user-images.githubusercontent.com/115237/197246957-a99f5178-bbd5-4204-bd32-7a6977026f76.png"> <img width="449" alt="Screen Shot 2022-10-21 at 18 56 59" src="https://user-images.githubusercontent.com/115237/197249305-d481abb7-9f16-4b48-936a-c75ed29f5b04.png"> <img width="449" alt="Screen Shot 2022-10-21 at 18 57 09" src="https://user-images.githubusercontent.com/115237/197249309-7ab70c3b-325e-41bc-a4ba-07402c6826b6.png"> Co-authored-by: delvh <[email protected]> Co-authored-by: Lunny Xiao <[email protected]>
1 parent 876ee8c commit f982a71

File tree

4 files changed

+28
-12
lines changed

4 files changed

+28
-12
lines changed

web_src/less/_base.less

+21-6
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
--height-loading: 12rem;
1313
/* base colors */
1414
--color-primary: #4183c4;
15+
--color-primary-contrast: #ffffff;
1516
--color-primary-dark-1: #3876b3;
1617
--color-primary-dark-2: #31699f;
1718
--color-primary-dark-3: #2b5c8b;
@@ -163,9 +164,11 @@
163164
--color-tooltip-text: #ffffff;
164165
--color-header-bar: #ffffff;
165166
--color-label-active-bg: #d0d0d0;
167+
--color-accent: var(--color-primary-light-1);
166168
--color-small-accent: var(--color-primary-light-6);
167-
--color-accent: var(--color-primary-light-4);
168169
--color-active-line: #fffbdd;
170+
171+
accent-color: var(--color-accent);
169172
}
170173

171174
:root * {
@@ -230,10 +233,10 @@ progress::-webkit-progress-bar {
230233
background: var(--color-secondary-dark-1);
231234
}
232235
progress::-webkit-progress-value {
233-
background-color: var(--color-secondary-dark-4);
236+
background-color: var(--color-accent);
234237
}
235238
progress::-moz-progress-bar {
236-
background: var(--color-secondary-dark-4);
239+
background-color: var(--color-accent);
237240
}
238241

239242
* {
@@ -260,6 +263,17 @@ progress::-moz-progress-bar {
260263
background: transparent;
261264
}
262265

266+
::file-selector-button {
267+
border: 1px solid var(--color-light-border);
268+
color: var(--color-text-light);
269+
background: var(--color-light);
270+
border-radius: var(--border-radius);
271+
}
272+
::file-selector-button:hover {
273+
color: var(--color-text);
274+
background: var(--color-hover);
275+
}
276+
263277
::selection {
264278
background: var(--color-primary-light-1) !important;
265279
color: var(--color-white) !important;
@@ -1598,11 +1612,11 @@ footer {
15981612

15991613
.activity-bar-graph {
16001614
background-color: var(--color-primary);
1601-
color: #fff;
1615+
color: var(--color-primary-contrast);
16021616
}
16031617

16041618
.activity-bar-graph-alt {
1605-
color: #fff;
1619+
color: var(--color-primary-contrast);
16061620
}
16071621

16081622
.archived-icon {
@@ -1899,6 +1913,7 @@ a.ui.label:hover {
18991913
.ui.primary.button,
19001914
.ui.primary.buttons .button {
19011915
background-color: var(--color-primary) !important;
1916+
color: var(--color-primary-contrast) !important;
19021917
}
19031918

19041919
.ui.primary.button:hover,
@@ -1914,7 +1929,7 @@ a.ui.label:hover {
19141929
.ui.basic.primary.button,
19151930
.ui.basic.primary.buttons .button {
19161931
box-shadow: inset 0 0 0 1px var(--color-primary) !important;
1917-
color: #fff !important;
1932+
color: var(--color-primary-contrast) !important;
19181933
}
19191934

19201935
.ui.basic.primary.button:hover,

web_src/less/_review.less

+4-4
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ a.blob-excerpt {
194194

195195
a.blob-excerpt:hover {
196196
background: var(--color-primary);
197-
color: #fff;
197+
color: var(--color-primary-contrast);
198198
}
199199

200200
// See the comment of createCommentEasyMDE() for the review editor
@@ -244,7 +244,7 @@ a.blob-excerpt:hover {
244244

245245
#review-box .review-comments-counter {
246246
background-color: var(--color-primary-light-4);
247-
color: #fff;
247+
color: var(--color-primary-contrast);
248248
}
249249

250250
#review-box:hover .review-comments-counter {
@@ -275,7 +275,7 @@ a.blob-excerpt:hover {
275275
.viewed-file-form {
276276
display: flex;
277277
align-items: center;
278-
border: 1px none;
278+
border: 1px solid transparent;
279279
padding: 4px 8px;
280280
margin: -8px 0; // just like other buttons in the diff box header
281281
border-radius: .285rem; // just like .ui.tiny.button
@@ -288,7 +288,7 @@ a.blob-excerpt:hover {
288288

289289
.viewed-file-checked-form {
290290
background-color: var(--color-small-accent);
291-
border: 1px solid var(--color-accent);
291+
border-color: var(--color-accent);
292292
}
293293

294294
#viewed-files-summary {

web_src/less/_tribute.less

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
.tribute-container li.highlight,
2424
.tribute-container li:hover {
2525
background: var(--color-primary) !important;
26-
color: #ffffff !important;
26+
color: var(--color-primary-contrast) !important;
2727
}
2828

2929
.tribute-item {

web_src/less/themes/theme-arc-green.less

+2-1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
:root {
55
--is-dark-theme: true;
66
--color-primary: #87ab63;
7+
--color-primary-contrast: #ffffff;
78
--color-primary-dark-1: #93b373;
89
--color-primary-dark-2: #9fbc82;
910
--color-primary-dark-3: #abc492;
@@ -135,8 +136,8 @@
135136
--color-reaction-active-bg: var(--color-primary-alpha-40);
136137
--color-header-bar: #2e323e;
137138
--color-label-active-bg: #4c525e;
139+
--color-accent: var(--color-primary-light-1);
138140
--color-small-accent: var(--color-primary-light-5);
139-
--color-accent: var(--color-primary-light-3);
140141
--color-active-line: #534d1b;
141142
}
142143

0 commit comments

Comments
 (0)