Skip to content

Commit a8942d2

Browse files
committed
runtime/pprof: disable TestMorestack on darwin/arm64
Something is weird about darwin and TestMorestack, but it is only manifesting on arm64 and race+amd64. Disable for now. Change-Id: I5862372fdd0b5ffae802fdefb65b2aa04e266fcc Reviewed-on: https://go-review.googlesource.com/c/go/+/294409 Reviewed-by: Dmitri Shuralyov <[email protected]> Trust: Russ Cox <[email protected]> Run-TryBot: Russ Cox <[email protected]> TryBot-Result: Go Bot <[email protected]>
1 parent 078f08f commit a8942d2

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/runtime/pprof/pprof_test.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -591,6 +591,11 @@ func TestMorestack(t *testing.T) {
591591
// https://build.golang.org/log/280d387327806e17c8aabeb38b9503dbbd942ed1
592592
t.Skip("skipping on darwin race detector")
593593
}
594+
if runtime.GOOS == "darwin" && runtime.GOARCH == "arm64" {
595+
// For whatever reason, darwin/arm64 also doesn't work.
596+
// https://build.golang.org/log/c45e82cc25f152642e6fb90d882ef5a8cd130ce5
597+
t.Skip("skipping on darwin/arm64")
598+
}
594599
testCPUProfile(t, stackContainsAll, []string{"runtime.newstack,runtime/pprof.growstack"}, avoidFunctions(), func(duration time.Duration) {
595600
t := time.After(duration)
596601
c := make(chan bool)

0 commit comments

Comments
 (0)