Skip to content

Commit 7431dee

Browse files
ianlancetaylorgopherbot
authored andcommitted
lif: import syscall rather than golang.org/x/sys/unix
It happens that everything we need is already defined in syscall. This avoids problems when this package is vendored into the standard library. For golang/go#54259 Change-Id: I999eba5d089a1dfb341e27ebf3651ace0de26947 Reviewed-on: https://go-review.googlesource.com/c/net/+/421419 Reviewed-by: Dmitri Shuralyov <[email protected]> Auto-Submit: Ian Lance Taylor <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> Run-TryBot: Ian Lance Taylor <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Ian Lance Taylor <[email protected]>
1 parent 0bcc04d commit 7431dee

File tree

5 files changed

+24
-30
lines changed

5 files changed

+24
-30
lines changed

lif/address.go

+6-7
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,8 @@ package lif
99

1010
import (
1111
"errors"
12+
"syscall"
1213
"unsafe"
13-
14-
"golang.org/x/sys/unix"
1514
)
1615

1716
// An Addr represents an address associated with packet routing.
@@ -27,7 +26,7 @@ type Inet4Addr struct {
2726
}
2827

2928
// Family implements the Family method of Addr interface.
30-
func (a *Inet4Addr) Family() int { return unix.AF_INET }
29+
func (a *Inet4Addr) Family() int { return syscall.AF_INET }
3130

3231
// An Inet6Addr represents an internet address for IPv6.
3332
type Inet6Addr struct {
@@ -37,7 +36,7 @@ type Inet6Addr struct {
3736
}
3837

3938
// Family implements the Family method of Addr interface.
40-
func (a *Inet6Addr) Family() int { return unix.AF_INET6 }
39+
func (a *Inet6Addr) Family() int { return syscall.AF_INET6 }
4140

4241
// Addrs returns a list of interface addresses.
4342
//
@@ -64,7 +63,7 @@ func Addrs(af int, name string) ([]Addr, error) {
6463
lifr.Name[i] = int8(ll.Name[i])
6564
}
6665
for _, ep := range eps {
67-
ioc := int64(unix.SIOCGLIFADDR)
66+
ioc := int64(syscall.SIOCGLIFADDR)
6867
err := ioctl(ep.s, uintptr(ioc), unsafe.Pointer(&lifr))
6968
if err != nil {
7069
continue
@@ -75,11 +74,11 @@ func Addrs(af int, name string) ([]Addr, error) {
7574
continue
7675
}
7776
switch sa.Family {
78-
case unix.AF_INET:
77+
case syscall.AF_INET:
7978
a := &Inet4Addr{PrefixLen: l}
8079
copy(a.IP[:], lifr.Lifru[4:8])
8180
as = append(as, a)
82-
case unix.AF_INET6:
81+
case syscall.AF_INET6:
8382
a := &Inet6Addr{PrefixLen: l, ZoneID: int(nativeEndian.Uint32(lifr.Lifru[24:28]))}
8483
copy(a.IP[:], lifr.Lifru[8:24])
8584
as = append(as, a)

lif/address_test.go

+5-6
Original file line numberDiff line numberDiff line change
@@ -9,20 +9,19 @@ package lif
99

1010
import (
1111
"fmt"
12+
"syscall"
1213
"testing"
13-
14-
"golang.org/x/sys/unix"
1514
)
1615

1716
type addrFamily int
1817

1918
func (af addrFamily) String() string {
2019
switch af {
21-
case unix.AF_UNSPEC:
20+
case syscall.AF_UNSPEC:
2221
return "unspec"
23-
case unix.AF_INET:
22+
case syscall.AF_INET:
2423
return "inet4"
25-
case unix.AF_INET6:
24+
case syscall.AF_INET6:
2625
return "inet6"
2726
default:
2827
return fmt.Sprintf("%d", af)
@@ -83,7 +82,7 @@ type addrPack struct {
8382
func addrPacks() ([]addrPack, error) {
8483
var lastErr error
8584
var aps []addrPack
86-
for _, af := range [...]int{unix.AF_UNSPEC, unix.AF_INET, unix.AF_INET6} {
85+
for _, af := range [...]int{syscall.AF_UNSPEC, syscall.AF_INET, syscall.AF_INET6} {
8786
as, err := Addrs(af, "")
8887
if err != nil {
8988
lastErr = err

lif/lif.go

+3-5
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,6 @@ package lif
1313

1414
import (
1515
"syscall"
16-
17-
"golang.org/x/sys/unix"
1816
)
1917

2018
type endpoint struct {
@@ -29,12 +27,12 @@ func (ep *endpoint) close() error {
2927
func newEndpoints(af int) ([]endpoint, error) {
3028
var lastErr error
3129
var eps []endpoint
32-
afs := []int{unix.AF_INET, unix.AF_INET6}
33-
if af != unix.AF_UNSPEC {
30+
afs := []int{syscall.AF_INET, syscall.AF_INET6}
31+
if af != syscall.AF_UNSPEC {
3432
afs = []int{af}
3533
}
3634
for _, af := range afs {
37-
s, err := syscall.Socket(af, unix.SOCK_DGRAM, 0)
35+
s, err := syscall.Socket(af, syscall.SOCK_DGRAM, 0)
3836
if err != nil {
3937
lastErr = err
4038
continue

lif/link.go

+8-9
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,8 @@
88
package lif
99

1010
import (
11+
"syscall"
1112
"unsafe"
12-
13-
"golang.org/x/sys/unix"
1413
)
1514

1615
// A Link represents logical data link information.
@@ -34,22 +33,22 @@ func (ll *Link) fetch(s uintptr) {
3433
for i := 0; i < len(ll.Name); i++ {
3534
lifr.Name[i] = int8(ll.Name[i])
3635
}
37-
ioc := int64(unix.SIOCGLIFINDEX)
36+
ioc := int64(syscall.SIOCGLIFINDEX)
3837
if err := ioctl(s, uintptr(ioc), unsafe.Pointer(&lifr)); err == nil {
3938
ll.Index = int(nativeEndian.Uint32(lifr.Lifru[:4]))
4039
}
41-
ioc = int64(unix.SIOCGLIFFLAGS)
40+
ioc = int64(syscall.SIOCGLIFFLAGS)
4241
if err := ioctl(s, uintptr(ioc), unsafe.Pointer(&lifr)); err == nil {
4342
ll.Flags = int(nativeEndian.Uint64(lifr.Lifru[:8]))
4443
}
45-
ioc = int64(unix.SIOCGLIFMTU)
44+
ioc = int64(syscall.SIOCGLIFMTU)
4645
if err := ioctl(s, uintptr(ioc), unsafe.Pointer(&lifr)); err == nil {
4746
ll.MTU = int(nativeEndian.Uint32(lifr.Lifru[:4]))
4847
}
4948
switch ll.Type {
50-
case unix.IFT_IPV4, unix.IFT_IPV6, unix.IFT_6TO4:
49+
case syscall.IFT_IPV4, syscall.IFT_IPV6, syscall.IFT_6TO4:
5150
default:
52-
ioc = int64(unix.SIOCGLIFHWADDR)
51+
ioc = int64(syscall.SIOCGLIFHWADDR)
5352
if err := ioctl(s, uintptr(ioc), unsafe.Pointer(&lifr)); err == nil {
5453
ll.Addr, _ = parseLinkAddr(lifr.Lifru[4:])
5554
}
@@ -79,7 +78,7 @@ func links(eps []endpoint, name string) ([]Link, error) {
7978
lifc := lifconf{Flags: sysLIFC_NOXMIT | sysLIFC_TEMPORARY | sysLIFC_ALLZONES | sysLIFC_UNDER_IPMP}
8079
for _, ep := range eps {
8180
lifn.Family = uint16(ep.af)
82-
ioc := int64(unix.SIOCGLIFNUM)
81+
ioc := int64(syscall.SIOCGLIFNUM)
8382
if err := ioctl(ep.s, uintptr(ioc), unsafe.Pointer(&lifn)); err != nil {
8483
continue
8584
}
@@ -94,7 +93,7 @@ func links(eps []endpoint, name string) ([]Link, error) {
9493
} else {
9594
nativeEndian.PutUint32(lifc.Lifcu[:], uint32(uintptr(unsafe.Pointer(&b[0]))))
9695
}
97-
ioc = int64(unix.SIOCGLIFCONF)
96+
ioc = int64(syscall.SIOCGLIFCONF)
9897
if err := ioctl(ep.s, uintptr(ioc), unsafe.Pointer(&lifc)); err != nil {
9998
continue
10099
}

lif/link_test.go

+2-3
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,8 @@ package lif
99

1010
import (
1111
"fmt"
12+
"syscall"
1213
"testing"
13-
14-
"golang.org/x/sys/unix"
1514
)
1615

1716
func (ll *Link) String() string {
@@ -26,7 +25,7 @@ type linkPack struct {
2625
func linkPacks() ([]linkPack, error) {
2726
var lastErr error
2827
var lps []linkPack
29-
for _, af := range [...]int{unix.AF_UNSPEC, unix.AF_INET, unix.AF_INET6} {
28+
for _, af := range [...]int{syscall.AF_UNSPEC, syscall.AF_INET, syscall.AF_INET6} {
3029
lls, err := Links(af, "")
3130
if err != nil {
3231
lastErr = err

0 commit comments

Comments
 (0)