Add bidichk linter

check for dangerous unicode character sequences

Author: breml

go.mod

@@ -15,6 +15,7 @@ require (
 	github.com/bkielbasa/cyclop v1.2.0
 	github.com/blizzy78/varnamelen v0.3.0
 	github.com/bombsimon/wsl/v3 v3.3.0
+	github.com/breml/bidichk v0.0.0-20211101215529-9b68d04c240e
 	github.com/butuzov/ireturn v0.1.1
 	github.com/charithe/durationcheck v0.0.9
 	github.com/daixiang0/gci v0.2.9

go.sum

@@ -0,0 +1,16 @@
+package golinters
+
+import (
+	"github.com/breml/bidichk/pkg/bidichk"
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+	"golang.org/x/tools/go/analysis"
+)
+
+func NewBiDiChkFuncName() *goanalysis.Linter {
+	return goanalysis.NewLinter(
+		"bidichk",
+		"Checks for dangerous unicode character sequences",
+		[]*analysis.Analyzer{bidichk.Analyzer},
+		nil,
+	).WithLoadMode(goanalysis.LoadModeSyntax)
+}

pkg/golinters/bidichk.go

@@ -542,6 +542,10 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithPresets(linter.PresetStyle).
 			WithLoadForGoAnalysis().
 			WithURL("https://github.com/blizzy78/varnamelen"),
+		linter.NewConfig(golinters.NewBiDiChkFuncName()).
+			WithSince("1.43.0").
+			WithPresets(linter.PresetBugs).
+			WithURL("https://github.com/breml/bidichk"),
 
 		// nolintlint must be last because it looks at the results of all the previous linters for unused nolint directives
 		linter.NewConfig(golinters.NewNoLintLint()).

pkg/lint/lintersdb/manager.go

@@ -0,0 +1,8 @@
+//args: -Ebidichk
+package testdata
+
+import "fmt"
+
+func main() {
+	fmt.Println("LEFT-TO-RIGHT-OVERRIDE: '‭', it is between the single quotes, but it is not visible with a regular editor") // ERROR "found dangerous unicode character sequence LEFT-TO-RIGHT-OVERRIDE"
+}