feat: add gochecksumtype linter (#3671)

Co-authored-by: Fernandez Ludovic <[email protected]>

Author: alecthomas

.golangci.reference.yml

@@ -2214,6 +2214,7 @@ linters:
     - gocheckcompilerdirectives
     - gochecknoglobals
     - gochecknoinits
+    - gochecksumtype
     - gocognit
     - goconst
     - gocritic
@@ -2330,6 +2331,7 @@ linters:
     - gocheckcompilerdirectives
     - gochecknoglobals
     - gochecknoinits
+    - gochecksumtype
     - gocognit
     - goconst
     - gocritic

go.mod

@@ -14,6 +14,7 @@ require (
 	github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24
 	github.com/GaijinEntertainment/go-exhaustruct/v3 v3.1.0
 	github.com/OpenPeeDeeP/depguard/v2 v2.1.0
+	github.com/alecthomas/go-check-sumtype v0.1.3
 	github.com/alexkohler/nakedret/v2 v2.0.2
 	github.com/alexkohler/prealloc v1.0.0
 	github.com/alingse/asasalint v0.0.11

go.sum

@@ -0,0 +1,80 @@
+package golinters
+
+import (
+	"strings"
+	"sync"
+
+	gochecksumtype "github.com/alecthomas/go-check-sumtype"
+	"golang.org/x/tools/go/analysis"
+	"golang.org/x/tools/go/packages"
+
+	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
+	"github.com/golangci/golangci-lint/pkg/lint/linter"
+	"github.com/golangci/golangci-lint/pkg/result"
+)
+
+const goCheckSumTypeName = "gochecksumtype"
+
+func NewGoCheckSumType() *goanalysis.Linter {
+	var mu sync.Mutex
+	var resIssues []goanalysis.Issue
+
+	analyzer := &analysis.Analyzer{
+		Name: goCheckSumTypeName,
+		Doc:  goanalysis.TheOnlyanalyzerDoc,
+		Run: func(pass *analysis.Pass) (any, error) {
+			issues, err := runGoCheckSumType(pass)
+			if err != nil {
+				return nil, err
+			}
+
+			if len(issues) == 0 {
+				return nil, nil
+			}
+
+			mu.Lock()
+			resIssues = append(resIssues, issues...)
+			mu.Unlock()
+
+			return nil, nil
+		},
+	}
+
+	return goanalysis.NewLinter(
+		goCheckSumTypeName,
+		`Run exhaustiveness checks on Go "sum types"`,
+		[]*analysis.Analyzer{analyzer},
+		nil,
+	).WithIssuesReporter(func(ctx *linter.Context) []goanalysis.Issue {
+		return resIssues
+	}).WithLoadMode(goanalysis.LoadModeTypesInfo)
+}
+
+func runGoCheckSumType(pass *analysis.Pass) ([]goanalysis.Issue, error) {
+	var resIssues []goanalysis.Issue
+
+	pkg := &packages.Package{
+		Fset:      pass.Fset,
+		Syntax:    pass.Files,
+		Types:     pass.Pkg,
+		TypesInfo: pass.TypesInfo,
+	}
+
+	var unknownError error
+	errors := gochecksumtype.Run([]*packages.Package{pkg})
+	for _, err := range errors {
+		err, ok := err.(gochecksumtype.Error)
+		if !ok {
+			unknownError = err
+			continue
+		}
+
+		resIssues = append(resIssues, goanalysis.NewIssue(&result.Issue{
+			FromLinter: goCheckSumTypeName,
+			Text:       strings.TrimPrefix(err.Error(), err.Pos().String()+": "),
+			Pos:        err.Pos(),
+		}, pass))
+	}
+
+	return resIssues, unknownError
+}

pkg/golinters/gochecksumtype.go

@@ -441,6 +441,12 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithSince("v1.12.0").
 			WithPresets(linter.PresetStyle),
 
+		linter.NewConfig(golinters.NewGoCheckSumType()).
+			WithSince("v1.55.0").
+			WithPresets(linter.PresetBugs).
+			WithLoadForGoAnalysis().
+			WithURL("https://github.com/alecthomas/go-check-sumtype"),
+
 		linter.NewConfig(golinters.NewGocognit(gocognitCfg)).
 			WithSince("v1.20.0").
 			WithPresets(linter.PresetComplexity).

pkg/lint/lintersdb/manager.go

@@ -0,0 +1,38 @@
+//golangcitest:args -Egochecksumtype
+package testdata
+
+import (
+	"log"
+)
+
+//sumtype:decl
+type SumType interface{ isSumType() }
+
+//sumtype:decl
+type One struct{} // want "type 'One' is not an interface"
+
+func (One) isSumType() {}
+
+type Two struct{}
+
+func (Two) isSumType() {}
+
+func sumTypeTest() {
+	var sum SumType = One{}
+	switch sum.(type) { // want "exhaustiveness check failed for sum type.*SumType.*missing cases for Two"
+	case One:
+	}
+
+	switch sum.(type) { // want "exhaustiveness check failed for sum type.*SumType.*missing cases for Two"
+	case One:
+	default:
+		panic("??")
+	}
+
+	log.Println("??")
+
+	switch sum.(type) {
+	case One:
+	case Two:
+	}
+}