improve report message and fix option description

Author: sivchari

.golangci.example.yml

@@ -628,8 +628,8 @@ linters-settings:
       begin: true
 
   tenv:
-    # The all option will run against all method in test file.
-    # By default, only methods that take *testing.T, *testing.B, and testing.TB as arguments are checked.
+    # The option `all` will run against whole test files (`_test.go`) regardless of method/function signatures.
+    # By default, only methods that take `*testing.T`, `*testing.B`, and `testing.TB` as arguments are checked.
     all: false
 
   unparam:

go.mod

@@ -69,7 +69,7 @@ require (
 	github.com/shazow/go-diff v0.0.0-20160112020656-b6b7b6733b8c
 	github.com/shirou/gopsutil/v3 v3.21.8
 	github.com/sirupsen/logrus v1.8.1
-	github.com/sivchari/tenv v1.2.6
+	github.com/sivchari/tenv v1.3.7
 	github.com/sonatard/noctx v0.0.1
 	github.com/sourcegraph/go-diff v0.6.1
 	github.com/spf13/cobra v1.2.1

go.sum

@@ -8,34 +8,41 @@ import (
 )
 
 var (
-	e = os.Setenv("a", "b") // ERROR "variable e is not using testing.Setenv"
+	e = os.Setenv("a", "b") // never seen
 )
 
 func setup() {
-	os.Setenv("a", "b")        // ERROR "func setup is not using testing.Setenv"
-	err := os.Setenv("a", "b") // ERROR "func setup is not using testing.Setenv"
-	if err != nil {
+	os.Setenv("a", "b")        // ERROR "os\\.Setenv\\(\\) can be replaced by `testing\\.Setenv\\(\\)` in setup"
+	err := os.Setenv("a", "b") // ERROR "os\\.Setenv\\(\\) can be replaced by `testing\\.Setenv\\(\\)` in setup"
+	_ = err
+	if err := os.Setenv("a", "b"); err != nil { // ERROR "os\\.Setenv\\(\\) can be replaced by `testing\\.Setenv\\(\\)` in setup"
 		_ = err
 	}
 }
 
 func TestF(t *testing.T) {
-	os.Setenv("a", "b")                         // ERROR "func TestF is not using testing.Setenv"
-	if err := os.Setenv("a", "b"); err != nil { // ERROR "func TestF is not using testing.Setenv"
+	os.Setenv("a", "b")        // ERROR "os\\.Setenv\\(\\) can be replaced by `t\\.Setenv\\(\\)` in TestF"
+	err := os.Setenv("a", "b") // ERROR "os\\.Setenv\\(\\) can be replaced by `t\\.Setenv\\(\\)` in TestF"
+	_ = err
+	if err := os.Setenv("a", "b"); err != nil { // ERROR "os\\.Setenv\\(\\) can be replaced by `t\\.Setenv\\(\\)` in TestF"
 		_ = err
 	}
 }
 
 func BenchmarkF(b *testing.B) {
-	os.Setenv("a", "b")                         // ERROR "func BenchmarkF is not using testing.Setenv"
-	if err := os.Setenv("a", "b"); err != nil { // ERROR "func BenchmarkF is not using testing.Setenv"
+	os.Setenv("a", "b")        // ERROR "os\\.Setenv\\(\\) can be replaced by `b\\.Setenv\\(\\)` in BenchmarkF"
+	err := os.Setenv("a", "b") // ERROR "os\\.Setenv\\(\\) can be replaced by `b\\.Setenv\\(\\)` in BenchmarkF"
+	_ = err
+	if err := os.Setenv("a", "b"); err != nil { // ERROR "os\\.Setenv\\(\\) can be replaced by `b\\.Setenv\\(\\)` in BenchmarkF"
 		_ = err
 	}
 }
 
 func testTB(tb testing.TB) {
-	os.Setenv("a", "b")                         // ERROR "func testTB is not using testing.Setenv"
-	if err := os.Setenv("a", "b"); err != nil { // ERROR "func testTB is not using testing.Setenv"
+	os.Setenv("a", "b")        // ERROR "os\\.Setenv\\(\\) can be replaced by `tb\\.Setenv\\(\\)` in testTB"
+	err := os.Setenv("a", "b") // ERROR "os\\.Setenv\\(\\) can be replaced by `tb\\.Setenv\\(\\)` in testTB"
+	_ = err
+	if err := os.Setenv("a", "b"); err != nil { // ERROR "os\\.Setenv\\(\\) can be replaced by `tb\\.Setenv\\(\\)` in testTB"
 		_ = err
 	}
 }

test/testdata/tenv_all_test.go

@@ -7,7 +7,7 @@ import (
 )
 
 var (
-	e = os.Setenv("a", "b") // OK
+	e = os.Setenv("a", "b") // never seen
 )
 
 func setup() {
@@ -19,22 +19,22 @@ func setup() {
 }
 
 func TestF(t *testing.T) {
-	os.Setenv("a", "b")                         // ERROR "func TestF is not using testing.Setenv"
-	if err := os.Setenv("a", "b"); err != nil { // ERROR "func TestF is not using testing.Setenv"
+	os.Setenv("a", "b")                         // ERROR "os\\.Setenv\\(\\) can be replaced by `t\\.Setenv\\(\\)` in TestF"
+	if err := os.Setenv("a", "b"); err != nil { // ERROR "os\\.Setenv\\(\\) can be replaced by `t\\.Setenv\\(\\)` in TestF"
 		_ = err
 	}
 }
 
 func BenchmarkF(b *testing.B) {
-	os.Setenv("a", "b")                         // ERROR "func BenchmarkF is not using testing.Setenv"
-	if err := os.Setenv("a", "b"); err != nil { // ERROR "func BenchmarkF is not using testing.Setenv"
+	os.Setenv("a", "b")                         // ERROR "os\\.Setenv\\(\\) can be replaced by `b\\.Setenv\\(\\)` in BenchmarkF"
+	if err := os.Setenv("a", "b"); err != nil { // ERROR "os\\.Setenv\\(\\) can be replaced by `b\\.Setenv\\(\\)` in BenchmarkF"
 		_ = err
 	}
 }
 
 func testTB(tb testing.TB) {
-	os.Setenv("a", "b")                         // ERROR "func testTB is not using testing.Setenv"
-	if err := os.Setenv("a", "b"); err != nil { // ERROR "func testTB is not using testing.Setenv"
+	os.Setenv("a", "b")                         // ERROR "os\\.Setenv\\(\\) can be replaced by `tb\\.Setenv\\(\\)` in testTB"
+	if err := os.Setenv("a", "b"); err != nil { // ERROR "os\\.Setenv\\(\\) can be replaced by `tb\\.Setenv\\(\\)` in testTB"
 		_ = err
 	}
 }