Skip to content

Commit 5d0a202

Browse files
committed
Fixed a bug that the Spring team found - tweak
1 parent 893bb0d commit 5d0a202

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

src/test/java/org/dataloader/DataLoaderOptionsTest.java

+10-4
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,8 @@ void canCopyExistingOptionValuesOnTransform() {
192192

193193
DataLoaderInstrumentation instrumentation1 = new DataLoaderInstrumentation() {
194194
};
195+
DataLoaderInstrumentation instrumentation2 = new DataLoaderInstrumentation() {
196+
};
195197
BatchLoaderContextProvider contextProvider1 = () -> null;
196198

197199
DataLoaderOptions startingOptions = DataLoaderOptions.newOptionsBuilder().setBatchingEnabled(false)
@@ -205,7 +207,8 @@ void canCopyExistingOptionValuesOnTransform() {
205207
assertThat(startingOptions.getInstrumentation(), equalTo(instrumentation1));
206208
assertThat(startingOptions.getBatchLoaderContextProvider(), equalTo(contextProvider1));
207209

208-
DataLoaderOptions newOptions = startingOptions.transform(builder -> builder.setBatchingEnabled(true));
210+
DataLoaderOptions newOptions = startingOptions.transform(builder ->
211+
builder.setBatchingEnabled(true).setInstrumentation(instrumentation2));
209212

210213

211214
// immutable
@@ -215,10 +218,13 @@ void canCopyExistingOptionValuesOnTransform() {
215218
assertThat(startingOptions.getInstrumentation(), equalTo(instrumentation1));
216219
assertThat(startingOptions.getBatchLoaderContextProvider(), equalTo(contextProvider1));
217220

218-
// copied values
219-
assertThat(newOptions.batchingEnabled(), equalTo(true));
221+
// stayed the same
220222
assertThat(newOptions.cachingEnabled(), equalTo(false));
221-
assertThat(newOptions.getInstrumentation(), equalTo(instrumentation1));
222223
assertThat(newOptions.getBatchLoaderContextProvider(), equalTo(contextProvider1));
224+
225+
// was changed
226+
assertThat(newOptions.batchingEnabled(), equalTo(true));
227+
assertThat(newOptions.getInstrumentation(), equalTo(instrumentation2));
228+
223229
}
224230
}

0 commit comments

Comments
 (0)