expanding test coverage

Author: dpep

graphene_sqlalchemy/converter.py

@@ -52,19 +52,17 @@ def dynamic_type():
             if not scalar:
                 # repackage as List
                 field.__dict__['_type'] = List(field.type)
+            return field
         elif isinstance(attr, RelationshipProperty):
-            field = convert_sqlalchemy_relationship(
+            return convert_sqlalchemy_relationship(
                 attr,
                 obj_type,
                 connection_field_factory,
                 field_kwargs.pop('batching', batching),
                 assoc_prop.value_attr,
                 **field_kwargs
             ).get_type()
-        else:
-            raise NotImplementedError(attr)
-
-        return field
+        # else, not supported
 
     return Dynamic(dynamic_type)
 

graphene_sqlalchemy/tests/models.py

@@ -76,7 +76,7 @@ def hybrid_prop(self):
 
     composite_prop = composite(CompositeFullName, first_name, last_name, doc="Composite")
 
-    pet_names = association_proxy('pets', 'name')
+    headlines = association_proxy('articles', 'headline')
 
 
 class Article(Base):
@@ -85,7 +85,7 @@ class Article(Base):
     headline = Column(String(100))
     pub_date = Column(Date())
     reporter_id = Column(Integer(), ForeignKey("reporters.id"))
-    reporter_pets = association_proxy('reporter', 'pets')
+    recommended_reads = association_proxy('reporter', 'articles')
 
 
 class ReflectedEditor(type):

graphene_sqlalchemy/tests/test_converter.py

@@ -287,14 +287,17 @@ class Meta:
 
 
 def test_should_convert_association_proxy():
-    class P(SQLAlchemyObjectType):
+    class PetType(SQLAlchemyObjectType):
         class Meta:
             model = Pet
+    class ArticleType(SQLAlchemyObjectType):
+        class Meta:
+            model = Article
 
     field = convert_sqlalchemy_association_proxy(
         Reporter,
-        Reporter.pet_names,
-        P,
+        Reporter.headlines,
+        PetType,
         get_global_registry(),
         default_connection_field_factory,
         True,
@@ -306,15 +309,15 @@ class Meta:
 
     dynamic_field = convert_sqlalchemy_association_proxy(
         Article,
-        Article.reporter_pets,
-        P,
+        Article.recommended_reads,
+        ArticleType,
         get_global_registry(),
         default_connection_field_factory,
         True,
         mock_resolver,
     )
     assert isinstance(dynamic_field, graphene.Dynamic)
-    assert dynamic_field.get_type().type.of_type == P
+    assert dynamic_field.get_type().type.of_type == ArticleType
 
 
 def test_should_postgresql_uuid_convert():

graphene_sqlalchemy/tests/test_query.py

@@ -57,6 +57,7 @@ def resolve_reporters(self, _info):
             columnProp
             hybridProp
             compositeProp
+            headlines
           }
           reporters {
             firstName
@@ -69,6 +70,7 @@ def resolve_reporters(self, _info):
             "hybridProp": "John",
             "columnProp": 2,
             "compositeProp": "John Doe",
+            "headlines": ['Hi!'],
         },
         "reporters": [{"firstName": "John"}, {"firstName": "Jane"}],
     }

graphene_sqlalchemy/tests/test_types.py

@@ -71,6 +71,12 @@ class Meta:
             model = Article
             interfaces = (Node,)
 
+    class PetType(SQLAlchemyObjectType):
+        class Meta:
+            model = Pet
+            interfaces = (Node,)
+
+
     assert list(ReporterType._meta.fields.keys()) == [
         # Columns
         "column_prop",  # SQLAlchemy retuns column properties first
@@ -84,7 +90,7 @@ class Meta:
         # Hybrid
         "hybrid_prop",
         # AssociationProxy
-        "pet_names",
+        "headlines",
         # Relationship
         "pets",
         "articles",
@@ -121,11 +127,15 @@ class Meta:
     assert favorite_article_field.type().description is None
 
     # assocation proxy
-    assoc_field = ReporterType._meta.fields['pet_names']
+    assoc_field = ReporterType._meta.fields['headlines']
     assert isinstance(assoc_field, Dynamic)
     assert isinstance(assoc_field.type().type, List)
     assert assoc_field.type().type.of_type == String
 
+    assoc_field = ArticleType._meta.fields['recommended_reads']
+    assert isinstance(assoc_field, Dynamic)
+    assert assoc_field.type().type == ArticleType.connection
+
 
 def test_sqlalchemy_override_fields():
     @convert_sqlalchemy_composite.register(CompositeFullName)
@@ -187,7 +197,7 @@ class Meta:
         # Then the automatic SQLAlchemy fields
         "id",
         "favorite_pet_kind",
-        "pet_names",
+        "headlines",
     ]
 
     first_name_field = ReporterType._meta.fields['first_name']
@@ -285,7 +295,7 @@ class Meta:
         "favorite_pet_kind",
         "composite_prop",
         "hybrid_prop",
-        "pet_names",
+        "headlines",
         "pets",
         "articles",
         "favorite_article",