Skip to content

Commit 374648e

Browse files
committed
fix tests
1 parent 9a05834 commit 374648e

File tree

3 files changed

+15
-4
lines changed

3 files changed

+15
-4
lines changed

graphene_sqlalchemy/tests/models.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,6 @@ class Reporter(Base):
6666
articles = relationship("Article", backref="reporter")
6767
favorite_article = relationship("Article", uselist=False)
6868

69-
pet_names = association_proxy('pets', 'name')
70-
7169
@hybrid_property
7270
def hybrid_prop(self):
7371
return self.first_name
@@ -78,6 +76,8 @@ def hybrid_prop(self):
7876

7977
composite_prop = composite(CompositeFullName, first_name, last_name, doc="Composite")
8078

79+
pet_names = association_proxy('pets', 'name')
80+
8181

8282
class Article(Base):
8383
__tablename__ = "articles"

graphene_sqlalchemy/tests/test_types.py

+10-1
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,8 @@ class Meta:
8383
"composite_prop",
8484
# Hybrid
8585
"hybrid_prop",
86+
# AssociationProxy
87+
"pet_names",
8688
# Relationship
8789
"pets",
8890
"articles",
@@ -118,6 +120,11 @@ class Meta:
118120
assert favorite_article_field.type().type == ArticleType
119121
assert favorite_article_field.type().description is None
120122

123+
# assocation proxy
124+
assoc_prop = ReporterType._meta.fields['pet_names']
125+
assert isinstance(assoc_prop, Dynamic)
126+
assert assoc_prop.type().type == List(String)
127+
121128

122129
def test_sqlalchemy_override_fields():
123130
@convert_sqlalchemy_composite.register(CompositeFullName)
@@ -179,6 +186,7 @@ class Meta:
179186
# Then the automatic SQLAlchemy fields
180187
"id",
181188
"favorite_pet_kind",
189+
"pet_names",
182190
]
183191

184192
first_name_field = ReporterType._meta.fields['first_name']
@@ -276,6 +284,7 @@ class Meta:
276284
"favorite_pet_kind",
277285
"composite_prop",
278286
"hybrid_prop",
287+
"pet_names",
279288
"pets",
280289
"articles",
281290
"favorite_article",
@@ -384,7 +393,7 @@ class Meta:
384393

385394
assert issubclass(CustomReporterType, ObjectType)
386395
assert CustomReporterType._meta.model == Reporter
387-
assert len(CustomReporterType._meta.fields) == 11
396+
assert len(CustomReporterType._meta.fields) == 12
388397

389398

390399
# Test Custom SQLAlchemyObjectType with Custom Options

graphene_sqlalchemy/types.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,9 @@ def construct_fields(
116116
inspected_model.column_attrs.items() +
117117
inspected_model.composites.items() +
118118
[(name, item) for name, item in inspected_model.all_orm_descriptors.items()
119-
if isinstance(item, (AssociationProxy, hybrid_property))] +
119+
if isinstance(item, hybrid_property)] +
120+
[(name, item) for name, item in inspected_model.all_orm_descriptors.items()
121+
if isinstance(item, AssociationProxy)] +
120122
inspected_model.relationships.items()
121123
)
122124

0 commit comments

Comments
 (0)