test: Switch to using keyword args to graphql/execute

Though it's questionable if this always makes sense in Python.
But some of the test may become a bit more readable.

Replicates graphql/graphql-js@9063ade

Author: Cito

src/graphql/utilities/introspection_from_schema.py

@@ -22,11 +22,11 @@ def introspection_from_schema(
     This is the inverse of build_client_schema. The primary use case is outside of the
     server context, for instance when doing schema comparisons.
     """
-    query_ast = parse(get_introspection_query(descriptions))
+    document = parse(get_introspection_query(descriptions))
 
     from ..execution.execute import execute, ExecutionResult
 
-    result = execute(schema, query_ast)
+    result = execute(schema, document)
     if not isinstance(result, ExecutionResult):
         raise RuntimeError("Introspection cannot be executed")
     if result.errors or not result.data:

tests/benchmarks/test_introspection_from_schema.py

@@ -7,6 +7,6 @@
 
 def test_execute_introspection_query(benchmark, big_schema_sdl):  # noqa: F811
     schema = build_schema(big_schema_sdl, assume_valid=True)
-    query = parse(get_introspection_query())
-    result = benchmark(lambda: execute(schema, query))
+    document = parse(get_introspection_query())
+    result = benchmark(lambda: execute(schema=schema, document=document))
     assert result.errors is None

tests/execution/test_abstract_async.py

@@ -96,7 +96,7 @@ async def is_type_of_used_to_resolve_runtime_type_for_interface():
             types=[CatType, DogType],
         )
 
-        query = """
+        source = """
             {
               pets {
                 name
@@ -110,7 +110,7 @@ async def is_type_of_used_to_resolve_runtime_type_for_interface():
             }
             """
 
-        result = await graphql(schema, query)
+        result = await graphql(schema=schema, source=source)
         assert result == (
             {
                 "pets": [
@@ -161,7 +161,7 @@ async def is_type_of_with_async_error():
             types=[CatType, DogType],
         )
 
-        query = """
+        source = """
             {
               pets {
                 name
@@ -175,7 +175,7 @@ async def is_type_of_with_async_error():
             }
             """
 
-        result = await graphql(schema, query)
+        result = await graphql(schema=schema, source=source)
         # Note: we get two errors, because first all types are resolved
         # and only then they are checked sequentially
         assert result.data == {"pets": [None, None]}
@@ -229,7 +229,7 @@ async def is_type_of_used_to_resolve_runtime_type_for_union():
             )
         )
 
-        query = """
+        source = """
             {
               pets {
                 ... on Dog {
@@ -244,7 +244,7 @@ async def is_type_of_used_to_resolve_runtime_type_for_union():
             }
             """
 
-        result = await graphql(schema, query)
+        result = await graphql(schema=schema, source=source)
         assert result == (
             {
                 "pets": [
@@ -306,7 +306,7 @@ async def resolve_type_on_interface_yields_useful_error():
             types=[CatType, DogType],
         )
 
-        query = """
+        source = """
             {
               pets {
                 name
@@ -320,7 +320,7 @@ async def resolve_type_on_interface_yields_useful_error():
             }
             """
 
-        result = await graphql(schema, query)
+        result = await graphql(schema=schema, source=source)
         assert result.data == {
             "pets": [
                 {"name": "Odie", "woofs": True},
@@ -382,7 +382,7 @@ async def resolve_type_on_union_yields_useful_error():
             )
         )
 
-        query = """
+        source = """
             {
               pets {
                 ... on Dog {
@@ -397,7 +397,7 @@ async def resolve_type_on_union_yields_useful_error():
             }
             """
 
-        result = await graphql(schema, query)
+        result = await graphql(schema=schema, source=source)
         assert result.data == {
             "pets": [
                 {"name": "Odie", "woofs": True},
@@ -454,7 +454,7 @@ async def resolve_type_allows_resolving_with_type_name():
             types=[CatType, DogType],
         )
 
-        query = """{
+        source = """{
           pets {
             name
             ... on Dog {
@@ -466,7 +466,7 @@ async def resolve_type_allows_resolving_with_type_name():
           }
         }"""
 
-        result = await graphql(schema, query)
+        result = await graphql(schema=schema, source=source)
         assert result == (
             {
                 "pets": [
@@ -514,7 +514,7 @@ async def resolve_type_can_be_caught():
             types=[CatType, DogType],
         )
 
-        query = """{
+        source = """{
           pets {
             name
             ... on Dog {
@@ -526,7 +526,7 @@ async def resolve_type_can_be_caught():
           }
         }"""
 
-        result = await graphql(schema, query)
+        result = await graphql(schema=schema, source=source)
         assert result == (
             {"pets": [None, None]},
             [

tests/execution/test_lists.py

@@ -37,11 +37,11 @@ def get_response(test_type, test_data):
         },
     )
 
-    schema = GraphQLSchema(data_type)
-
-    ast = parse("{ nest { test } }")
-
-    return execute(schema, ast, data)
+    return execute(
+        schema=GraphQLSchema(data_type),
+        document=parse("{ nest { test } }"),
+        context_value=data,
+    )
 
 
 def check_response(response, expected):

tests/execution/test_mutations.py

@@ -93,7 +93,8 @@ async def promise_and_fail_to_change_the_number(self, newNumber: int):
 def describe_execute_handles_mutation_execution_ordering():
     @mark.asyncio
     async def evaluates_mutations_serially():
-        doc = """
+        document = parse(
+            """
             mutation M {
               first: immediatelyChangeTheNumber(newNumber: 1) {
                 theNumber
@@ -112,8 +113,12 @@ async def evaluates_mutations_serially():
               }
             }
             """
+        )
 
-        awaitable_result = execute(schema, parse(doc), Root(6))
+        root_value = Root(6)
+        awaitable_result = execute(
+            schema=schema, document=document, root_value=root_value
+        )
         assert isinstance(awaitable_result, Awaitable)
         mutation_result = await awaitable_result
 
@@ -130,7 +135,8 @@ async def evaluates_mutations_serially():
 
     @mark.asyncio
     async def evaluates_mutations_correctly_in_presence_of_a_failed_mutation():
-        doc = """
+        document = parse(
+            """
             mutation M {
               first: immediatelyChangeTheNumber(newNumber: 1) {
                 theNumber
@@ -152,8 +158,12 @@ async def evaluates_mutations_correctly_in_presence_of_a_failed_mutation():
               }
             }
             """
+        )
 
-        awaitable_result = execute(schema, parse(doc), Root(6))
+        root_value = Root(6)
+        awaitable_result = execute(
+            schema=schema, document=document, root_value=root_value
+        )
         assert isinstance(awaitable_result, Awaitable)
         result = await awaitable_result
 

tests/execution/test_nonnull.py

@@ -96,9 +96,10 @@ async def promiseNonNullNest(self, _info):
 
 
 def execute_query(query, root_value):
-    return execute(schema, parse(query), root_value)
+    return execute(schema=schema, document=parse(query), root_value=root_value)
 
 
+# avoids also doing any nests
 def patch(data):
     return re.sub(
         r"\bsyncNonNull\b", "promiseNonNull", re.sub(r"\bsync\b", "promise", data)