Skip to content

Commit 4a75e26

Browse files
committed
Get rid of mutable default arguments
1 parent 511e41b commit 4a75e26

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

html5lib/html5parser.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -253,8 +253,10 @@ def parseFragment(self, stream, container="div", encoding=None,
253253
self._parse(stream, True, container=container, encoding=encoding)
254254
return self.tree.getFragment()
255255

256-
def parseError(self, errorcode="XXX-undefined-error", datavars={}):
256+
def parseError(self, errorcode="XXX-undefined-error", datavars=None):
257257
# XXX The idea is to make errorcode mandatory.
258+
if datavars is None:
259+
datavars = {}
258260
self.errors.append((self.tokenizer.stream.position(), errorcode, datavars))
259261
if self.strict:
260262
raise ParseError(E[errorcode] % datavars)

html5lib/treebuilders/etree_lxml.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,9 @@ def __init__(self, namespaceHTMLElements, fullTree=False):
193193
self.namespaceHTMLElements = namespaceHTMLElements
194194

195195
class Attributes(dict):
196-
def __init__(self, element, value={}):
196+
def __init__(self, element, value=None):
197+
if value is None:
198+
value = {}
197199
self._element = element
198200
dict.__init__(self, value)
199201
for key, value in self.items():

0 commit comments

Comments
 (0)