Skip to content

Commit 0ac6c6d

Browse files
committed
Disable Windows 8.8.4 build
It's encountered the segfault every single time now. Maybe another release :( Also remove the disable-documentation flag since the cabal.project file has been updated
1 parent 5ac8653 commit 0ac6c6d

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

.github/workflows/build.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ jobs:
1818
ghc: ['8.10.1', '8.8.4', '8.8.3', '8.8.2', '8.6.5', '8.6.4']
1919
os: [ubuntu-latest, macOS-latest, windows-latest]
2020
exclude:
21+
- os: windows-latest
22+
ghc: '8.8.4' # also fails due to segfault :(
2123
- os: windows-latest
2224
ghc: '8.8.3' # fails due to segfault
2325
- os: windows-latest
@@ -53,8 +55,8 @@ jobs:
5355
- name: Build Server
5456
# Try building it twice in case of flakey builds on Windows
5557
run: |
56-
cabal build exe:hls -O2 --disable-documentation $LINUX_CABAL_ARGS || \
57-
cabal build exe:hls -O2 --disable-documentation $LINUX_CABAL_ARGS -j1
58+
cabal build exe:hls -O2 $LINUX_CABAL_ARGS || \
59+
cabal build exe:hls -O2 $LINUX_CABAL_ARGS -j1
5860
5961
- name: Compress Server Binary
6062
id: compress_server_binary
@@ -93,7 +95,7 @@ jobs:
9395

9496
- name: Build Wrapper
9597
if: matrix.ghc == '8.10.1'
96-
run: cabal build exe:hls-wrapper -O2 --disable-documentation $WIN_CABAL_ARGS $LINUX_CABAL_ARGS
98+
run: cabal build exe:hls-wrapper -O2 $LINUX_CABAL_ARGS
9799

98100
- name: Compress Wrapper Binary
99101
if: matrix.ghc == '8.10.1'

0 commit comments

Comments
 (0)