Skip to content

Commit 10a28b5

Browse files
fendorsoulomoon
andauthored
Enable hls-stan-plugin for GHC 9.10.1 (#4437)
Co-authored-by: soulomoon <[email protected]>
1 parent 75a6dd7 commit 10a28b5

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

.github/workflows/test.yml

+1-2
Original file line numberDiff line numberDiff line change
@@ -160,8 +160,7 @@ jobs:
160160
name: Test hls-splice-plugin
161161
run: cabal test hls-splice-plugin-tests || cabal test hls-splice-plugin-tests
162162

163-
# TODO enable when it supports 9.10
164-
- if: matrix.test && matrix.ghc != '9.10'
163+
- if: matrix.test
165164
name: Test hls-stan-plugin
166165
run: cabal test hls-stan-plugin-tests || cabal test hls-stan-plugin-tests
167166

cabal.project

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ packages:
88
./hls-test-utils
99

1010

11-
index-state: 2024-08-22T00:00:00Z
11+
index-state: 2024-10-21T00:00:00Z
1212

1313
tests: True
1414
test-show-details: direct

docs/support/plugin-support.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,6 @@ For example, a plugin to provide a formatter which has itself been abandoned has
6565
| `hls-overloaded-record-dot-plugin` | 2 | |
6666
| `hls-semantic-tokens-plugin` | 2 | |
6767
| `hls-floskell-plugin` | 3 | 9.10.1 |
68-
| `hls-stan-plugin` | 3 | 9.10.1 |
68+
| `hls-stan-plugin` | 3 | |
6969
| `hls-retrie-plugin` | 3 | 9.10.1 |
7070
| `hls-splice-plugin` | 3 | 9.10.1 |

haskell-language-server.cabal

+3-3
Original file line numberDiff line numberDiff line change
@@ -791,13 +791,13 @@ flag stan
791791
manual: True
792792

793793
common stan
794-
if flag(stan) && impl(ghc < 9.10.0)
794+
if flag(stan)
795795
build-depends: haskell-language-server:hls-stan-plugin
796796
cpp-options: -Dhls_stan
797797

798798
library hls-stan-plugin
799799
import: defaults, pedantic, warnings
800-
if flag(stan) && impl(ghc < 9.10.0)
800+
if flag(stan)
801801
buildable: True
802802
else
803803
buildable: False
@@ -825,7 +825,7 @@ library hls-stan-plugin
825825

826826
test-suite hls-stan-plugin-tests
827827
import: defaults, pedantic, test-defaults, warnings
828-
if flag(stan) && impl(ghc < 9.10.0)
828+
if flag(stan)
829829
buildable: True
830830
else
831831
buildable: False

0 commit comments

Comments
 (0)