Skip to content

Commit 993cfdd

Browse files
authored
Backport HIE files to GHC 8.6 (#689)
* Backport HIE files support to 8.6 * Use hie files as source of truth for name source spans. Since we started reusing `.hi` files, this exposes a bug where definitions aren't available since a bad source span from the `.hi` file gets put into the NameCache. We rectify by ensuring the span in the NameCache always matches the one from the `.hie` file. This has surfaced because an interaction between the commit which uses `.hi` instead of retypechecking and the change to use the shared global NameCache to read `.hie` files.
1 parent cbafcf2 commit 993cfdd

File tree

7 files changed

+3349
-29
lines changed

7 files changed

+3349
-29
lines changed

ghcide.cabal

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -155,6 +155,14 @@ library
155155
Development.IDE.Plugin.CodeAction.RuleTypes
156156
Development.IDE.Plugin.Completions.Logic
157157
Development.IDE.Plugin.Completions.Types
158+
if (impl(ghc > 8.5) && impl(ghc < 8.7)) && !flag(ghc-lib)
159+
hs-source-dirs: src-ghc86
160+
other-modules:
161+
Development.IDE.GHC.HieAst
162+
Development.IDE.GHC.HieBin
163+
Development.IDE.GHC.HieTypes
164+
Development.IDE.GHC.HieDebug
165+
Development.IDE.GHC.HieUtils
158166
if (impl(ghc > 8.7) && impl(ghc < 8.10)) || flag(ghc-lib)
159167
hs-source-dirs: src-ghc88
160168
other-modules:

0 commit comments

Comments
 (0)