Skip to content

Commit ced09a7

Browse files
authored
Add thread id in ghcide tests log (#4204)
* add threadId to ghcide test * add threadId to ghcide test * add thread id by default in ghcide-tests * remove redundant log
1 parent 75cb0b9 commit ced09a7

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

ghcide/exe/Main.hs

+2-2
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import qualified Development.IDE.Main as IDEMain
2121
import qualified Development.IDE.Monitoring.OpenTelemetry as OpenTelemetry
2222
import qualified Development.IDE.Plugin.HLS.GhcIde as GhcIde
2323
import Development.IDE.Types.Options
24-
import Ide.Logger (LoggingColumn (DataColumn, PriorityColumn),
24+
import Ide.Logger (LoggingColumn (..),
2525
Pretty (pretty),
2626
Priority (Debug, Error, Info),
2727
WithPriority (WithPriority, priority),
@@ -73,7 +73,7 @@ main = withTelemetryRecorder $ \telemetryRecorder -> do
7373
-- stderr recorder just for plugin cli commands
7474
pluginCliRecorder <-
7575
cmapWithPrio pretty
76-
<$> makeDefaultStderrRecorder (Just [PriorityColumn, DataColumn])
76+
<$> makeDefaultStderrRecorder (Just [ThreadIdColumn, PriorityColumn, DataColumn])
7777

7878
let hlsPlugins = pluginDescToIdePlugins (GhcIde.descriptors (cmapWithPrio LogGhcIde pluginCliRecorder))
7979
-- WARNING: If you write to stdout before runLanguageServer

ghcide/test/exe/Main.hs

+2-1
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,7 @@ import CompletionTests
4949
import CPPTests
5050
import CradleTests
5151
import DependentFileTest
52+
import Development.IDE (LoggingColumn (..))
5253
import DiagnosticTests
5354
import ExceptionTests
5455
import FindDefinitionAndHoverTests
@@ -74,7 +75,7 @@ import WatchedFileTests
7475

7576
main :: IO ()
7677
main = do
77-
docWithPriorityRecorder <- makeDefaultStderrRecorder (Just [PriorityColumn, DataColumn])
78+
docWithPriorityRecorder <- makeDefaultStderrRecorder (Just [ThreadIdColumn, PriorityColumn, DataColumn])
7879

7980
let docWithFilteredPriorityRecorder =
8081
docWithPriorityRecorder

hls-test-utils/src/Test/Hls/FileSystem.hs

-1
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ materialise rootDir' fileTree testDataDir' = do
115115
copyDir' root dir = do
116116
files <- fmap FP.normalise . lines <$> withCurrentDirectory (testDataDir </> dir) (readProcess "git" ["ls-files", "--cached", "--modified", "--others"] "")
117117
mapM_ (createDirectoryIfMissing True . ((root </>) . takeDirectory)) files
118-
mapM_ (\f -> putStrLn $ (testDataDir </> dir </> f) <> ":" <> (root </> f) ) files
119118
mapM_ (\f -> copyFile (testDataDir </> dir </> f) (root </> f)) files
120119
return ()
121120

0 commit comments

Comments
 (0)