Skip to content

Commit cf8ea51

Browse files
committed
clean up
1 parent 97e0476 commit cf8ea51

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

ghcide/src/Development/IDE/Plugin/HLS.hs

-1
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,6 @@ extensibleNotificationPlugins defaultConfig xs = Plugin mempty handlers
173173
handlers = mconcat $ do
174174
(IdeNotification m :=> IdeNotificationHandler fs') <- DMap.assocs handlers'
175175
pure $ notificationHandler m $ \ide params -> do
176-
liftIO $ logInfo (ideLogger ide) "extensibleNotificationPlugins handler entered"
177176
config <- fromMaybe defaultConfig <$> Ide.PluginUtils.getClientConfig
178177
let fs = filter (\(pid,_) -> pluginEnabledNotification m pid config) fs'
179178
case nonEmpty fs of

hls-plugin-api/src/Ide/Types.hs

-11
Original file line numberDiff line numberDiff line change
@@ -247,20 +247,9 @@ newtype PluginHandler a (m :: Method FromClient Request)
247247

248248
newtype PluginNotificationHandler a (m :: Method FromClient Notification)
249249
= PluginNotificationHandler (PluginId -> a -> MessageParams m -> LspM Config ())
250-
-- newtype PluginNotificationHandler a (m :: Method FromClient Notification)
251-
-- = PluginNotificationHandler (PluginNotificationMethodHandler a m)`
252-
253-
{-
254-
From Zubin
255-
alanz_: I would say `newtype PluginNotificationHandler a (m :: Method FromClient Notification) = PluginNotificationHandler (PluginNotificationMethodHandler a m)`
256-
16:28 and `newtype PluginNotificationHandlers a = PluginNotificationHandlers (DMap SMethod (PluginNotificationHandler a))
257-
258-
-}
259250

260251
newtype PluginHandlers a = PluginHandlers (DMap IdeMethod (PluginHandler a))
261252
newtype PluginNotificationHandlers a = PluginNotificationHandlers (DMap IdeNotification (PluginNotificationHandler a))
262-
-- newtype PluginNotificationHandlers a = PluginNotificationHandlers (DMap SMethod (PluginNotificationHandler a))
263-
264253
instance Semigroup (PluginHandlers a) where
265254
(PluginHandlers a) <> (PluginHandlers b) = PluginHandlers $ DMap.unionWithKey go a b
266255
where

0 commit comments

Comments
 (0)