fix: add prettier and eslint (#388)

* add eslintrc

* eslint and prettier all files

* fix: replace by npm script

* fix: prettify more files

* fixes based on review

Author: thedaviddias

.eslintrc.js

@@ -10,7 +10,4 @@ module.exports = {
     ecmaVersion: 6,
     sourceType: 'module',
   },
-  rules: {
-    'one-var': ['error', 'never'],
-  },
 }

.prettierignore

@@ -14,11 +14,3 @@ package-lock.json
 npm-debug.log*
 .nyc_output
 test/html
-
-# Ignore formatting of ***x*** to **_x_**
-.github/PULL_REQUEST_TEMPLATE.md
-
-/website/playground
-/website/.docusaurus
-/website/plugins
-/website/static

CHANGELOG.md

@@ -1,21 +1,3 @@
-# [0.13.0](https://github.com/htmlhint/HTMLHint/compare/v0.12.2...v0.13.0) (2020-05-18)
-
-
-### Bug Fixes
-
-* add prettier and eslint ([#388](https://github.com/htmlhint/HTMLHint/issues/388)) ([aba3249](https://github.com/htmlhint/HTMLHint/commit/aba3249652181055f5897e0b4367b243f83ede3f))
-* add semantic release test ([#399](https://github.com/htmlhint/HTMLHint/issues/399)) ([616f9cd](https://github.com/htmlhint/HTMLHint/commit/616f9cd74a9463e6596198f867f35aab24094110))
-* ignore PULL_REQUEST_TEMPLATE.md ([30b0af2](https://github.com/htmlhint/HTMLHint/commit/30b0af2f86a4daa7ef3bd07e91e8220b7d4b75f3))
-* use yml in semantic.yml ([86f6700](https://github.com/htmlhint/HTMLHint/commit/86f67007a32f5e978921507c05a2620edc1f9afc))
-
-
-### Features
-
-* Add tags checking rule - allows specify rules for any tag and validate that ([#384](https://github.com/htmlhint/HTMLHint/issues/384)) ([475aaca](https://github.com/htmlhint/HTMLHint/commit/475aaca431fab90a0ead7b21af7a73d4f0324514))
-* added attr-no-unnecessary-whitespace rule ([#385](https://github.com/htmlhint/HTMLHint/issues/385)) ([03bfd4f](https://github.com/htmlhint/HTMLHint/commit/03bfd4f7f6b60543a4253cad74758c794fc8cd18))
-* new rule: input-requires-label - All inputs require a label ([#159](https://github.com/htmlhint/HTMLHint/issues/159)) ([5bd40fb](https://github.com/htmlhint/HTMLHint/commit/5bd40fbc06b0d178cff4b9665ca992232dcb1f43))
-* new website for htmlhint.com ([#395](https://github.com/htmlhint/HTMLHint/issues/395)) ([5d0d95f](https://github.com/htmlhint/HTMLHint/commit/5d0d95f39dddddf94a22d3c6294e4e50472fa0a0))
-
 # HTMLHint change log
 
 ## ver 0.9.14 (2016-5-2)

bin/formatter.js

@@ -11,7 +11,6 @@ var options
 // load formatters
 mapFormatters = loadFormatters()
 arrSupportedFormatters = []
-
 for (var formatterName in mapFormatters) {
   if (formatterName !== 'default') {
     arrSupportedFormatters.push(formatterName)
@@ -27,31 +26,25 @@ function loadFormatters() {
     strict: false,
     silent: true,
   })
-
   var mapFormatters = {}
   arrFiles.forEach(function (file) {
     var fileInfo = path.parse(file)
     var formatterPath = path.resolve(__dirname, file)
     mapFormatters[fileInfo.name] = require(formatterPath)
   })
-
   return mapFormatters
 }
 
 var formatter = new events.EventEmitter()
-
 formatter.getSupported = function () {
   return arrSupportedFormatters
 }
-
 formatter.init = function (tmpHTMLHint, tmpOptions) {
   HTMLHint = tmpHTMLHint
   options = tmpOptions
 }
-
 formatter.setFormat = function (format) {
   var formatHandel = mapFormatters[format]
-
   if (formatHandel === undefined) {
     console.log(
       'No supported formatter, supported formatters: %s'.red,

bin/formatters/checkstyle.js

@@ -4,11 +4,9 @@ var checkstyleFormatter = function (formatter) {
   formatter.on('end', function (event) {
     var arrFiles = []
     var arrAllMessages = event.arrAllMessages
-
     arrAllMessages.forEach(function (fileInfo) {
       var arrMessages = fileInfo.messages
       var arrErrors = []
-
       arrMessages.forEach(function (message) {
         arrErrors.push({
           error: {
@@ -22,7 +20,6 @@ var checkstyleFormatter = function (formatter) {
           },
         })
       })
-
       arrFiles.push({
         file: [
           {
@@ -33,7 +30,6 @@ var checkstyleFormatter = function (formatter) {
         ].concat(arrErrors),
       })
     })
-
     var objXml = {
       checkstyle: [
         {
@@ -43,7 +39,6 @@ var checkstyleFormatter = function (formatter) {
         },
       ].concat(arrFiles),
     }
-
     console.log(
       xml(objXml, {
         declaration: true,
@@ -52,5 +47,4 @@ var checkstyleFormatter = function (formatter) {
     )
   })
 }
-
 module.exports = checkstyleFormatter

bin/formatters/compact.js

@@ -1,6 +1,5 @@
 var compactFormatter = function (formatter, HTMLHint, options) {
   var nocolor = options.nocolor
-
   formatter.on('file', function (event) {
     event.messages.forEach(function (message) {
       console.log(
@@ -14,7 +13,6 @@ var compactFormatter = function (formatter, HTMLHint, options) {
       )
     })
   })
-
   formatter.on('end', function (event) {
     var allHintCount = event.allHintCount
     if (allHintCount > 0) {
@@ -24,5 +22,4 @@ var compactFormatter = function (formatter, HTMLHint, options) {
     }
   })
 }
-
 module.exports = compactFormatter

bin/formatters/default.js

@@ -1,38 +1,30 @@
 var defaultFormatter = function (formatter, HTMLHint, options) {
   var nocolor = options.nocolor
-
   formatter.on('start', function () {
     console.log('')
   })
-
   formatter.on('config', function (event) {
     var configPath = event.configPath
     console.log('   Config loaded: %s', nocolor ? configPath : configPath.cyan)
     console.log('')
   })
-
   formatter.on('file', function (event) {
     console.log('   ' + event.file.white)
-
     var arrLogs = HTMLHint.format(event.messages, {
       colors: nocolor ? false : true,
       indent: 6,
     })
-
     arrLogs.forEach(function (str) {
       console.log(str)
     })
-
     console.log('')
   })
-
   formatter.on('end', function (event) {
     var allFileCount = event.allFileCount
     var allHintCount = event.allHintCount
     var allHintFileCount = event.allHintFileCount
     var time = event.time
     var message
-
     if (allHintCount > 0) {
       message = 'Scanned %d files, found %d errors in %d files (%d ms)'
       console.log(

bin/formatters/html.js

@@ -13,7 +13,6 @@ var htmlFormatter = function (formatter) {
     fileContent =
       fileContent +
       '<tr><th>Number#</th><th>File Name</th><th>Line Number</th><th>Message</th></tr>'
-
     var arrAllMessages = event.arrAllMessages
     arrAllMessages.forEach(function (fileInfo) {
       var arrMessages = fileInfo.messages
@@ -31,7 +30,6 @@ var htmlFormatter = function (formatter) {
           '</td></tr>'
       })
     })
-
     fileContent = fileContent.replace('</table></body></html>')
     console.log(fileContent)
     fs.writeFileSync('report.html', fileContent)

bin/formatters/json.js

@@ -3,5 +3,4 @@ var jsonFormatter = function (formatter) {
     console.log(JSON.stringify(event.arrAllMessages))
   })
 }
-
 module.exports = jsonFormatter

bin/formatters/junit.js

@@ -4,11 +4,9 @@ var junitFormatter = function (formatter, HTMLHint) {
   formatter.on('end', function (event) {
     var arrTestcase = []
     var arrAllMessages = event.arrAllMessages
-
     arrAllMessages.forEach(function (fileInfo) {
       var arrMessages = fileInfo.messages
       var arrLogs = HTMLHint.format(arrMessages)
-
       arrTestcase.push({
         testcase: [
           {
@@ -28,7 +26,6 @@ var junitFormatter = function (formatter, HTMLHint) {
         ],
       })
     })
-
     var objXml = {
       testsuites: [
         {
@@ -45,7 +42,6 @@ var junitFormatter = function (formatter, HTMLHint) {
         },
       ],
     }
-
     console.log(
       xml(objXml, {
         declaration: true,
@@ -54,5 +50,4 @@ var junitFormatter = function (formatter, HTMLHint) {
     )
   })
 }
-
 module.exports = junitFormatter

bin/formatters/markdown.js

@@ -1,44 +1,37 @@
 var markdownFormatter = function (formatter, HTMLHint) {
   formatter.on('end', function (event) {
     console.log('# TOC')
-
     var arrToc = []
     var arrContents = []
     var arrAllMessages = event.arrAllMessages
-
     arrAllMessages.forEach(function (fileInfo) {
       var filePath = fileInfo.file
       var arrMessages = fileInfo.messages
       var errorCount = 0
       var warningCount = 0
-
       arrMessages.forEach(function (message) {
         if (message.type === 'error') {
           errorCount++
         } else {
           warningCount++
         }
       })
-
       arrToc.push('   - [' + filePath + '](#' + filePath + ')')
       arrContents.push('<a name="' + filePath + '" />')
       arrContents.push('# ' + filePath)
       arrContents.push('')
       arrContents.push(
         'Found ' + errorCount + ' errors, ' + warningCount + ' warnings'
       )
-
       var arrLogs = HTMLHint.format(arrMessages)
       arrContents.push('')
       arrLogs.forEach(function (log) {
         arrContents.push('    ' + log)
       })
       arrContents.push('')
     })
-
     console.log(arrToc.join('\r\n') + '\r\n')
     console.log(arrContents.join('\r\n'))
   })
 }
-
 module.exports = markdownFormatter

bin/formatters/unix.js

@@ -18,7 +18,6 @@ var unixFormatter = function (formatter, HTMLHint, options) {
       )
     })
   })
-
   formatter.on('end', function (event) {
     var allHintCount = event.allHintCount
     if (allHintCount > 0) {
@@ -28,5 +27,4 @@ var unixFormatter = function (formatter, HTMLHint, options) {
     }
   })
 }
-
 module.exports = unixFormatter