Skip to content

Commit b1ee228

Browse files
authored
refactor(common): replace hyper::common::ready with futures_util::ready (#3359)
1 parent b6e3b1b commit b1ee228

File tree

14 files changed

+17
-15
lines changed

14 files changed

+17
-15
lines changed

src/body/incoming.rs

+5
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,11 @@ use std::task::{Context, Poll};
77
use bytes::Bytes;
88
#[cfg(all(feature = "http1", any(feature = "client", feature = "server")))]
99
use futures_channel::{mpsc, oneshot};
10+
#[cfg(all(
11+
any(feature = "http1", feature = "http2"),
12+
any(feature = "client", feature = "server")
13+
))]
14+
use futures_util::ready;
1015
#[cfg(all(feature = "http1", any(feature = "client", feature = "server")))]
1116
use futures_util::{stream::FusedStream, Stream}; // for mpsc::Receiver
1217
#[cfg(all(feature = "http1", any(feature = "client", feature = "server")))]

src/client/conn/http1.rs

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ use std::task::{Context, Poll};
88

99
use crate::rt::{Read, Write};
1010
use bytes::Bytes;
11+
use futures_util::ready;
1112
use http::{Request, Response};
1213
use httparse::ParserConfig;
1314

src/client/conn/http2.rs

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ use std::task::{Context, Poll};
1010
use std::time::Duration;
1111

1212
use crate::rt::{Read, Write};
13+
use futures_util::ready;
1314
use http::{Request, Response};
1415

1516
use super::super::dispatch;

src/common/mod.rs

-13
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,3 @@
1-
#[cfg(all(
2-
any(feature = "client", feature = "server"),
3-
any(feature = "http1", feature = "http2")
4-
))]
5-
macro_rules! ready {
6-
($e:expr) => {
7-
match $e {
8-
std::task::Poll::Ready(v) => v,
9-
std::task::Poll::Pending => return std::task::Poll::Pending,
10-
}
11-
};
12-
}
13-
141
#[cfg(all(any(feature = "client", feature = "server"), feature = "http1"))]
152
pub(crate) mod buf;
163
#[cfg(all(feature = "server", any(feature = "http1", feature = "http2")))]

src/lib.rs

+1-2
Original file line numberDiff line numberDiff line change
@@ -106,9 +106,8 @@ mod cfg;
106106
#[macro_use]
107107
mod trace;
108108

109-
#[macro_use]
110-
mod common;
111109
pub mod body;
110+
mod common;
112111
mod error;
113112
pub mod ext;
114113
#[cfg(test)]

src/proto/h1/conn.rs

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ use std::time::Duration;
88

99
use crate::rt::{Read, Write};
1010
use bytes::{Buf, Bytes};
11+
use futures_util::ready;
1112
use http::header::{HeaderValue, CONNECTION, TE};
1213
use http::{HeaderMap, Method, Version};
1314
use httparse::ParserConfig;

src/proto/h1/decode.rs

+1
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ use std::task::{Context, Poll};
55
use std::usize;
66

77
use bytes::Bytes;
8+
use futures_util::ready;
89

910
use super::io::MemRead;
1011
use super::DecodedLength;

src/proto/h1/dispatch.rs

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ use std::{
88

99
use crate::rt::{Read, Write};
1010
use bytes::{Buf, Bytes};
11+
use futures_util::ready;
1112
use http::Request;
1213

1314
use super::{Http1Transaction, Wants};

src/proto/h1/io.rs

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ use std::task::{Context, Poll};
1010

1111
use crate::rt::{Read, ReadBuf, Write};
1212
use bytes::{Buf, BufMut, Bytes, BytesMut};
13+
use futures_util::ready;
1314

1415
use super::{Http1Transaction, ParseContext, ParsedMessage};
1516
use crate::common::buf::BufList;

src/proto/h2/client.rs

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ use bytes::Bytes;
1212
use futures_channel::mpsc::{Receiver, Sender};
1313
use futures_channel::{mpsc, oneshot};
1414
use futures_util::future::{Either, FusedFuture, FutureExt as _};
15+
use futures_util::ready;
1516
use futures_util::stream::{StreamExt as _, StreamFuture};
1617
use h2::client::{Builder, Connection, SendRequest};
1718
use h2::SendStream;

src/proto/h2/mod.rs

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ use std::pin::Pin;
66
use std::task::{Context, Poll};
77

88
use bytes::{Buf, Bytes};
9+
use futures_util::ready;
910
use h2::{Reason, RecvStream, SendStream};
1011
use http::header::{HeaderName, CONNECTION, TE, TRAILER, TRANSFER_ENCODING, UPGRADE};
1112
use http::HeaderMap;

src/proto/h2/server.rs

+1
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ use std::task::{Context, Poll};
66
use std::time::Duration;
77

88
use bytes::Bytes;
9+
use futures_util::ready;
910
use h2::server::{Connection, Handshake, SendResponse};
1011
use h2::{Reason, RecvStream};
1112
use http::{Method, Request};

src/server/conn/http1.rs

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ use std::time::Duration;
1212
use crate::rt::{Read, Write};
1313
use crate::upgrade::Upgraded;
1414
use bytes::Bytes;
15+
use futures_util::ready;
1516

1617
use crate::body::{Body, Incoming as IncomingBody};
1718
use crate::proto;

src/server/conn/http2.rs

+1
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ use std::task::{Context, Poll};
1010
use std::time::Duration;
1111

1212
use crate::rt::{Read, Write};
13+
use futures_util::ready;
1314
use pin_project_lite::pin_project;
1415

1516
use crate::body::{Body, Incoming as IncomingBody};

0 commit comments

Comments
 (0)