Skip to content

Commit bc683b0

Browse files
committed
remove assertion
Apparently, we actually hit this when the user explicitly enables vectored writes but the IO doesn't return `true` from `is_write_vectored`. This kind of begs the question, do those APIs still make sense? Is there ever a reason to enable writev on an IO that doesn't return `true` from `is_write_vectored`? I think that *disabling* vectored writes explicitly when the IO supports them makes sense, but I'm unconvinced about *enabling* them when it doesn't. @seanmonstar any thoughts? Signed-off-by: Eliza Weisman <[email protected]>
1 parent 32e3010 commit bc683b0

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

src/proto/h1/io.rs

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -241,11 +241,6 @@ where
241241
}
242242

243243
loop {
244-
debug_assert!(
245-
self.io.is_write_vectored(),
246-
"using vectored writes on an IO that does not provide fast vectored \
247-
write support, this is a bug"
248-
);
249244
let n = {
250245
let mut iovs = [IoSlice::new(&[]); MAX_WRITEV_VECS];
251246
let len = self.write_buf.bytes_vectored(&mut iovs);

0 commit comments

Comments
 (0)