Skip to content

Commit c8e334a

Browse files
committed
fix(headers): don't use Show to write UserAgent header
Signed-off-by: Peter Atashian <[email protected]>
1 parent 9fbf0ae commit c8e334a

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

src/header/common/user_agent.rs

+9-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
use header::{Header, HeaderFormat};
2-
use std::fmt::{self, Show};
2+
use std::fmt;
33
use header::shared::util::from_one_raw_str;
44

55
/// The `User-Agent` header field.
@@ -22,10 +22,16 @@ impl Header for UserAgent {
2222

2323
impl HeaderFormat for UserAgent {
2424
fn fmt_header(&self, fmt: &mut fmt::Formatter) -> fmt::Result {
25-
let UserAgent(ref value) = *self;
26-
value.fmt(fmt)
25+
fmt.write_str(&*self.0)
2726
}
2827
}
2928

3029
bench_header!(bench, UserAgent, { vec![b"cargo bench".to_vec()] });
3130

31+
#[test] fn test_format() {
32+
use std::borrow::ToOwned;
33+
use header::Headers;
34+
let mut head = Headers::new();
35+
head.set(UserAgent("Bunnies".to_owned()));
36+
assert!(head.to_string() == "User-Agent: Bunnies\r\n".to_owned());
37+
}

0 commit comments

Comments
 (0)