Skip to content

Commit d1ec737

Browse files
authored
fix: use groupAcronym to determine hackathon icon in agenda (#8540)
* fix: use groupAcronym to determine hackathon icon in agenda * test: fix agenda tests related to hackathon
1 parent ed19b54 commit d1ec737

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

client/agenda/AgendaScheduleList.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -307,7 +307,7 @@ const meetingEvents = computed(() => {
307307
})
308308
}
309309
// -> Point to Wiki for Hackathon sessions, HedgeDocs otherwise
310-
if (item.name.toLowerCase().includes('hackathon')) {
310+
if (item.groupAcronym === 'hackathon') {
311311
links.push({
312312
id: `lnk-${item.id}-wiki`,
313313
label: 'Wiki',
@@ -461,7 +461,7 @@ const meetingEvents = computed(() => {
461461
case 'other':
462462
if (item.name.toLowerCase().indexOf('office hours') >= 0) {
463463
icon = 'bi-building'
464-
} else if (item.name.toLowerCase().indexOf('hackathon') >= 0) {
464+
} else if (item.groupAcronym === 'hackathon') {
465465
icon = 'bi-command bi-pink'
466466
}
467467
break

playwright/helpers/meeting.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -395,7 +395,7 @@ module.exports = {
395395
name: 'Hackathon Kickoff',
396396
startDateTime: day1.set({ hour: 10, minute: 30 }),
397397
duration: '30m',
398-
...findAreaGroup('hackathon-kickoff', categories[2]),
398+
...findAreaGroup('hackathon', categories[2]),
399399
showAgenda: true,
400400
hasAgenda: true,
401401
hasRecordings: true,

playwright/tests/meeting/agenda.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ test.describe('past - desktop', () => {
238238
// Name column
239239
// -----------
240240
// Event icon
241-
if (['break', 'plenary'].includes(event.type) || (event.type === 'other' && ['office hours', 'hackathon'].some(s => event.name.toLowerCase().indexOf(s) >= 0))) {
241+
if (['break', 'plenary'].includes(event.type) || (event.type === 'other' && event.name.toLowerCase().indexOf('office hours') >= 0)) {
242242
await expect(row.locator('.agenda-table-cell-name > i.bi')).toBeVisible()
243243
}
244244
// Name link
@@ -286,7 +286,7 @@ test.describe('past - desktop', () => {
286286
// No meeting materials yet warning badge
287287
await expect(eventButtons.locator('.no-meeting-materials')).toBeVisible()
288288
}
289-
if (event.name.toLowerCase().includes('hackathon')) {
289+
if (event.groupAcronym === 'hackathon') {
290290
// Hackathon Wiki button
291291
const hackathonWikiLink = `https://wiki.ietf.org/meeting/${meetingData.meeting.number}/hackathon`
292292
await expect(eventButtons.locator(`#btn-lnk-${event.id}-wiki`)).toHaveAttribute('href', hackathonWikiLink)
@@ -1169,7 +1169,7 @@ test.describe('future - desktop', () => {
11691169
// No meeting materials yet warning badge
11701170
await expect(eventButtons.locator('.no-meeting-materials')).toBeVisible()
11711171
}
1172-
if (event.name.toLowerCase().includes('hackathon')) {
1172+
if (event.groupAcronym === 'hackathon') {
11731173
// Hackathon Wiki button
11741174
const hackathonWikiLink = `https://wiki.ietf.org/meeting/${meetingData.meeting.number}/hackathon`
11751175
await expect(eventButtons.locator(`#btn-lnk-${event.id}-wiki`)).toHaveAttribute('href', hackathonWikiLink)

0 commit comments

Comments
 (0)