Refactor flags to be early exits.

Refactor flags to be early exits.

Author: bgajdaINTC

IGC/Compiler/CISACodeGen/EmitVISAPass.cpp

@@ -5845,9 +5845,10 @@ void EmitPass::emitSimdShuffle(llvm::Instruction* inst)
         // Enabling movi requires that first lane even inactive will be within bounds of register we want.
         // It also is limited to accessing single GRF.
         // For uniform channel which will be simd1 there's probably no gain in movi.
+        bool moviPromotionEnabled = IGC_GET_FLAG_VALUE(EnableEmitMoreMoviCases);
         bool isSingleGrf = data->GetSize() <= (unsigned)getGRFSize();
         bool platformMoviTypeCheck = m_currShader->m_Platform->allowsMoviForType(data->GetType());
-        bool forcePreventOOB = isSingleGrf && platformMoviTypeCheck && !channelUniform;
+        bool forcePreventOOB = isSingleGrf && moviPromotionEnabled && platformMoviTypeCheck && !channelUniform;
 
         if (defaultConditions || forcePreventOOB)
         {

IGC/Compiler/CISACodeGen/Platform.hpp

@@ -1911,7 +1911,7 @@ bool allowProceedBasedApproachForRayQueryDynamicRayManagementMechanism() const
 }
 
 bool allowsMoviForType(VISA_Type type) const {
-  return IGC_GET_FLAG_VALUE(EnableEmitMoreMoviCases) && (type == ISA_TYPE_UD || type == ISA_TYPE_D);
+  return (type == ISA_TYPE_UD || type == ISA_TYPE_D);
 }
 
 };

IGC/Compiler/CustomSafeOptPass.cpp

@@ -1951,7 +1951,13 @@ void CustomSafeOptPass::visitTruncInst(TruncInst& I)
     To:
     %335 = call i16 @llvm.genx.GenISA.WaveShuffleIndex.i16(i16 %orig, i32 %333, i32 0)
     */
-    if( I.getSrcTy()->isIntegerTy( 32 ) && I.getDestTy()->isIntegerTy( 16 ) && IGC_IS_FLAG_DISABLED(EnableEmitMoreMoviCases))
+
+    if (IGC_IS_FLAG_ENABLED(EnableEmitMoreMoviCases))
+    {
+        return;
+    }
+
+    if( I.getSrcTy()->isIntegerTy( 32 ) && I.getDestTy()->isIntegerTy( 16 ) )
     {
         // We know all variants of shuffle from zext are safe to demote. (unlike WaveAll which might not be)
         if( auto* genIntr = dyn_cast<GenIntrinsicInst>( I.getOperand( 0 ) ); genIntr && isSubGroupShuffleVariant( genIntr ) && genIntr->hasOneUse() )

visa/ReduceExecSize.cpp

@@ -1221,7 +1221,7 @@ bool HWConformity::evenlySplitInst(INST_LIST_ITER iter, G4_BB *bb,
         } else if (srcs[j]->isScalarSrc() || (j == 0 && op == G4_line)) {
           // no need to split, but need to duplicate
           newInst->setSrc(builder.duplicateOperand(srcs[j]), j);
-        } else if (op == G4_movi && srcs[j]->asSrcRegRegion()->getRegion()->isRegion110()) {
+        } else if (op == G4_movi) {
           // we create temp region which is in VxH format
           RegionDesc VxHregionDesc = RegionDesc(UNDEFINED_SHORT, 1, 0);