Skip to content

Commit 01c1253

Browse files
committed
Attempt to have the try-delegate label after delegate{l} (failing tests)
[Currently](https://github.com/WebAssembly/exception-handling/blob/main/proposals/exception-handling/Exceptions-formal-overview.md) `(try ... delegate l)` reduces to `(label_n{} ( delegate{l} ... end ) end)`, so by putting a label outside (i.e., before) the administrative `delegate{l}`. An idea proposed in past [unresolved](WebAssembly#205 (comment)) [discussions](https://github.com/WebAssembly/exception-handling/pull/143/files#r812476148) of WebAssembly#205 and WebAssembly#143, is to simplify and improve the formalism by instead putting the delegate label inside (i.e., after) the `delegate{l}`. So instead to reduce to `(delegate{l} ( label_n{} ... end ) end)`. TL;DR ----- I can't seem to make it work. This PR explored an approach to implement this idea, in the [formal overview file ](https://github.com/WebAssembly/exception-handling/blob/main/proposals/exception-handling/Exceptions-formal-overview.md), as well as in the interpreter, but had failing tests which I wasn't able to fix. Perhaps I'm overseeing some other solution or approach, or there is some mistake in the interpreter implementation and/or argumentation below. Details ------- I think the problem is as follows. With the current [definition of block contexts](https://webassembly.github.io/exception-handling/core/exec/runtime.html#block-contexts), the instruction sequence `B^l[ delegate{l} T[val^n (throw a)] end ]` not only is ambiguous, but doesn't work with a try-catch label located outside of the try-catch. Take for example the following possible reduction. ``` (try (try (throw x) delegate 0) catch x end) ↪ (label_0{} (catch{a_x ε} (delegate{0} (label_0{} (throw a_x) end) end) end) end) ``` The intention for this delegate is to throw inside the handler `catch{a_x ε}` and be caught there. However, a possible `B^0` for the reduction of `delegate{0}` is `B^0 = [_] catch{a_x ε}`, in which case the reduction rule gives the following. ``` ↪ (label_0{} (throw a_x) end) ↪ (throw a_x) ``` The issue here seems to be that there is no label between the `delegate{l}` and the `catch{...}`. Perhaps there is a different change we can easily make it work, for example changing control contexts or block contexts? Failing tests ............. We can observe the above wrong behaviour also in the interpreter tests, although this could be fixable somehow. In particular, the first commit of this PR has the formal overview changes also implemented in the execution steps of the interpreter (in `interpreter/exec/eval.ml`): - The reduction of `try ... delegate l` puts the `label{}` after the `delegate{l}`. - The reduction of `delegate{l}` does not pattern match for an initial label. I tried to minimise a failing test from `test/core/try_delegate.wast` in the file `test/core/try_delegate_minimal_fail.wast`. To reproduce the failure build the interpreter and run the above test file as follows, for example from a Linux terminal in the base directory of the repository: ``` cd interpreter make ./wasm ../test/core/try_delegate_minimal_fail.wast ``` See also comments in the test file.
1 parent 76732ae commit 01c1253

File tree

3 files changed

+46
-9
lines changed

3 files changed

+46
-9
lines changed

interpreter/exec/eval.ml

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,7 +236,7 @@ let rec step (c : config) : config =
236236
let n1 = Lib.List32.length ts1 in
237237
let n2 = Lib.List32.length ts2 in
238238
let args, vs' = take n1 vs e.at, drop n1 vs e.at in
239-
vs', [Label (n2, [], ([], [Delegate (x.it, (args, List.map plain es')) @@ e.at])) @@ e.at]
239+
vs', [Delegate (x.it, (args, [Label (n2, [], ([], List.map plain es')) @@ e.at])) @@ e.at]
240240

241241
| Drop, v :: vs' ->
242242
vs', []
@@ -639,7 +639,10 @@ let rec step (c : config) : config =
639639
| Rethrowing _, _ ->
640640
Crash.error e.at "undefined catch label"
641641

642-
| Delegating _, _ ->
642+
| Delegating (0l, a, vs0), vs ->
643+
vs, [Throwing (a, vs0) @@ e.at]
644+
645+
| Delegating (k,_, _), _ ->
643646
Crash.error e.at "undefined delegate label"
644647

645648
| Label (n, es0, (vs', [])), vs ->

proposals/exception-handling/Exceptions-formal-overview.md

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -180,21 +180,22 @@ catch T[val^n (throw a)] end ↪ val^n (throw a)
180180
181181
182182
F; val^n (try bt instr* delegate l)
183-
↪ F; label_m{} (delegate{l} val^n instr* end) end
183+
↪ F; delegate{l} (label_m{} val^n instr* end) end
184184
(if expand_F(bt) = [t1^n]→[t2^m])
185185
186186
delegate{l} val* end ↪ val*
187187
188-
label_m{} B^l[ delegate{l} T[val^n (throw a)] end ] end
188+
B^l[ delegate{l} T[val^n (throw a)] end ]
189189
↪ val^n (throw a)
190190
```
191191

192192
Note that the last reduction step above is similar to the reduction of `br l` [1], if we look at the entire `delegate{l}...end` as the `br l`, but also doing a throw after it breaks.
193193

194-
There is a subtle difference though. The instruction `br l` searches for the `l+1`th surrounding block and breaks out after that block. Because `delegate{l}` is always wrapped in its own `label_n{} ... end` [2], with the same lookup as for `br l` we end up breaking inside the `l+1`th surrounding block, and throwing there. So if that `l+1`th surrounding block is a try, we end up throwing in its "try code", and thus correctly getting delegated to that try's catches.
194+
There is a subtle difference though. The instruction `br l` searches for the `l+1` surrounding block and breaks out after that block.
195+
On the contrary, `delegate{l}` should "break and throw" _inside_ the `l+1` label, so we should break one label earlier.
196+
This is why the reduction step for `delegate{l}` has one label less.
195197

196198
- [1] [The execution step for `br l`](https://webassembly.github.io/spec/core/exec/instructions.html#xref-syntax-instructions-syntax-instr-control-mathsf-br-l)
197-
- [2] The label that always wraps `delegate{l}...end` can be thought of as "level -1" and cannot be referred to by the delegate's label index `l`.
198199

199200
### Typing Rules for Administrative Instructions
200201

@@ -210,9 +211,9 @@ S;C, labels [t2*] ⊢ instr1* : []→[t2*]
210211
-----------------------------------------------------------
211212
S;C, labels [t2*] ⊢ catch{a? instr2*}* instr1* end : []→[t2*]
212213
213-
S;C ⊢ instr* : []→[t*]
214-
C.labels[l+1] = [t0*]
215-
------------------------------------------------------
214+
S;C, labels [t*] ⊢ instr* : []→[t*]
215+
C.labels[l] = [t0*]
216+
---------------------------------------
216217
S;C ⊢ delegate{l} instr* end : []→[t*]
217218
218219
S ⊢ tag a : tag [t0*]→[]
Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,33 @@
1+
;; This test fails with the first approach to changing the position of the
2+
;; delegate label. We could ommit the outermost try-catch_all, and get the
3+
;; error:
4+
;;
5+
;; uncaught exception: uncaught exception with args ([])
6+
;;
7+
;; As it is now, the error is:
8+
;;
9+
;; Result: 27 : i32
10+
;; Expect: 2 : i32
11+
;; ../test/core/try_delegate_minimal_fail.wast:22.1-22.77: assertion failure: wrong return values
12+
;;
13+
;; These errors indicate that the delegated exception escaped its target and was
14+
;; caught by the one surrounding it.
15+
16+
17+
(module
18+
(tag $tag)
19+
(func (export "delegate-throw-direct") (param i32) (result i32)
20+
(try $outermost (result i32)
21+
(do
22+
(try $innermost (result i32)
23+
(do
24+
(try (result i32)
25+
(do
26+
(local.get 0)
27+
(if (then (throw $tag)) (else))
28+
(i32.const 1))
29+
(delegate $innermost))) ;; delegate 0
30+
(catch $tag (i32.const 2)))) ;; end innermost
31+
(catch $tag (i32.const 27))))) ;; end outermost
32+
33+
(assert_return (invoke "delegate-throw-direct" (i32.const 1)) (i32.const 2))

0 commit comments

Comments
 (0)