Skip to content

Commit a345736

Browse files
committed
[Orc] Fix -Wsign-compare warnings in unittest
Multiple compares against `LookupsCompleted`, which is effectively an unsigned long, with constant signed integer were throwing -Wsign-compare warnings. This is effectively NFC.
1 parent dfff57e commit a345736

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

llvm/unittests/ExecutionEngine/Orc/CoreAPIsTest.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1170,7 +1170,7 @@ TEST_F(CoreAPIsStandardTest, ErrorFromAutoSuspendedAsynchronousGeneratorTest) {
11701170
},
11711171
NoDependenciesToRegister);
11721172

1173-
EXPECT_EQ(LookupsCompleted, 0);
1173+
EXPECT_EQ(LookupsCompleted, 0U);
11741174

11751175
// Suspend the first lookup.
11761176
auto LS1 = std::move(G.takeLookup().LS);
@@ -1185,7 +1185,7 @@ TEST_F(CoreAPIsStandardTest, ErrorFromAutoSuspendedAsynchronousGeneratorTest) {
11851185
},
11861186
NoDependenciesToRegister);
11871187

1188-
EXPECT_EQ(LookupsCompleted, 0);
1188+
EXPECT_EQ(LookupsCompleted, 0U);
11891189

11901190
// Unsuspend the first lookup.
11911191
LS1.continueLookup(make_error<StringError>("boom", inconvertibleErrorCode()));
@@ -1194,7 +1194,7 @@ TEST_F(CoreAPIsStandardTest, ErrorFromAutoSuspendedAsynchronousGeneratorTest) {
11941194
G.takeLookup().LS.continueLookup(
11951195
make_error<StringError>("boom", inconvertibleErrorCode()));
11961196

1197-
EXPECT_EQ(LookupsCompleted, 2);
1197+
EXPECT_EQ(LookupsCompleted, 2U);
11981198
}
11991199

12001200
TEST_F(CoreAPIsStandardTest, BlockedGeneratorAutoSuspensionTest) {

0 commit comments

Comments
 (0)