Skip to content

Commit fc32a26

Browse files
authored
build.gradle: use get() to convert Jar-task properties to strings (#2336)
* build.gradle: use get() to convert Jar-task properties to strings * main.yml: test 2 deployment tasks across all OSes, not just LInux
1 parent d0ad748 commit fc32a26

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

.github/workflows/main.yml

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -130,18 +130,16 @@ jobs:
130130
- name: Build Engine
131131
shell: bash
132132
run: |
133-
# Build
134-
./gradlew -PuseCommitHashAsVersionName=true -PskipPrebuildLibraries=true build
133+
# Normal build plus ZIP distribution and merged javadoc
134+
./gradlew -PuseCommitHashAsVersionName=true -PskipPrebuildLibraries=true \
135+
build createZipDistribution mergedJavadoc
135136
136137
if [ "${{ matrix.deploy }}" = "true" ];
137138
then
138139
# We are going to need "zip"
139140
sudo apt-get update
140141
sudo apt-get install -y zip
141142
142-
# Create the zip release and the javadoc
143-
./gradlew -PuseCommitHashAsVersionName=true -PskipPrebuildLibraries=true mergedJavadoc createZipDistribution
144-
145143
# We prepare the release for deploy
146144
mkdir -p ./dist/release/
147145
mv build/distributions/*.zip dist/release/

build.gradle

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -75,23 +75,25 @@ task libDist(dependsOn: subprojects.build, description: 'Builds and copies the e
7575
subprojects.each {project ->
7676
if(!project.hasProperty('mainClassName')){
7777
project.tasks.withType(Jar).each {archiveTask ->
78-
if(archiveTask.archiveClassifier == "sources"){
78+
String classifier = archiveTask.archiveClassifier.get()
79+
String ext = archiveTask.archiveExtension.get()
80+
if (classifier == "sources") {
7981
copy {
8082
from archiveTask.archivePath
8183
into sourceFolder
82-
rename {project.name + '-' + archiveTask.archiveClassifier +'.'+ archiveTask.archiveExtension}
84+
rename {project.name + '-' + classifier + '.' + ext}
8385
}
84-
} else if(archiveTask.archiveClassifier == "javadoc"){
86+
} else if (classifier == "javadoc") {
8587
copy {
8688
from archiveTask.archivePath
8789
into javadocFolder
88-
rename {project.name + '-' + archiveTask.archiveClassifier +'.'+ archiveTask.archiveExtension}
90+
rename {project.name + '-' + classifier + '.' + ext}
8991
}
9092
} else{
9193
copy {
9294
from archiveTask.archivePath
9395
into libFolder
94-
rename {project.name + '.' + archiveTask.archiveExtension}
96+
rename {project.name + '.' + ext}
9597
}
9698
}
9799
}

0 commit comments

Comments
 (0)