Core: Remove patches for breaking changes in jQuery 3.0.0 or older

The `self-closed-tags` patch remains, despite being a breaking change in jQuery
3.5.0, not 4.0.0. There are a few reasons for that:
1. It's an exception that a breaking change arrived in a non-major version bump.
   Some people may be upgrading from jQuery 3.4.0 or older and it's good to
   make it work for them.
2. The patch is disabled by default, so the concern of people on newer jQuery
   3.x upgrading to jQuery 4.x with Migrate 4.x getting patches restoring
   behavior from an version older than the pre-upgrade one does not exist.
3. This was a pretty big break, it may help people update if we still support
   it.

# Conflicts:
#	src/jquery/attributes.js
#	test/unit/jquery/attributes.js
#	warnings.md

Author: mgol

package-lock.json

@@ -3,7 +3,7 @@
 	"title": "jQuery Migrate",
 	"description": "Migrate older jQuery code to jQuery 3.0+",
 	"main": "dist/jquery-migrate.js",
-	"version": "3.5.3-pre",
+	"version": "4.0.0-pre",
 	"type": "module",
 	"homepage": "https://github.com/jquery/jquery-migrate",
 	"author": {

package.json

@@ -1,31 +1,14 @@
-import { migrateWarn, migratePatchAndWarnFunc, migratePatchFunc } from "../main.js";
+import { migrateWarn } from "../main.js";
 
 // Support jQuery slim which excludes the ajax module
 if ( jQuery.ajax ) {
 
-var oldAjax = jQuery.ajax,
-	oldCallbacks = [],
+var oldCallbacks = [],
 	guid = "migrate-" + Date.now(),
 	origJsonpCallback = jQuery.ajaxSettings.jsonpCallback,
 	rjsonp = /(=)\?(?=&|$)|\?\?/,
 	rquery = /\?/;
 
-migratePatchFunc( jQuery, "ajax", function() {
-	var jQXHR = oldAjax.apply( this, arguments );
-
-	// Be sure we got a jQXHR (e.g., not sync)
-	if ( jQXHR.promise ) {
-		migratePatchAndWarnFunc( jQXHR, "success", jQXHR.done, "jqXHR-methods",
-			"jQXHR.success is deprecated and removed" );
-		migratePatchAndWarnFunc( jQXHR, "error", jQXHR.fail, "jqXHR-methods",
-			"jQXHR.error is deprecated and removed" );
-		migratePatchAndWarnFunc( jQXHR, "complete", jQXHR.always, "jqXHR-methods",
-			"jQXHR.complete is deprecated and removed" );
-	}
-
-	return jQXHR;
-}, "jqXHR-methods" );
-
 jQuery.ajaxSetup( {
 	jsonpCallback: function() {
 
@@ -64,7 +47,7 @@ jQuery.ajaxPrefilter( "+json", function( s, originalSettings, jqXHR ) {
 
 	// Handle iff the expected data type is "jsonp" or we have a parameter to set
 	if ( jsonProp || s.dataTypes[ 0 ] === "jsonp" ) {
-		migrateWarn( "jsonp-promotion", "JSON-to-JSONP auto-promotion is deprecated" );
+		migrateWarn( "jsonp-promotion", "JSON-to-JSONP auto-promotion is deprecated and removed" );
 
 		// Get callback name, remembering preexisting value associated with it
 		callbackName = s.jsonpCallback = typeof s.jsonpCallback === "function" ?

src/jquery/ajax.js

@@ -1,12 +1,10 @@
 import { migratePatchFunc, migrateWarn } from "../main.js";
 
-var oldRemoveAttr = jQuery.fn.removeAttr,
-	oldJQueryAttr = jQuery.attr,
+var oldJQueryAttr = jQuery.attr,
 	oldToggleClass = jQuery.fn.toggleClass,
 	booleans = "checked|selected|async|autofocus|autoplay|controls|defer|" +
 		"disabled|hidden|ismap|loop|multiple|open|readonly|required|scoped",
 	rbooleans = new RegExp( "^(?:" + booleans + ")$", "i" ),
-	rmatchNonSpace = /\S+/g,
 
 	// Some formerly boolean attributes gained new values with special meaning.
 	// Skip the old boolean attr logic for those values.
@@ -92,34 +90,6 @@ migratePatchFunc( jQuery, "attr", function( elem, name, value ) {
 	return oldJQueryAttr.apply( this, arguments );
 }, "attr-false" );
 
-migratePatchFunc( jQuery.fn, "removeAttr", function( name ) {
-	var self = this,
-		patchNeeded = false;
-
-	jQuery.each( name.match( rmatchNonSpace ), function( _i, attr ) {
-		if ( rbooleans.test( attr ) ) {
-
-			// Only warn if at least a single node had the property set to
-			// something else than `false`. Otherwise, this Migrate patch
-			// doesn't influence the behavior and there's no need to set or warn.
-			self.each( function() {
-				if ( jQuery( this ).prop( attr ) !== false ) {
-					patchNeeded = true;
-					return false;
-				}
-			} );
-		}
-
-		if ( patchNeeded ) {
-			migrateWarn( "removeAttr-bool",
-				"jQuery.fn.removeAttr no longer sets boolean properties: " + attr );
-			self.prop( attr, false );
-		}
-	} );
-
-	return oldRemoveAttr.apply( this, arguments );
-}, "removeAttr-bool" );
-
 migratePatchFunc( jQuery.fn, "toggleClass", function( state ) {
 
 	// Only deprecating no-args or single boolean arg
@@ -128,7 +98,7 @@ migratePatchFunc( jQuery.fn, "toggleClass", function( state ) {
 		return oldToggleClass.apply( this, arguments );
 	}
 
-	migrateWarn( "toggleClass-bool", "jQuery.fn.toggleClass( boolean ) is deprecated" );
+	migrateWarn( "toggleClass-bool", "jQuery.fn.toggleClass( boolean ) is deprecated and removed" );
 
 	// Toggle entire class name of each element
 	return this.each( function() {

src/jquery/attributes.js

@@ -12,37 +12,31 @@ var arr = [],
 	// to avoid O(N^2) behavior when the engine would try matching "\s+$" at each space position.
 	rtrim = /^[\s\uFEFF\xA0]+|([^\s\uFEFF\xA0])[\s\uFEFF\xA0]+$/g;
 
-// The number of elements contained in the matched element set
-migratePatchAndWarnFunc( jQuery.fn, "size", function() {
-	return this.length;
-}, "size",
-"jQuery.fn.size() is deprecated and removed; use the .length property" );
-
 migratePatchAndWarnFunc( jQuery, "parseJSON", function() {
 	return JSON.parse.apply( null, arguments );
 }, "parseJSON",
-"jQuery.parseJSON is deprecated; use JSON.parse" );
+"jQuery.parseJSON is deprecated and removed; use JSON.parse" );
 
 migratePatchAndWarnFunc( jQuery, "holdReady", jQuery.holdReady,
 	"holdReady", "jQuery.holdReady is deprecated" );
 
 migratePatchAndWarnFunc( jQuery, "unique", jQuery.uniqueSort,
-	"unique", "jQuery.unique is deprecated; use jQuery.uniqueSort" );
+	"unique", "jQuery.unique() is deprecated and removed; use jQuery.uniqueSort()" );
 
 migratePatchAndWarnFunc( jQuery, "trim", function( text ) {
 	return text == null ?
 		"" :
 		( text + "" ).replace( rtrim, "$1" );
 }, "trim",
-"jQuery.trim is deprecated; use String.prototype.trim" );
+"jQuery.trim() is deprecated and removed; use String.prototype.trim" );
 
 migratePatchAndWarnFunc( jQuery, "nodeName", function( elem, name ) {
 	return elem.nodeName && elem.nodeName.toLowerCase() === name.toLowerCase();
 }, "nodeName",
-"jQuery.nodeName is deprecated" );
+"jQuery.nodeName() is deprecated and removed" );
 
 migratePatchAndWarnFunc( jQuery, "isArray", Array.isArray, "isArray",
-	"jQuery.isArray is deprecated; use Array.isArray"
+	"jQuery.isArray() is deprecated and removed; use Array.isArray()"
 );
 
 migratePatchAndWarnFunc( jQuery, "isNumeric",
@@ -59,7 +53,7 @@ migratePatchAndWarnFunc( jQuery, "isNumeric",
 			// subtraction forces infinities to NaN
 			!isNaN( obj - parseFloat( obj ) );
 	}, "isNumeric",
-	"jQuery.isNumeric() is deprecated"
+	"jQuery.isNumeric() is deprecated and removed"
 );
 
 // Populate the class2type map
@@ -78,18 +72,18 @@ migratePatchAndWarnFunc( jQuery, "type", function( obj ) {
 		class2type[ Object.prototype.toString.call( obj ) ] || "object" :
 		typeof obj;
 }, "type",
-"jQuery.type is deprecated" );
+"jQuery.type() is deprecated abd removed" );
 
 migratePatchAndWarnFunc( jQuery, "isFunction", function( obj ) {
 	return typeof obj === "function";
 }, "isFunction",
-"jQuery.isFunction() is deprecated" );
+"jQuery.isFunction() is deprecated and removed" );
 
 migratePatchAndWarnFunc( jQuery, "isWindow",
 	function( obj ) {
 		return obj != null && obj === obj.window;
 	}, "isWindow",
-	"jQuery.isWindow() is deprecated"
+	"jQuery.isWindow() is deprecated and removed"
 );
 
 // Bind a function to a context, optionally partially applying any

src/jquery/core.js

@@ -2,7 +2,6 @@ import { migrateWarn, migratePatchFunc } from "../main.js";
 import { camelCase } from "../utils.js";
 
 var origFnCss, internalCssNumber,
-	internalSwapCall = false,
 	ralphaStart = /^[a-z]/,
 
 	// The regex visualized:
@@ -28,52 +27,10 @@ var origFnCss, internalCssNumber,
 	//                           \ Max /       \ Height /
 	rautoPx = /^(?:Border(?:Top|Right|Bottom|Left)?(?:Width|)|(?:Margin|Padding)?(?:Top|Right|Bottom|Left)?|(?:Min|Max)?(?:Width|Height))$/;
 
-// If this version of jQuery has .swap(), don't false-alarm on internal uses
-if ( jQuery.swap ) {
-	jQuery.each( [ "height", "width", "reliableMarginRight" ], function( _, name ) {
-		var oldHook = jQuery.cssHooks[ name ] && jQuery.cssHooks[ name ].get;
-
-		if ( oldHook ) {
-			jQuery.cssHooks[ name ].get = function() {
-				var ret;
-
-				internalSwapCall = true;
-				ret = oldHook.apply( this, arguments );
-				internalSwapCall = false;
-				return ret;
-			};
-		}
-	} );
-}
-
-migratePatchFunc( jQuery, "swap", function( elem, options, callback, args ) {
-	var ret, name,
-		old = {};
-
-	if ( !internalSwapCall ) {
-		migrateWarn( "swap", "jQuery.swap() is undocumented and deprecated" );
-	}
-
-	// Remember the old values, and insert the new ones
-	for ( name in options ) {
-		old[ name ] = elem.style[ name ];
-		elem.style[ name ] = options[ name ];
-	}
-
-	ret = callback.apply( elem, args || [] );
-
-	// Revert the old values
-	for ( name in options ) {
-		elem.style[ name ] = old[ name ];
-	}
-
-	return ret;
-}, "swap" );
-
 if ( typeof Proxy !== "undefined" ) {
 	jQuery.cssProps = new Proxy( jQuery.cssProps || {}, {
 		set: function() {
-			migrateWarn( "cssProps", "jQuery.cssProps is deprecated" );
+			migrateWarn( "cssProps", "jQuery.cssProps is deprecated and removed" );
 			return Reflect.set.apply( this, arguments );
 		}
 	} );
@@ -166,8 +123,8 @@ migratePatchFunc( jQuery.fn, "css", function( name, value ) {
 		// internal check.
 		if ( !isAutoPx( camelName ) && !internalCssNumber[ camelName ] ) {
 			migrateWarn( "css-number",
-				"Number-typed values are deprecated for jQuery.fn.css( \"" +
-				name + "\", value )" );
+				"Auto-appending 'px' to number-typed values is deprecated and removed " +
+					"for jQuery.fn.css( \"" + name + "\", value )" );
 		}
 	}
 

src/jquery/css.js

@@ -79,7 +79,7 @@ Object.defineProperty( jQuery.Deferred, "getStackHook", {
 	get: function() {
 		if ( jQuery.migrateIsPatchEnabled( "deferred-getStackHook" ) ) {
 			migrateWarn( "deferred-getStackHook",
-				"jQuery.Deferred.getStackHook is deprecated; " +
+				"jQuery.Deferred.getStackHook is deprecated and removed; " +
 				"use jQuery.Deferred.getErrorHook" );
 			return jQuery.Deferred.getErrorHook;
 		} else {
@@ -89,7 +89,7 @@ Object.defineProperty( jQuery.Deferred, "getStackHook", {
 	set: function( newValue ) {
 		if ( jQuery.migrateIsPatchEnabled( "deferred-getStackHook" ) ) {
 			migrateWarn( "deferred-getStackHook",
-				"jQuery.Deferred.getStackHook is deprecated; " +
+				"jQuery.Deferred.getStackHook is deprecated and removed; " +
 					"use jQuery.Deferred.getErrorHook" );
 			jQuery.Deferred.getErrorHook = newValue;
 		} else {

src/jquery/data.js

@@ -1,30 +1,11 @@
-import { migratePatchFunc, migrateWarn } from "../main.js";
+import { migrateWarn } from "../main.js";
 import "../disablePatches.js";
 
 // Support jQuery slim which excludes the effects module
 if ( jQuery.fx ) {
 
-var intervalValue, intervalMsg,
-	oldTweenRun = jQuery.Tween.prototype.run,
-	linearEasing = function( pct ) {
-		return pct;
-	};
-
-migratePatchFunc( jQuery.Tween.prototype, "run", function( ) {
-	if ( jQuery.easing[ this.easing ].length > 1 ) {
-		migrateWarn(
-			"easing-one-arg",
-			"'jQuery.easing." + this.easing.toString() + "' should use only one argument"
-		);
-
-		jQuery.easing[ this.easing ] = linearEasing;
-	}
-
-	oldTweenRun.apply( this, arguments );
-}, "easing-one-arg" );
-
-intervalValue = jQuery.fx.interval;
-intervalMsg = "jQuery.fx.interval is deprecated";
+var intervalValue = jQuery.fx.interval,
+	intervalMsg = "jQuery.fx.interval is deprecated and removed";
 
 // Don't warn if document is hidden, jQuery uses setTimeout (gh-292)
 Object.defineProperty( jQuery.fx, "interval", {