Skip to content

Commit 8f4cd45

Browse files
karthiknadigeleanorjboyd
authored andcommitted
fix: package refresh issue when installed externally (microsoft#253)
1 parent 1fcb7b9 commit 8f4cd45

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

src/managers/builtin/pipManager.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,13 @@ export class PipPackageManager implements PackageManager, Disposable {
135135
title: 'Refreshing packages',
136136
},
137137
async () => {
138-
this.packages.set(environment.envId.id, await refreshPackages(environment, this.api, this));
138+
const before = this.packages.get(environment.envId.id) ?? [];
139+
const after = await refreshPackages(environment, this.api, this);
140+
const changes = getChanges(before, after);
141+
this.packages.set(environment.envId.id, after);
142+
if (changes.length > 0) {
143+
this._onDidChangePackages.fire({ environment, manager: this, changes });
144+
}
139145
},
140146
);
141147
}

src/managers/conda/condaPackageManager.ts

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,14 +131,20 @@ export class CondaPackageManager implements PackageManager, Disposable {
131131
},
132132
);
133133
}
134-
async refresh(context: PythonEnvironment): Promise<void> {
134+
async refresh(environment: PythonEnvironment): Promise<void> {
135135
await withProgress(
136136
{
137137
location: ProgressLocation.Window,
138138
title: CondaStrings.condaRefreshingPackages,
139139
},
140140
async () => {
141-
this.packages.set(context.envId.id, await refreshPackages(context, this.api, this));
141+
const before = this.packages.get(environment.envId.id) ?? [];
142+
const after = await refreshPackages(environment, this.api, this);
143+
const changes = getChanges(before, after);
144+
this.packages.set(environment.envId.id, after);
145+
if (changes.length > 0) {
146+
this._onDidChangePackages.fire({ environment, manager: this, changes });
147+
}
142148
},
143149
);
144150
}

0 commit comments

Comments
 (0)