Skip to content

Commit 536013b

Browse files
committed
Comment that the rdtsc intrinsics should be ok
Some more info should be in rust-lang#308, and otherwise ... Closes rust-lang#308
1 parent a8db775 commit 536013b

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

stdsimd-verify/tests/x86-intel.rs

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,10 @@ fn matches(rust: &Function, intel: &Intrinsic) -> Result<(), String> {
227227
continue;
228228
}
229229

230-
// FIXME(#308)
230+
// these flags on the rdtsc/rtdscp intrinsics we don't test for right
231+
// now, but we may wish to add these one day!
232+
//
233+
// For more info see #308
231234
if *cpuid == "TSC" || *cpuid == "RDTSCP" {
232235
continue;
233236
}
@@ -343,7 +346,9 @@ fn matches(rust: &Function, intel: &Intrinsic) -> Result<(), String> {
343346
"_mm256_setr_epi64x" |
344347
"_mm256_set1_epi64x" => true,
345348

346-
// FIXME(#308)
349+
// These return a 64-bit argument but they're assembled from other
350+
// 32-bit registers, so these work on 32-bit just fine. See #308 for
351+
// more info.
347352
"_rdtsc" |
348353
"__rdtscp" => true,
349354

0 commit comments

Comments
 (0)