You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
initialized and terminated events should only report stats summaries
Summary:
Initialized and terminated events currently produce very noisy statistics. This change makes it so that these events only record stats **summaries**. This means removing fields like breakpoints information and module identifiers. One notable addition is the `totalSharedLibraryEventHitCount` field to target stats, which was previously only calculated in the VSCode extension.
A full list of remaining stats can be seen in the description of D45575705, where I remove unnecessary stats-pruning code in the extension.
Note: in D45575705, I hoist `totalSharedLibraryEventHitCount` from inside `targetInfo` into the containing context. I could've done that here as well, but decided not to since it seemed like a target-specific stat. Maybe I should do it here too?
UPDATE: 2024/02/18 - fixed the `GetStatistics` function call.
Test Plan:
```
lldb-dotest -p TestVSCode_eventStatistic
```
Tested in D45575705 with example scuba.
Reviewers: jeffreytan, wanyi, hyubo
Reviewed By: jeffreytan
Differential Revision: https://phabricator.intern.facebook.com/D45755840
Tasks: T151692977
0 commit comments