refactor(kleros-sdk): address-coderabbit-feedback

Author: tractorss

kleros-sdk/src/errors/index.ts

@@ -1,22 +1,23 @@
-export class InvalidContextError extends Error {
-  constructor(message: string) {
+export class CustomError extends Error {
+  constructor(name: string, message: string) {
     super(message);
-    this.name = "InvalidContextError";
+    this.name = name;
 
     if (Error.captureStackTrace) {
       Error.captureStackTrace(this, this.constructor);
     }
   }
 }
 
-export class InvalidMappingError extends Error {
+export class InvalidContextError extends CustomError {
   constructor(message: string) {
-    super(message);
-    this.name = "InvalidMappingError";
+    super("InvalidContextError", message);
+  }
+}
 
-    if (Error.captureStackTrace) {
-      Error.captureStackTrace(this, this.constructor);
-    }
+export class InvalidMappingError extends CustomError {
+  constructor(message: string) {
+    super("InvalidMappingError", message);
   }
 }
 
@@ -48,14 +49,9 @@ export class RequestError extends Error {
   }
 }
 
-export class UnsupportedActionError extends Error {
+export class UnsupportedActionError extends CustomError {
   constructor(message: string) {
-    super(message);
-    this.name = "UnsupportedActionError";
-
-    if (Error.captureStackTrace) {
-      Error.captureStackTrace(this, this.constructor);
-    }
+    super("UnsupportedActionError", message);
   }
 }
 

kleros-sdk/src/requests/fetchDisputeDetails.ts

@@ -1,4 +1,4 @@
-import { request } from "graphql-request";
+import { request, gql } from "graphql-request";
 import { RequestError } from "../errors";
 
 type DisputeDetailsQueryResponse = {
@@ -13,18 +13,18 @@ type DisputeDetailsQueryResponse = {
 };
 
 const fetchDisputeDetails = async (endpoint: string, id: bigint) => {
-  const query = `
-    query DisputeDetails($id: ID!)  {
-    dispute(id: $id) {
+  const query = gql`
+    query DisputeDetails($id: ID!) {
+      dispute(id: $id) {
         arbitrated {
-            id
+          id
         }
         arbitrableChainId
         externalDisputeId
         templateId
+      }
     }
-  }
-`;
+  `;
   const variables = { id: Number(id) };
 
   try {

kleros-sdk/src/requests/fetchDisputeTemplateFromId.ts

@@ -1,4 +1,4 @@
-import { request } from "graphql-request";
+import { request, gql } from "graphql-request";
 import { RequestError } from "../errors";
 
 type DisputeTemplateQueryResponse = {
@@ -9,14 +9,14 @@ type DisputeTemplateQueryResponse = {
 };
 
 const fetchDisputeTemplateFromId = async (endpoint: string, id: number) => {
-  const query = `
-    query DisputeTemplate ($id: ID!) {
-        disputeTemplate(id: $id) {
-            templateData
-            templateDataMappings
-        }
+  const query = gql`
+    query DisputeTemplate($id: ID!) {
+      disputeTemplate(id: $id) {
+        templateData
+        templateDataMappings
+      }
     }
-`;
+  `;
 
   const variables = { id: id.toString() };
   try {