Skip to content

Commit 5ad597e

Browse files
committed
feat(chart): add support for specifying --default-load-balancer-scheme flag
1 parent b0582a8 commit 5ad597e

File tree

4 files changed

+13
-2
lines changed

4 files changed

+13
-2
lines changed

helm/aws-load-balancer-controller/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,7 @@ The default values set by the application itself can be confirmed [here](https:/
218218
| `awsApiThrottle` | Custom AWS API throttle settings | None |
219219
| `awsMaxRetries` | Maximum retries for AWS APIs | None |
220220
| `defaultTargetType` | Default target type. Used as the default value of the `alb.ingress.kubernetes.io/target-type` and `service.beta.kubernetes.io/aws-load-balancer-nlb-target-type" annotations.`Possible values are `ip` and `instance`. | `instance` |
221+
| `defaultLoadBalancerScheme` | Default scheme for ELBs. Possible values are `internal` and `internet-facing`. When not specifying, an `internal` ELB will be created by default. | "" |
221222
| `enablePodReadinessGateInject` | If enabled, targetHealth readiness gate will get injected to the pod spec for the matching endpoint pods | None |
222223
| `enableShield` | Enable Shield addon for ALB | None |
223224
| `enableWaf` | Enable WAF addon for ALB | None |

helm/aws-load-balancer-controller/templates/deployment.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,9 @@ spec:
166166
{{- if ne .Values.defaultTargetType "instance" }}
167167
- --default-target-type={{ .Values.defaultTargetType }}
168168
{{- end }}
169+
{{- if .Values.defaultLoadBalancerScheme }}
170+
- --default-load-balancer-scheme={{ .Values.defaultLoadBalancerScheme }}
171+
{{- end }}
169172
{{- if .Values.serviceTargetENISGTags }}
170173
- --service-target-eni-security-group-tags={{ .Values.serviceTargetENISGTags }}
171174
{{- end }}

helm/aws-load-balancer-controller/test.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,10 @@ awsApiThrottle:
146146
# Maximum retries for AWS APIs (default 10)
147147
awsMaxRetries:
148148

149-
150-
149+
# Default load balancer scheme when not specifying "alb.ingress.kubernetes.io/scheme" or
150+
# "service.beta.kubernetes.io/aws-load-balancer-scheme" annotations.
151+
# Possible values are "internal" and "internet-facing" (default "internal")
152+
defaultLoadBalancerScheme:
151153

152154
# If enabled, targetHealth readiness gate will get injected to the pod spec for the matching endpoint pods (default true)
153155
enablePodReadinessGateInject:

helm/aws-load-balancer-controller/values.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,11 @@ awsMaxRetries:
189189
# Cilium with masquerading enabled.
190190
defaultTargetType: instance
191191

192+
# Default load balancer scheme when not specifying "alb.ingress.kubernetes.io/scheme" or
193+
# "service.beta.kubernetes.io/aws-load-balancer-scheme" annotations.
194+
# Possible values are "internal" and "internet-facing" (default "internal")
195+
defaultLoadBalancerScheme:
196+
192197
# If enabled, targetHealth readiness gate will get injected to the pod spec for the matching endpoint pods (default true)
193198
enablePodReadinessGateInject:
194199

0 commit comments

Comments
 (0)