Skip to content

Commit ff496e4

Browse files
zac-nixonniclask25
authored and
niclask25
committed
refactor multicluster to target group props
1 parent 5de3fec commit ff496e4

File tree

4 files changed

+15
-10
lines changed

4 files changed

+15
-10
lines changed

apis/gateway/v1beta1/loadbalancerconfig_types.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -243,11 +243,6 @@ type LoadBalancerConfigurationSpec struct {
243243
// when you specify securityGroups
244244
// +optional
245245
ManageBackendSecurityGroupRules bool `json:"manageBackendSecurityGroupRules,omitempty"`
246-
247-
// EnableMultiCluster [Application / Network LoadBalancer]
248-
// All TargetGroupBindings attached to this Load Balancer will have multi cluster support enabled.
249-
// +optional
250-
EnableMultiCluster bool `json:"enableMultiCluster,omitempty"`
251246
}
252247

253248
// TODO -- these can be used to set what generation the gateway is currently on to track progress on reconcile.

apis/gateway/v1beta1/targetgroupconfig_types.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,11 @@ type TargetGroupProps struct {
216216
// +optional
217217
EnableMultiCluster bool `json:"enableMultiCluster,omitempty"`
218218

219+
// EnableMultiCluster [Application / Network LoadBalancer]
220+
// Allows for multiple Clusters / Services to use the generated TargetGroup ARN
221+
// +optional
222+
EnableMultiCluster bool `json:"enableMultiCluster,omitempty"`
223+
219224
// vpcID is the VPC of the TargetGroup. If unspecified, it will be automatically inferred.
220225
// +optional
221226
VpcID *string `json:"vpcID,omitempty"`

config/crd/bases/gateway.k8s.aws_loadbalancerconfigurations.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,6 @@ spec:
5656
enables the creation of security group rules to the managed security group
5757
to allow explicit ICMP traffic for Path MTU discovery for IPv4 and dual-stack VPCs
5858
type: boolean
59-
enableMultiCluster:
60-
description: |-
61-
EnableMultiCluster [Application / Network LoadBalancer]
62-
All TargetGroupBindings attached to this Load Balancer will have multi cluster support enabled.
63-
type: boolean
6459
enforceSecurityGroupInboundRulesOnPrivateLinkTraffic:
6560
description: enforceSecurityGroupInboundRulesOnPrivateLinkTraffic
6661
Indicates whether to evaluate inbound security group rules for traffic

config/crd/bases/gateway.k8s.aws_targetgroupconfigurations.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,11 @@ spec:
5353
description: defaultRouteConfiguration fallback configuration applied
5454
to all routes, unless overridden by route-specific configurations.
5555
properties:
56+
enableMultiCluster:
57+
description: |-
58+
EnableMultiCluster [Application / Network LoadBalancer]
59+
Allows for multiple Clusters / Services to use the generated TargetGroup ARN
60+
type: boolean
5661
enableProxyProtocolV2:
5762
description: |-
5863
enableProxyProtocolV2 [Network LoadBalancers] Indicates whether proxy protocol version 2 is enabled.
@@ -253,6 +258,11 @@ spec:
253258
targetGroupProps:
254259
description: targetGroupProps the target group specific properties
255260
properties:
261+
enableMultiCluster:
262+
description: |-
263+
EnableMultiCluster [Application / Network LoadBalancer]
264+
Allows for multiple Clusters / Services to use the generated TargetGroup ARN
265+
type: boolean
256266
enableProxyProtocolV2:
257267
description: |-
258268
enableProxyProtocolV2 [Network LoadBalancers] Indicates whether proxy protocol version 2 is enabled.

0 commit comments

Comments
 (0)