Able to set NoColor for echo.Logger and echo.middleware.Logger #2159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2159 +/- ##
==========================================
- Coverage 92.20% 92.02% -0.18%
==========================================
Files 37 37
Lines 3090 3096 +6
==========================================
Hits 2849 2849
- Misses 151 154 +3
- Partials 90 93 +3
Continue to review full report at Codecov.
|
|
This strongly relates to v5, as coloring is removed there entirely. So adding a new parameter would mean a breaking change (or having to deprecate it with v5). Not sure if we should do that now. Your views welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1871