Remove dead code (#17899)

Author: hyongtao-db

api/controllers/console/datasets/external.py

@@ -21,12 +21,6 @@ def _validate_name(name):
     return name
 
 
-def _validate_description_length(description):
-    if description and len(description) > 400:
-        raise ValueError("Description cannot exceed 400 characters.")
-    return description
-
-
 class ExternalApiTemplateListApi(Resource):
     @setup_required
     @login_required

api/controllers/console/datasets/metadata.py

@@ -14,18 +14,6 @@
 from services.metadata_service import MetadataService
 
 
-def _validate_name(name):
-    if not name or len(name) < 1 or len(name) > 40:
-        raise ValueError("Name must be between 1 to 40 characters.")
-    return name
-
-
-def _validate_description_length(description):
-    if len(description) > 400:
-        raise ValueError("Description cannot exceed 400 characters.")
-    return description
-
-
 class DatasetMetadataCreateApi(Resource):
     @setup_required
     @login_required

api/controllers/console/workspace/account.py

@@ -286,8 +286,6 @@ def post(self):
 class AccountDeleteUpdateFeedbackApi(Resource):
     @setup_required
     def post(self):
-        account = current_user
-
         parser = reqparse.RequestParser()
         parser.add_argument("email", type=str, required=True, location="json")
         parser.add_argument("feedback", type=str, required=True, location="json")

api/controllers/service_api/dataset/metadata.py

@@ -13,18 +13,6 @@
 from services.metadata_service import MetadataService
 
 
-def _validate_name(name):
-    if not name or len(name) < 1 or len(name) > 40:
-        raise ValueError("Name must be between 1 to 40 characters.")
-    return name
-
-
-def _validate_description_length(description):
-    if len(description) > 400:
-        raise ValueError("Description cannot exceed 400 characters.")
-    return description
-
-
 class DatasetMetadataCreateServiceApi(DatasetApiResource):
     def post(self, tenant_id, dataset_id):
         parser = reqparse.RequestParser()

api/controllers/service_api/dataset/segment.py

@@ -117,9 +117,6 @@ def get(self, tenant_id, dataset_id, document_id):
         parser.add_argument("keyword", type=str, default=None, location="args")
         args = parser.parse_args()
 
-        status_list = args["status"]
-        keyword = args["keyword"]
-
         segments, total = SegmentService.get_segments(
             document_id=document_id,
             tenant_id=current_user.current_tenant_id,

api/core/rag/datasource/vdb/oracle/oraclevector.py

@@ -228,7 +228,7 @@ def search_by_full_text(self, query: str, **kwargs: Any) -> list[Document]:
 
         top_k = kwargs.get("top_k", 5)
         # just not implement fetch by score_threshold now, may be later
-        score_threshold = float(kwargs.get("score_threshold") or 0.0)
+        # score_threshold = float(kwargs.get("score_threshold") or 0.0)
         if len(query) > 0:
             # Check which language the query is in
             zh_pattern = re.compile("[\u4e00-\u9fa5]+")

api/core/rag/datasource/vdb/relyt/relyt_vector.py

@@ -65,8 +65,6 @@ def get_type(self) -> str:
         return VectorType.RELYT
 
     def create(self, texts: list[Document], embeddings: list[list[float]], **kwargs) -> None:
-        index_params: dict[str, Any] = {}
-        metadatas = [d.metadata for d in texts]
         self.create_collection(len(embeddings[0]))
         self.embedding_dimension = len(embeddings[0])
         self.add_texts(texts, embeddings)

api/core/rag/datasource/vdb/tidb_vector/tidb_vector.py

@@ -187,7 +187,6 @@ def delete_by_metadata_field(self, key: str, value: str) -> None:
     def search_by_vector(self, query_vector: list[float], **kwargs: Any) -> list[Document]:
         top_k = kwargs.get("top_k", 4)
         score_threshold = float(kwargs.get("score_threshold") or 0.0)
-        filter = kwargs.get("filter")
         distance = 1 - score_threshold
 
         query_vector_str = ", ".join(format(x) for x in query_vector)

api/core/workflow/graph_engine/entities/next_graph_node.py

@@ -597,7 +597,6 @@ def _fetch_model_config(self, model: ModelConfig) -> tuple[ModelInstance, ModelC
     def _get_prompt_template(self, node_data: KnowledgeRetrievalNodeData, metadata_fields: list, query: str):
         model_mode = ModelMode.value_of(node_data.metadata_model_config.mode)  # type: ignore
         input_text = query
-        memory_str = ""
 
         prompt_messages: list[LLMNodeChatModelMessage] = []
         if model_mode == ModelMode.CHAT:

api/core/workflow/nodes/knowledge_retrieval/knowledge_retrieval_node.py

@@ -8,7 +8,6 @@
 
 @message_was_created.connect
 def handle(sender, **kwargs):
-    message = sender
     application_generate_entity = kwargs.get("application_generate_entity")
 
     if not isinstance(application_generate_entity, ChatAppGenerateEntity | AgentChatAppGenerateEntity):

api/events/event_handlers/update_provider_last_used_at_when_message_created.py

@@ -571,10 +571,6 @@ def is_email_send_ip_limit(ip_address: str):
         return False
 
 
-def _get_login_cache_key(*, account_id: str, token: str):
-    return f"account_login:{account_id}:{token}"
-
-
 class TenantService:
     @staticmethod
     def create_tenant(name: str, is_setup: Optional[bool] = False, is_from_dashboard: Optional[bool] = False) -> Tenant:

api/services/account_service.py

@@ -1,5 +1,7 @@
 import time
 
+import psycopg2  # type: ignore
+
 from core.rag.datasource.vdb.opengauss.opengauss import OpenGauss, OpenGaussConfig
 from tests.integration_tests.vdb.test_vector_store import (
     AbstractVectorTest,

api/tests/integration_tests/vdb/opengauss/test_opengauss.py

@@ -425,8 +425,8 @@ def test_multi_colons_parse(setup_http_mock):
     result = node._run()
     assert result.process_data is not None
     assert result.outputs is not None
-    resp = result.outputs
 
     assert urlencode({"Redirect": "http://example2.com"}) in result.process_data.get("request", "")
     assert 'form-data; name="Redirect"\r\n\r\nhttp://example6.com' in result.process_data.get("request", "")
+    # resp = result.outputs
     # assert "http://example3.com" == resp.get("headers", {}).get("referer")

api/tests/integration_tests/workflow/nodes/test_http.py

@@ -46,13 +46,6 @@ def test_retry_default_value_partial_success():
 
 def test_retry_failed():
     """retry failed with success status"""
-    error_code = """
-    def main() -> dict:
-        return {
-            "result": 1 / 0,
-        }
-    """
-
     graph_config = {
         "edges": DEFAULT_VALUE_EDGE,
         "nodes": [