Skip to content

Commit cf464d2

Browse files
onlysyztiankuoZhou
andauthored
fix#18595: update workflow duplicate env variable name (#18596)
Co-authored-by: tiankuo.zhou <[email protected]>
1 parent 5e09ac6 commit cf464d2

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

web/app/components/workflow/panel/env-panel/variable-modal.tsx

+7-1
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,14 @@ const VariableModal = ({
4747
return
4848
if (!value)
4949
return notify({ type: 'error', message: 'value can not be empty' })
50-
if (!env && envList.some(env => env.name === name))
50+
51+
// Add check for duplicate name when editing
52+
if (env && env.name !== name && envList.some(e => e.name === name))
53+
return notify({ type: 'error', message: 'name is existed' })
54+
// Original check for create new variable
55+
if (!env && envList.some(e => e.name === name))
5156
return notify({ type: 'error', message: 'name is existed' })
57+
5258
onSave({
5359
id: env ? env.id : uuid4(),
5460
value_type: type,

0 commit comments

Comments
 (0)