[6.x] Fixes appendRow on console table (#31469)

* [6.x] Fixes appendRow on console table.

Signed-off-by: Mior Muhammad Zaki <[email protected]>

* Fixes based on PR review.

Signed-off-by: Mior Muhammad Zaki <[email protected]>

* Fixes style.

Signed-off-by: Mior Muhammad Zaki <[email protected]>

Author: crynobone

src/Illuminate/Console/Concerns/InteractsWithIO.php

@@ -8,6 +8,7 @@
 use Symfony\Component\Console\Formatter\OutputFormatterStyle;
 use Symfony\Component\Console\Helper\Table;
 use Symfony\Component\Console\Input\InputInterface;
+use Symfony\Component\Console\Output\ConsoleOutput;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Question\ChoiceQuestion;
 use Symfony\Component\Console\Question\Question;
@@ -222,7 +223,9 @@ public function choice($question, array $choices, $default = null, $attempts = n
      */
     public function table($headers, $rows, $tableStyle = 'default', array $columnStyles = [])
     {
-        $table = new Table($this->output->getOutput()->section());
+        $output = $this->output->getOutput();
+
+        $table = new Table($output instanceof ConsoleOutput ? $output->section() : $output);
 
         if ($rows instanceof Arrayable) {
             $rows = $rows->toArray();

tests/Integration/Console/CommandWithTableTest.php

@@ -0,0 +1,63 @@
+<?php
+
+namespace Illuminate\Tests\Integration\Console;
+
+use Illuminate\Contracts\Console\Kernel as ConsoleKernel;
+use Orchestra\Testbench\TestCase;
+use Symfony\Component\Console\Exception\RuntimeException;
+
+class CommandWithTableTest extends TestCase
+{
+    protected function tearDown(): void
+    {
+        parent::tearDown();
+
+        $this->mockConsoleOutput = true;
+    }
+
+    public function testItCanExecuteCommandWithTable()
+    {
+        $this->mockConsoleOutput = false;
+
+        $this->artisan('command:table');
+    }
+
+    public function testItCantExecuteCommandWithTableAndAppendRowDueToBufferedOutput()
+    {
+        $this->mockConsoleOutput = false;
+
+        $this->expectException(RuntimeException::class);
+        $this->expectExceptionMessage('Output should be an instance of "Symfony\Component\Console\Output\ConsoleSectionOutput" when calling "Symfony\Component\Console\Helper\Table::appendRow');
+
+        $this->app[ConsoleKernel::class]->command('command:table-with-append', function () {
+            $table = $this->table([
+                'name',
+            ], [
+                ['Taylor Otwell'],
+            ]);
+
+            $table->appendRow(['Mohamed Said']);
+        });
+
+        $this->artisan('command:table-with-append');
+    }
+
+    public function testItCanExecuteMockedCommandWithTable()
+    {
+        $this->mockConsoleOutput = true;
+
+        $this->artisan('command:table')
+            ->assertExitCode(0);
+    }
+
+    protected function getEnvironmentSetUp($app)
+    {
+        $app[ConsoleKernel::class]->command('command:table', function () {
+            $this->table([
+                'name',
+            ], [
+                ['Taylor Otwell'],
+            ]);
+        });
+    }
+}