chore: [LAR-131] fix phpstan and tests

Author: mckenziearts

app/Events/CommentWasAdded.php

@@ -4,7 +4,6 @@
 
 namespace App\Events;
 
-use App\Contracts\ReplyInterface;
 use App\Models\Discussion;
 use App\Models\Reply;
 use Illuminate\Queue\SerializesModels;
@@ -13,5 +12,5 @@
 {
     use SerializesModels;
 
-    public function __construct(public Reply $reply, public Discussion|ReplyInterface $discussion) {}
+    public function __construct(public Reply $reply, public Discussion $discussion) {}
 }

phpstan.neon

@@ -12,7 +12,7 @@ parameters:
 # Remove this config after migrate everything to livewire
         - app/Http/Controllers/*
         - app/Markdown/*
-        - app/Traits/HasSlug.php
+        - app/Models/Traits/HasSlug.php
     ignoreErrors:
         - "#^Cannot access property \\$transaction on array\\|object\\.$#"
         - identifier: missingType.iterableValue

tests/Feature/Forum/DiscussionTest.php

@@ -47,19 +47,19 @@
 it('generates a slug when valid url characters provided', function (): void {
     $discussion = Discussion::factory()->make(['slug' => 'Help with eloquent']);
 
-    expect($discussion->slug())->toEqual('help-with-eloquent');
+    expect($discussion->slug)->toEqual('help-with-eloquent');
 });
 
 it('generates a unique slug when valid url characters provided', function (): void {
     $discussionOne = Discussion::factory()->create(['slug' => 'Help with eloquent']);
     $discussionTwo = Discussion::factory()->create(['slug' => 'Help with eloquent']);
 
-    expect($discussionTwo->slug())->toEqual('help-with-eloquent-1');
+    expect($discussionTwo->slug)->toEqual('help-with-eloquent-1');
 });
 
 it('generates a slug when invalid url characters provided', function (): void {
     $discussion = Discussion::factory()->make(['slug' => '한글 테스트']);
 
     // When providing a slug with invalid url characters, a random 5 character string is returned.
-    expect($discussion->slug())->toMatch('/\w{5}/');
+    expect($discussion->slug)->toMatch('/\w{5}/');
 });

tests/Feature/Forum/ThreadTest.php

@@ -145,19 +145,19 @@
 it('generates a slug when valid url characters provided', function (): void {
     $thread = Thread::factory()->make(['slug' => 'Help with eloquent']);
 
-    expect($thread->slug())->toEqual('help-with-eloquent');
+    expect($thread->slug)->toEqual('help-with-eloquent');
 });
 
 it('generates a unique slug when valid url characters provided', function (): void {
     Thread::factory()->create(['slug' => 'Help with eloquent']);
     $thread = Thread::factory()->create(['slug' => 'Help with eloquent']);
 
-    expect($thread->slug())->toEqual('help-with-eloquent-1');
+    expect($thread->slug)->toEqual('help-with-eloquent-1');
 });
 
 it('generates a slug when invalid url characters provided', function (): void {
     $thread = Thread::factory()->make(['slug' => '한글 테스트']);
 
     // When providing a slug with invalid url characters, a random 5 character string is returned.
-    expect($thread->slug())->toMatch('/\w{5}/');
+    expect($thread->slug)->toMatch('/\w{5}/');
 });