Skip to content

Commit 536802b

Browse files
kazutakahiratavar-const
authored andcommitted
Revert "[AMDGPU][GlobalISel] Properly handle lane op lowering for larger vector types (llvm#132358)"
This reverts commit 62ef10a. Multiple buildbot failures have been reported: llvm#132358
1 parent ff4353d commit 536802b

File tree

6 files changed

+34
-2767
lines changed

6 files changed

+34
-2767
lines changed

llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5580,7 +5580,6 @@ bool AMDGPULegalizerInfo::legalizeLaneOp(LegalizerHelper &Helper,
55805580
return false;
55815581

55825582
LLT PartialResTy = LLT::scalar(SplitSize);
5583-
bool NeedsBitcast = false;
55845583
if (Ty.isVector()) {
55855584
LLT EltTy = Ty.getElementType();
55865585
unsigned EltSize = EltTy.getSizeInBits();
@@ -5589,10 +5588,8 @@ bool AMDGPULegalizerInfo::legalizeLaneOp(LegalizerHelper &Helper,
55895588
} else if (EltSize == 16 || EltSize == 32) {
55905589
unsigned NElem = SplitSize / EltSize;
55915590
PartialResTy = Ty.changeElementCount(ElementCount::getFixed(NElem));
5592-
} else {
5593-
// Handle all other cases via S32/S64 pieces
5594-
NeedsBitcast = true;
55955591
}
5592+
// Handle all other cases via S32/S64 pieces;
55965593
}
55975594

55985595
SmallVector<Register, 4> PartialRes;
@@ -5618,12 +5615,7 @@ bool AMDGPULegalizerInfo::legalizeLaneOp(LegalizerHelper &Helper,
56185615
PartialRes.push_back(createLaneOp(Src0, Src1, Src2, PartialResTy));
56195616
}
56205617

5621-
if (NeedsBitcast)
5622-
B.buildBitcast(DstReg, B.buildMergeLikeInstr(
5623-
LLT::scalar(Ty.getSizeInBits()), PartialRes));
5624-
else
5625-
B.buildMergeLikeInstr(DstReg, PartialRes);
5626-
5618+
B.buildMergeLikeInstr(DstReg, PartialRes);
56275619
MI.eraseFromParent();
56285620
return true;
56295621
}

0 commit comments

Comments
 (0)