Skip to content

Commit 840ca66

Browse files
jasonmolendavar-const
authored andcommitted
Revert "[lldb] Clear thread-creation breakpoints in ProcessGDBRemote::Clear (llvm#134397)"
This reverts commit 232525f. This change is causing test crashes while running TestCompletion.py on Darwin systems, most of the CI runs have failed since it has been merged in.
1 parent e707b32 commit 840ca66

File tree

2 files changed

+0
-23
lines changed

2 files changed

+0
-23
lines changed

lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3410,9 +3410,6 @@ Status ProcessGDBRemote::DisableWatchpoint(WatchpointSP wp_sp, bool notify) {
34103410
void ProcessGDBRemote::Clear() {
34113411
m_thread_list_real.Clear();
34123412
m_thread_list.Clear();
3413-
if (m_thread_create_bp_sp)
3414-
if (TargetSP target_sp = m_target_wp.lock())
3415-
target_sp->RemoveBreakpointByID(m_thread_create_bp_sp->GetID());
34163413
}
34173414

34183415
Status ProcessGDBRemote::DoSignal(int signo) {

lldb/test/API/macosx/thread_start_bps/TestBreakpointsThreadInit.py

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -35,23 +35,3 @@ def test_internal_bps_resolved(self):
3535
for bp in bps:
3636
num_resolved += bp.GetNumResolvedLocations()
3737
self.assertGreater(num_resolved, 0)
38-
39-
@skipUnlessDarwin
40-
def test_internal_bps_deleted_on_relaunch(self):
41-
self.build()
42-
43-
source_file = lldb.SBFileSpec("main.c")
44-
target, process, thread, bkpt = lldbutil.run_to_source_breakpoint(
45-
self, "initial hello", source_file
46-
)
47-
48-
self.runCmd("break list --internal")
49-
output = self.res.GetOutput()
50-
self.assertEqual(output.count("thread-creation"), 1)
51-
52-
process.Kill()
53-
self.runCmd("run", RUN_SUCCEEDED)
54-
55-
self.runCmd("break list --internal")
56-
output = self.res.GetOutput()
57-
self.assertEqual(output.count("thread-creation"), 1)

0 commit comments

Comments
 (0)