Generic types must be used (#43)

Author: thewilkybarkid

src/Libero/ruleset.xml

@@ -101,6 +101,7 @@
             <property name="spacesCountAroundEqualsSign" value="0"/>
         </properties>
     </rule>
+    <rule ref="SlevomatCodingStandard.TypeHints.DisallowArrayTypeHintSyntax"/>
     <rule ref="SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue"/>
     <rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHintSpacing"/>
     <rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHintSpacing">

tests/cases/classes/method-generics

@@ -0,0 +1,91 @@
+---DESCRIPTION---
+Generic types must be used
+---FILENAME---
+Foo.php
+---CONTENTS---
+<?php
+
+declare(strict_types=1);
+
+namespace Vendor;
+
+class Foo
+{
+    /** @var string[] */
+    public $foo;
+
+    /** @var iterable|string[] */
+    public $bar;
+
+    /** @var ArrayObject<string> */
+    public $baz;
+
+    /**
+     * @param string[] $quux
+     * @return string[]
+     */
+    public function qux($quux)
+    {
+    }
+
+    /**
+     * @param iterable|string[] $corge
+     * @return iterable|string[]
+     */
+    public function quuz($corge)
+    {
+    }
+
+    /**
+     * @param ArrayObject<string> $garply
+     * @return ArrayObject<string>
+     */
+    public function grault($garply)
+    {
+    }
+}
+
+---FIXED---
+<?php
+
+declare(strict_types=1);
+
+namespace Vendor;
+
+class Foo
+{
+    /** @var array<string> */
+    public $foo;
+
+    /** @var iterable<string> */
+    public $bar;
+
+    /** @var ArrayObject<string> */
+    public $baz;
+
+    /**
+     * @param array<string> $quux
+     * @return array<string>
+     */
+    public function qux($quux)
+    {
+    }
+
+    /**
+     * @param iterable<string> $corge
+     * @return iterable<string>
+     */
+    public function quuz($corge)
+    {
+    }
+
+    /**
+     * @param ArrayObject<string> $garply
+     * @return ArrayObject<string>
+     */
+    public function grault($garply)
+    {
+    }
+}
+
+---

tests/cases/functions/generics

@@ -0,0 +1,63 @@
+---DESCRIPTION---
+Generic types must be used
+---FILENAME---
+Foo.php
+---CONTENTS---
+<?php
+
+declare(strict_types=1);
+
+/**
+ * @param string[] $bar
+ * @return string[]
+ */
+function foo($bar)
+{
+}
+
+/**
+ * @param iterable|string[] $qux
+ * @return iterable|string[]
+ */
+function baz($qux)
+{
+}
+
+/**
+ * @param ArrayObject<string> $quuz
+ * @return ArrayObject<string>
+ */
+function quux($quuz)
+{
+}
+
+---FIXED---
+<?php
+
+declare(strict_types=1);
+
+/**
+ * @param array<string> $bar
+ * @return array<string>
+ */
+function foo($bar)
+{
+}
+
+/**
+ * @param iterable<string> $qux
+ * @return iterable<string>
+ */
+function baz($qux)
+{
+}
+
+/**
+ * @param ArrayObject<string> $quuz
+ * @return ArrayObject<string>
+ */
+function quux($quuz)
+{
+}
+
+---

tests/cases/interfaces/method-generics

@@ -0,0 +1,61 @@
+---DESCRIPTION---
+Generic types must be used
+---FILENAME---
+Foo.php
+---CONTENTS---
+<?php
+
+declare(strict_types=1);
+
+namespace Vendor;
+
+interface Foo
+{
+    /**
+     * @param string[] $baz
+     * @return string[]
+     */
+    public function bar($baz);
+
+    /**
+     * @param iterable|string[] $quux
+     * @return iterable|string[]
+     */
+    public function qux($quux);
+
+    /**
+     * @param ArrayObject<string> $corge
+     * @return ArrayObject<string>
+     */
+    public function quuz($corge);
+}
+
+---FIXED---
+<?php
+
+declare(strict_types=1);
+
+namespace Vendor;
+
+interface Foo
+{
+    /**
+     * @param array<string> $baz
+     * @return array<string>
+     */
+    public function bar($baz);
+
+    /**
+     * @param iterable<string> $quux
+     * @return iterable<string>
+     */
+    public function qux($quux);
+
+    /**
+     * @param ArrayObject<string> $corge
+     * @return ArrayObject<string>
+     */
+    public function quuz($corge);
+}
+
+---

tests/cases/trait/method-generics

@@ -0,0 +1,87 @@
+---DESCRIPTION---
+Generic types must be used
+---FILENAME---
+Foo.php
+---CONTENTS---
+<?php
+
+declare(strict_types=1);
+
+namespace Vendor;
+
+trait Foo
+{
+    /** @var string[] */
+    public $foo;
+
+    /** @var iterable|string[] */
+    public $bar;
+
+    /** @var ArrayObject<string> */
+    public $baz;
+
+    /**
+     * @param string[] $quux
+     * @return string[]
+     */
+    public function qux($quux)
+    {
+    }
+
+    /**
+     * @param iterable|string[] $corge
+     * @return iterable|string[]
+     */
+    abstract public function quuz($corge);
+
+    /**
+     * @param ArrayObject<string> $garply
+     * @return ArrayObject<string>
+     */
+    public function grault($garply)
+    {
+    }
+}
+
+---FIXED---
+<?php
+
+declare(strict_types=1);
+
+namespace Vendor;
+
+trait Foo
+{
+    /** @var array<string> */
+    public $foo;
+
+    /** @var iterable<string> */
+    public $bar;
+
+    /** @var ArrayObject<string> */
+    public $baz;
+
+    /**
+     * @param array<string> $quux
+     * @return array<string>
+     */
+    public function qux($quux)
+    {
+    }
+
+    /**
+     * @param iterable<string> $corge
+     * @return iterable<string>
+     */
+    abstract public function quuz($corge);
+
+    /**
+     * @param ArrayObject<string> $garply
+     * @return ArrayObject<string>
+     */
+    public function grault($garply)
+    {
+    }
+}
+
+---