Skip to content

Commit 3cbf20d

Browse files
authored
Update git-cherry-pick.rst
Using the parent of the cherry-picked commit as ancestor is not correct sometimes. That looks to be an issue because `base` was not used at all in the example whereas it should be used as ancestor.
1 parent 54b9c43 commit 3cbf20d

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

docs/recipes/git-cherry-pick.rst

+2-3
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,9 @@ example `three-argument rebases`_.
5151
cherry = repo.revparse_single('9e044d03c')
5252
basket = repo.branches.get('basket')
5353
54-
base = repo.merge_base(cherry.id, basket.target)
55-
base_tree = cherry.parents[0].tree
54+
base = repo.merge_base(cherry.id, basket.target)
5655
57-
index = repo.merge_trees(base_tree, basket, cherry)
56+
index = repo.merge_trees(base, basket, cherry)
5857
tree_id = index.write_tree(repo)
5958
6059
author = cherry.author

0 commit comments

Comments
 (0)