Skip to content

Commit 3cd8fed

Browse files
committed
implementing merge - some fixes for the pull request: MergeRestul typedef, pep7 fixes and some error checks
1 parent 6855a59 commit 3cd8fed

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

src/repository.c

+2-4
Original file line numberDiff line numberDiff line change
@@ -613,9 +613,8 @@ Repository_merge(Repository *self, PyObject *py_oid)
613613
err = git_merge(&merge_result, self->repo,
614614
(const git_merge_head **)&oid_merge_head, 1,
615615
&default_opts);
616-
if (err < 0)
617-
{
618-
git_merge_result_free(merge_result);
616+
if (err < 0) {
617+
git_merge_head_free(oid_merge_head);
619618
goto error;
620619
}
621620

@@ -627,7 +626,6 @@ Repository_merge(Repository *self, PyObject *py_oid)
627626
return py_merge_result;
628627

629628
error:
630-
git_merge_head_free(oid_merge_head);
631629
return Error_set(err);
632630
}
633631

src/types.h

+1-8
Original file line numberDiff line numberDiff line change
@@ -218,13 +218,6 @@ typedef struct {
218218
} BlameHunk;
219219

220220
/* git_merge */
221-
typedef struct {
222-
PyObject_HEAD
223-
int is_uptodate;
224-
int is_fastforward;
225-
PyObject* fastforward_oid;
226-
PyObject* status;
227-
228-
} MergeResult;
221+
SIMPLE_TYPE(MergeResult, git_merge_result, result)
229222

230223
#endif

0 commit comments

Comments
 (0)