Skip to content

Commit 5410128

Browse files
committed
TreeEntry: move to use 'id' attribute for the object's id
Similar to the Object change, we should be using 'id' when referring to the target's id.x
1 parent 500a679 commit 5410128

File tree

3 files changed

+16
-6
lines changed

3 files changed

+16
-6
lines changed

src/tree.c

+12-2
Original file line numberDiff line numberDiff line change
@@ -67,17 +67,26 @@ TreeEntry_name__get__(TreeEntry *self)
6767
}
6868

6969

70-
PyDoc_STRVAR(TreeEntry_oid__doc__, "Object id.");
70+
PyDoc_STRVAR(TreeEntry_id__doc__, "Object id.");
7171

7272
PyObject *
73-
TreeEntry_oid__get__(TreeEntry *self)
73+
TreeEntry_id__get__(TreeEntry *self)
7474
{
7575
const git_oid *oid;
7676

7777
oid = git_tree_entry_id(self->entry);
7878
return git_oid_to_python(oid);
7979
}
8080

81+
PyDoc_STRVAR(TreeEntry_oid__doc__, "Object id.\n"
82+
"This attribute is deprecated. Please use 'id'");
83+
84+
PyObject *
85+
TreeEntry_oid__get__(TreeEntry *self)
86+
{
87+
return TreeEntry_id__get__(self);
88+
}
89+
8190
PyObject *
8291
TreeEntry_richcompare(PyObject *a, PyObject *b, int op)
8392
{
@@ -133,6 +142,7 @@ PyGetSetDef TreeEntry_getseters[] = {
133142
GETTER(TreeEntry, filemode),
134143
GETTER(TreeEntry, name),
135144
GETTER(TreeEntry, oid),
145+
GETTER(TreeEntry, id),
136146
GETTER(TreeEntry, hex),
137147
{NULL}
138148
};

test/test_tree.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def test_read_subtree(self):
7777
subtree_entry = tree['c']
7878
self.assertTreeEntryEqual(subtree_entry, SUBTREE_SHA, 'c', 0o0040000)
7979

80-
subtree = self.repo[subtree_entry.oid]
80+
subtree = self.repo[subtree_entry.id]
8181
self.assertEqual(1, len(subtree))
8282
sha = '297efb891a47de80be0cfe9c639e4b8c9b450989'
8383
self.assertTreeEntryEqual(subtree[0], sha, 'd', 0o0100644)
@@ -100,8 +100,8 @@ def test_new_tree(self):
100100
self.assertEqual(x.filemode, 0o0100644)
101101
self.assertEqual(y.filemode, 0o0100755)
102102

103-
self.assertEqual(repo[x.oid].id, b0)
104-
self.assertEqual(repo[y.oid].id, b1)
103+
self.assertEqual(repo[x.id].id, b0)
104+
self.assertEqual(repo[y.id].id, b1)
105105

106106

107107
def test_modify_tree(self):

test/test_treebuilder.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def test_rebuild_treebuilder(self):
6868
name = entry.name
6969
self.assertTrue(bld.get(name) is None)
7070
bld.insert(name, entry.hex, entry.filemode)
71-
self.assertEqual(bld.get(name).oid, entry.oid)
71+
self.assertEqual(bld.get(name).id, entry.id)
7272
result = bld.write()
7373

7474
self.assertEqual(len(bld), len(tree))

0 commit comments

Comments
 (0)