Now discover_repository returns None if repo not found

Issue #531

Author: jdavid

CHANGELOG.rst

@@ -1,3 +1,21 @@
+0.27.1 (unreleased)
+-------------------------
+
+Breaking changes:
+
+- Now ``discover_repository`` returns ``None`` if repository not found, instead
+  of raising ``KeyError``
+  `#531 <https://github.com/libgit2/pygit2/issues/531>`_
+
+Other changes:
+
+- New ``DiffLine.raw_content``
+  `#610 <https://github.com/libgit2/pygit2/issues/610>`_
+
+- Automatize wheels upload to pypi
+  `#563 <https://github.com/libgit2/pygit2/issues/563>`_
+
+
 0.27.0 (2018-03-30)
 -------------------------
 

src/pygit2.c

@@ -73,7 +73,7 @@ extern PyTypeObject WorktreeType;
 PyDoc_STRVAR(discover_repository__doc__,
   "discover_repository(path[, across_fs[, ceiling_dirs]]) -> str\n"
   "\n"
-  "Look for a git repository and return its path.");
+  "Look for a git repository and return its path. If not found returns None.");
 
 PyObject *
 discover_repository(PyObject *self, PyObject *args)
@@ -90,6 +90,8 @@ discover_repository(PyObject *self, PyObject *args)
 
     memset(&repo_path, 0, sizeof(git_buf));
     err = git_repository_discover(&repo_path, path, across_fs, ceiling_dirs);
+    if (err == GIT_ENOTFOUND)
+        Py_RETURN_NONE;
     if (err < 0)
         return Error_set_str(err, path);
 

test/test_attributes.py

@@ -25,23 +25,14 @@
 # the Free Software Foundation, 51 Franklin Street, Fifth Floor,
 # Boston, MA 02110-1301, USA.
 
-# Import from the future
+# The future
 from __future__ import absolute_import
 from __future__ import unicode_literals, print_function
 
-# Import from the Standard Library
-import binascii
-import unittest
-import tempfile
-import os
-from os.path import join, realpath
-import sys
+# Standard Library
+from os.path import join
 
-# Import from pygit2
-from pygit2 import GIT_OBJ_ANY, GIT_OBJ_BLOB, GIT_OBJ_COMMIT
-from pygit2 import init_repository, clone_repository, discover_repository
-from pygit2 import Oid, Reference, hashfile
-import pygit2
+# pygit2
 from . import utils
 
 try:

test/test_repository.py

@@ -511,6 +511,9 @@ def test_discover_repo(self):
         os.makedirs(subdir)
         self.assertEqual(repo.path, discover_repository(subdir))
 
+    def test_discover_repo_not_found(self):
+        self.assertIsNone(discover_repository(tempfile.tempdir))
+
 
 class EmptyRepositoryTest(utils.EmptyRepoTestCase):