Python 3.4 support

[rshipp]

The README states that:

Pygit2 works with Python 2.7, 3.2, 3.3, 3.4 and pypy.

However, the .travis.yml only runs tests on 2,7, 3.2, 3.3, and pypy. In addition, when I try to build pygit2 with Python 3.4, the build fails. Does pygit2 support 3.4? (And if so, why might my build be failing?)

[jdavid]

Hello, just added Python 3.4 to travis and the tests pass, see https://travis-ci.org/libgit2/pygit2

Change your requirements file to use the latest version of pygit2 from github, and show us the build if it still fails.

[carlosmn]

The error isn't so much with python, but with the -Werror=declaration-after-statement argument to GCC which may or may not make sense for extension modules. I think I've come across this before, where some installations use the same CFLAGS for the extensions as Python uses to build itself, which can cause unexpected issues, as many distro packages don't do this.

You can add -Wno-error=declaration-after-statement to your CFLAGS in order to stop gcc from considering it an error until there's a newer release available where the code now complies with the 24 yo standard, rather than the 15 yo one.

[rshipp]

Alright, adding that option to my CFLAGS before building pygit2 from PyPi worked. Since pygit2's own tests pass on 3.4, I assume that means the next release won't need the -Wno-error=declaration... flag?

[carlosmn]

That's right, it was an oversight that was fixed in c68de8e.

[rshipp]

Awesome, thanks for the help. :)